Skip to contentSkip to conversation

staging: comedi: change type of num_subdevices parameter to comedi_alloc_subdevices

PATCH In review H Hartley Sweeten 2 participants 2 messages Jun 12, 2012 Staging

lore
Share & tools
lore

H Hartley Sweeten

author
#0 lore raw

PATCH 2/8 staging: comedi: change type of num_subdevices parameter to comedi_alloc_subdevices

Quoted 1 line

From 606739d47df00ac9767e3256ab8f6eb1572bd429 Mon Sep 17 00:00:00 2001

From: H Hartley Sweeten <[email protected]>
Date: Tue, 12 Jun 2012 09:45:17 -0700
Subject: [PATCH 2/8] staging: comedi: change type of num_subdevices parameter
to comedi_alloc_subdevices

The n_subdevices variable of struct comedi_device is an int type. Change the type of the comedi_alloc_subdevices 'num_subdevices' from an unsigned int to an int to match it.

Signed-off-by H Hartley Sweeten <[email protected]>
Cc Ian Abbott <[email protected]>
Cc Frank Mori Hess <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
---
 drivers/staging/comedi/comedidev.h |    2 +-
 drivers/staging/comedi/drivers.c   |    5 ++---
 2 files changed, 3 insertions(+), 4 deletions(-)
drivers/staging/comedi/comedidev.h +1 -1
index bb98f82..e0f3915 100644
@@ -292,7 +292,7 @@ static inline struct comedi_subdevice *comedi_get_write_subdevice(
 	return info->device->write_subdev;
 }
 
-int comedi_alloc_subdevices(struct comedi_device *, unsigned int);
+int comedi_alloc_subdevices(struct comedi_device *, int);
 
 void comedi_device_detach(struct comedi_device *dev);
 int comedi_device_attach(struct comedi_device *dev,
drivers/staging/comedi/drivers.c +2 -3
index cce7521..87a87dd 100644
@@ -56,10 +56,9 @@ static int poll_invalid(struct comedi_device *dev, struct comedi_subdevice *s);
 
 struct comedi_driver *comedi_drivers;
 
-int comedi_alloc_subdevices(struct comedi_device *dev,
-			    unsigned int num_subdevices)
+int comedi_alloc_subdevices(struct comedi_device *dev, int num_subdevices)
 {
-	unsigned i;
+	int i;
 
 	dev->n_subdevices = num_subdevices;
 	dev->subdevices =
Signature · 1 line
1.7.7
maintainer
#1 lore raw
Quoted 9 lines · H Hartley Sweeten

From 606739d47df00ac9767e3256ab8f6eb1572bd429 Mon Sep 17 00:00:00 2001
From: H Hartley Sweeten <[email protected]>
Date: Tue, 12 Jun 2012 09:45:17 -0700
Subject: [PATCH 2/8] staging: comedi: change type of num_subdevices parameter
to comedi_alloc_subdevices

The n_subdevices variable of struct comedi_device is an int type. Change the type of the comedi_alloc_subdevices 'num_subdevices' from an unsigned int to an int to match it.

Ok, some hints on how to send emails, don't do it this way :)

You need to use git send-email, which will not duplicate the From and stuff in the body of the email.

Otherwise, I have to edit the patches by hand, or that information ends up in the commit log for the patch:

-----------
commit c70c98a0180522411aff8eb87e10523eef2fe3f6

Author: H Hartley Sweeten <[email protected]>
Date:   Tue Jun 12 11:57:27 2012 -0700

staging: comedi: change type of num_subdevices parameter to comedi_alloc_subdevices

From 606739d47df00ac9767e3256ab8f6eb1572bd429 Mon Sep 17 00:00:00 2001
From: H Hartley Sweeten <[email protected]>
Date: Tue, 12 Jun 2012 09:45:17 -0700
Subject: [PATCH 2/8] staging: comedi: change type of num_subdevices parameter
to comedi_alloc_subdevices

The n_subdevices variable of struct comedi_device is an int type. Change the type of the comedi_alloc_subdevices 'num_subdevices' from an unsigned int to an int to match it.

Signed-off-by H Hartley Sweeten <[email protected]>
Cc Ian Abbott <[email protected]>
Cc Frank Mori Hess <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>

-------------

I'll edit up these 8, but in the future, please don't do that.

thanks,

greg k-h