Skip to contentSkip to conversation

VFIO compile failure on i386 allmodconfig in linux-next

DISCUSSION Paul Gortmaker 2 participants 2 messages Jun 28, 2012 Linux-next tree

lore
Share & tools
lore
#0 lore raw

Hi Alex,

Just a heads up that the i386 allmodconfig failed on VFIO, in case you didn't see it.

http://kisskb.ellerman.id.au/kisskb/buildresult/6603285/

arch/x86/include/asm/uaccess_32.h:211:26: error: call to 'copy_from_user_overflow' declared with attribute error: copy_from_user() buffer size is not provably correct make[4]: *** [drivers/vfio/pci/vfio_pci_config.o] Error 1

Paul.

#1 lore raw
Quoted 9 lines · Paul Gortmaker

Hi Alex,

Just a heads up that the i386 allmodconfig failed on VFIO, in case you didn't see it.

http://kisskb.ellerman.id.au/kisskb/buildresult/6603285/

arch/x86/include/asm/uaccess_32.h:211:26: error: call to 'copy_from_user_overflow' declared with attribute error: copy_from_user() buffer size is not provably correct make[4]: *** [drivers/vfio/pci/vfio_pci_config.o] Error 1

Thank you for the report. This looks bogus to me, it's complaining about a copy_from_user into an __le32 because it can't determine the number of bytes to be copied. That number is a parameter to the function, but the function is static and only called with values of 1, 2 or 4. I've added a test that seems to make the compiler happy, so this will be fixed in tomorrow's tree. Thanks!

Alex