kernel: fix mishandling of out of memory in poweroff

From: Alan Cox <[email protected]>

Coverity 703573

---

 kernel/sys.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

index b04ae03..9271b7c 100644
@@ -2212,13 +2212,13 @@ int orderly_poweroff(bool force)
 
 	ret = call_usermodehelper_fns(argv[0], argv, envp, UMH_NO_WAIT,
 				      NULL, argv_cleanup, NULL);
-out:
 	if (likely(!ret))
 		return 0;
 
 	if (ret == -ENOMEM)
 		argv_free(argv);
 
+out:
 	if (force) {
 		printk(KERN_WARNING "Failed to start orderly shutdown: "
 		       "forcing the issue\n");

It would be nice to have a Reported-by here, but we were only given "Scan Subscription <[email protected]>".

Is there some human behind these reports? If so, can that person's details please be included?

Hi Andew,

The two reports that were sent on 6/28 and 7/6, were sent manually by us, Coverit Scan Admin, project dedicated for Open Source Community.
But going forward (next week), it will be completely automated.
Based on the suggestions we got from some of the lead Linux Developer, weekly report includes only "Newly" discovered defects from the code change in that week, and will be sent to maintainer and to the community. There are on an avg. 5-10 new defects in a week, sometime none.

Any one who wants to contact the person for the reports being sent, they can use the details provided at the end of the email that is [email protected] However, we are open to suggestions.

Reasons for using generic email
1. It is desgined to be automated, but so far it was manuall.
2. There are group of people behind this email and not just one. So, anyone who is available will respond.
3. Other Open Source community has shown the same interest to generate report on newly discoverd defect every time build is commited to Scan, and we use the same generic email address to subscribe and to send the reoprt to their mailing list, instead of creating separate email for each Open Source project.

Hence, using either [email protected] or [email protected] would be fine, but better would be to use the one in the email signaure, that is, [email protected] We will add "Reported By" in the next report.

However, as I said, we are open to suggestions.

Thanks
Coverity Scan-Admin [email protected]
Dakshesh Vyas | Technical Manager - SCAN
Coverity | 185 Berry Street | Suite 6500, Lobby 3 | San Francisco, CA 94107
Office: 415.935.2957 | [email protected]
http://scan.coverity.com

________________________________________
From: Andrew Morton [[email protected]]
Sent: Tuesday, July 10, 2012 1:15 PM
To: Alan Cox
Cc: [email protected]; Scan Subscription
Subject: Re: [PATCH] kernel: fix mishandling of out of memory in poweroff

It would be nice to have a Reported-by here, but we were only given "Scan Subscription <[email protected]>".

Is there some human behind these reports? If so, can that person's
details please be included?ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ¥Šwÿº{.nÇ+‰·¥Š{±þG«�éÿŠ{ayºʇڙë,j­¢f£¢·hš�ï�êÿ‘êçz_è®(­éšŽŠÝ¢j"�ú¶m§ÿÿ¾«þG«�éÿ¢¸?™¨è­Ú&£ø§~�á¶iO•æ¬z·švØ^¶m§ÿÿÃÿ¶ìÿ¢¸?–I¥

Also note that gmail marks these as "Spam" probably because of the word "subscription".

Regards,

Ozan Çağlayan

Not here.

Thanks,
//richard

(I can't find Alan's initial email, so reply to this one.)

Hi, Alan,

I sent a same patch few minutes ahead of yours:

http://marc.info/?l=linux-kernel&m=134137296531838

and got some ACK's already.