Staging: xgifb: Rework some conditions in XGI_SetCRT2ModeRegs().
Quoted 2 lines · Miguel Gómez
Rework some conditions to reduce indentation and fix style warnings.
Instead of a do { } while(0); it would be better to just use gotos.
regards,
dan carpenter
Quoted 5 lines · Miguel Gómez
Quoted 2 lines
Rework some conditions to reduce indentation and fix style warnings.
Instead of a do { } while(0); it would be better to just use gotos.
Point taken. I used the do-while because I didn't want to abuse gotos, but if there's no problem with them I'll change the patch.
I'll also change your comments in previous email about the comments ;)
Regards!
Signature · 2 lines
Miguel Gómez Igalia - http://www.igalia.com
Quoted 9 lines · Miguel Gómez
Quoted 5 lines · Miguel Gómez
Quoted 2 lines
Rework some conditions to reduce indentation and fix style warnings.
Instead of a do { } while(0); it would be better to just use gotos.
Point taken. I used the do-while because I didn't want to abuse gotos, but if there's no problem with them I'll change the patch.
That style of goto is fine/standard in the kernel.
regards,
dan carpenter