Skip to contentSkip to conversation

Ross Burton : connman: ship the empty plugins directory in the connman package

oe-commits Martin Jansa 2 participants 4 messages Jul 9, 2012 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 20120709160054.C9FA610219@opal

#1 lore raw
Quoted 11 lines · On Mon, Jul 09, 2012 at 04:00:54PM +0000, [email protected] wrote:
Module: openembedded-core.git
Branch: master
Commit: 8a307af8253a5fdff51515fe01ef7b527fdad89f
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=8a307af8253a5fdff51515fe01ef7b527fdad89f
Author: Ross Burton <[email protected]>
Date:   Fri Jul  6 12:05:42 2012 +0100

connman: ship the empty plugins directory in the connman package

Otherwise we get a QA warning that /usr/lib/connman/packages isn't shipped.

both patches from Ross in this batch are missing SOB lines.

Ross: please make sure you add them in future patches
sgw: maybe you're using different flow then RP for merging patches, but your SOB should be there too IMHO.

Cheers,

Quoted 42 lines

---

 meta/recipes-connectivity/connman/connman.inc |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
meta/recipes-connectivity/connman/connman.inc +3 -2
index 73e7818..12378e9 100644
@@ -20,7 +20,7 @@ DEPENDS  = "dbus glib-2.0 ppp iptables gnutls \
             ${@base_contains('DISTRO_FEATURES', '3g','ofono', '', d)} \
             "
 
-INC_PR = "r10"
+INC_PR = "r11"
 
 TIST = "--enable-tist"
 TIST_powerpc = ""
@@ -99,7 +99,7 @@ python populate_packages_prepend() {
 	hook = lambda file,pkg,b,c,d:packages.append((file,pkg))
 	plugin_dir = d.expand('${libdir}/connman/plugins/')
 	plugin_name = d.expand('${PN}-plugin-%s')
-	do_split_packages(d, plugin_dir, '^(.*).so$', plugin_name, '${PN} plugin for %s', extra_depends='', hook=hook )
+	do_split_packages(d, plugin_dir, '^(.*).so$', plugin_name, '${PN} plugin for %s', extra_depends='', hook=hook, prepend=True )
 	for (file, package) in packages:
 		plugintype = package.split( '-' )[-1]
 		if plugintype in depmap:
@@ -116,6 +116,7 @@ FILES_${PN}-tests = "${bindir}/*-test ${libdir}/${BPN}/test/*"
 RDEPENDS_${PN}-tests = "python-dbus"
 
 FILES_${PN} = "${bindir}/* ${sbindir}/* ${libexecdir}/* ${libdir}/lib*.so.* \
+            ${libdir}/connman/plugins \
             ${sysconfdir} ${sharedstatedir} ${localstatedir} \
             ${base_bindir}/* ${base_sbindir}/* ${base_libdir}/*.so* ${datadir}/${PN} \
             ${datadir}/dbus-1/system-services/*"

_______________________________________________
Openembedded-commits mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-commits

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#2 lore raw
Quoted 3 lines · Martin Jansa

Ross: please make sure you add them in future patches
sgw: maybe you're using different flow then RP for merging patches, but your SOB should be there too IMHO.

I *always* forget, sorry. Is there a way to make git do it automatically?...

Ross

#3 lore raw
Quoted 6 lines · Ross
Quoted 3 lines · Martin Jansa

Ross: please make sure you add them in future patches
sgw: maybe you're using different flow then RP for merging patches, but your SOB should be there too IMHO.

I *always* forget, sorry. Is there a way to make git do it automatically?...

Not sure if there is smarter way. I'm using aliases for commit and cherry-pick to always add '-s'.

Cheers,

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#4 lore raw
Quoted 10 lines · Martin Jansa
Quoted 6 lines · Ross
Quoted 3 lines · Martin Jansa

Ross: please make sure you add them in future patches
sgw: maybe you're using different flow then RP for merging patches, but your SOB should be there too IMHO.

I *always* forget, sorry. Is there a way to make git do it automatically?...

Not sure if there is smarter way. I'm using aliases for commit and cherry-pick to always add '-s'.

The config option format.signoff will automatically sign-off when using format-patch, which sounds rather useful to me.

Ross