block: Support online resize of disk partitions
Subsystems (3)
v4 cover block: Support online resize of disk partitions
Hi,
Few people have pinged me in rencent past about status of this patch, hence, this is V4 of patch which adds support for online resizing of a partition. This patch is based on previously posted patches by Phillip Susi.
There are two patches. Out of which one is kernel patch and other one is util-linux patch to add support of a user space utility "resizepart" to allow resizing the partition.
This ioctl only resizes the partition size in kenrel and does not change the size on disk. A user needs to make sure that corresponding changes are made to disk data structures also using fdisk(or partx), if changes are to be retained across reboot.
Changes since V3
----------------
- Do bdput() in error path as per the Maxim's review comments.
Changes since V2
----------------
- Do not ignore the "start" parameter in RESIZE ioctl.
- Change resizepart utility to parse sysfs to get to partition start.
Changes since V1
----------------
Following are changes since the version Phillip posted.
- RESIZE ioctl ignores the partition "start" and does not expect user to specify one. Caller needs to just specify "device", "partition number" and "size" of new partition.
- Got rid of part_nr_sects_write_begin/part_nr_sects_write_end functions and replaced these with single part_nr_sects_write().
- Some sequence counter related changes are simply lifted from i_size_write().
- Initialized part->nr_sects_seq using seqcount_init().
Phillip, do let me know if I should put your signed-off-by also in the patch.
Any review feedback is welcome.
I did following test.
- Create a partition of 10MB on a disk using fdisk.
- Add this partition to a volume group
- Use fdisk to increase the partition size to 20MB. (First delete the partition and then create a new one of 20MB size).
- Use resizepart to extend partition size in kernel.
resizepart /dev/sdc 1 40960
- Do pvresize on partition so that physical volume can be incrased in size online.
pvresize /dev/sda1
pvresize does recognize the new size. Also lsblk and /proc/partitions report the new size of partition.
Thanks
Vivek
PATCH v4 1/2 block: add partition resize function to blkpg ioctl
Add a new operation code (BLKPG_RESIZE_PARTITION) to the BLKPG ioctl that allows altering the size of an existing partition, even if it is currently in use.
This patch converts hd_struct->nr_sects into sequence counter because One might extend a partition while IO is happening to it and update of nr_sects can be non-atomic on 32bit machines with 64bit sector_t. This can lead to issues like reading inconsistent size of a partition. Sequence counter have been used so that readers don't have to take bdev mutex lock as we call sector_in_part() very frequently.
Now all the access to hd_struct->nr_sects should happen using sequence counter read/update helper functions part_nr_sects_read/part_nr_sects_write. There is one exception though, set_capacity()/get_capacity(). I think theoritically race should exist there too but this patch does not modify set_capacity()/get_capacity() due to sheer number of call sites and I am afraid that change might break something. I have left that as a TODO item. We can handle it later if need be. This patch does not introduce any new races as such w.r.t set_capacity()/get_capacity().
--- block/genhd.c | 20 +++++++++++---- block/ioctl.c | 59 ++++++++++++++++++++++++++++++++++++++++++-- block/partition-generic.c | 4 ++- include/linux/blkpg.h | 1 + include/linux/genhd.h | 57 +++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 132 insertions(+), 9 deletions(-)
block/genhd.c +15 -5
@@ -154,7 +154,7 @@ struct hd_struct *disk_part_iter_next(struct disk_part_iter *piter) part =rcu_dereference (ptbl->part[piter->idx]);if (!part)continue ; -if (!part->nr_sects && +if (!part_nr_sects_read (part) && !(piter->flags &DISK_PITER_INCL_EMPTY ) && !(piter->flags &DISK_PITER_INCL_EMPTY_PART0 && piter->idx ==0 ))
@@ -191,7 +191,7 @@ EXPORT_SYMBOL_GPL(disk_part_iter_exit);static inline int sector_in_part (struct hd_struct *part,sector_t sector) {return part->start_sect <= sector && - sector < part->start_sect + part->nr_sects; + sector < part->start_sect +part_nr_sects_read (part); }/**
@@ -769,8 +769,8 @@ void __init printk_all_partitions(void)printk ("%s%s %10llu %s %s" , is_part0 ?"" :" " ,bdevt_str (part_devt (part), devt_buf), - (unsigned long long )part->nr_sects >>1 , -disk_name (disk, part->partno, name_buf), + (unsigned long long )part_nr_sects_read (part) >>1 + ,disk_name (disk, part->partno, name_buf), uuid_buf);if (is_part0) { if (disk->driverfs_dev != NULL &&
@@ -862,7 +862,7 @@ static int show_partition(struct seq_file *seqf, void *v)while ((part =disk_part_iter_next (&piter)))seq_printf (seqf,"%4d %7d %10llu %s\n" ,MAJOR (part_devt (part)),MINOR (part_devt (part)), - (unsigned long long )part->nr_sects >>1 , + (unsigned long long )part_nr_sects_read (part) >>1 ,disk_name (sgp, part->partno, buf));disk_part_iter_exit (&piter);
@@ -1268,6 +1268,16 @@ struct gendisk *alloc_disk_node(int minors, int node_id) } disk->part_tbl->part[0 ] = &disk->part0; +/* +* set_capacity() and get_capacity() currently don't use +* seqcounter to read/update the part0->nr_sects. Still init +* the counter as we can read the sectors in IO submission +* patch using seqence counters. +* +* TODO: Ideally set_capacity() and get_capacity() should be +* converted to make use of bd_mutex and sequence counters. +*/ +seqcount_init (&disk->part0.nr_sects_seq);hd_ref_init (&disk->part0); disk->minors = minors;
block/ioctl.c +56 -3
77 lines not on this page · raw message
block/partition-generic.c +3 -1
@@ -84,7 +84,7 @@ ssize_t part_size_show(struct device *dev, struct device_attribute *attr, char *buf) { struct hd_struct *p = dev_to_part(dev); -return sprintf (buf,"%llu\n" ,(unsigned long long )p->nr_sects); +return sprintf (buf,"%llu\n" ,(unsigned long long )part_nr_sects_read (p)); } static ssize_t part_ro_show(struct device *dev,
@@ -294,6 +294,8 @@ struct hd_struct *add_partition(struct gendisk *disk, int partno, err = -ENOMEM ; goto out_free; } + +seqcount_init (&p->nr_sects_seq); pdev =part_to_dev (p); p->start_sect = start;
include/linux/blkpg.h +1 -0
@@ -40,6 +40,7 @@ struct blkpg_ioctl_arg {/* The subfunctions (for the op field) */ #define BLKPG_ADD_PARTITION 1#define BLKPG_DEL_PARTITION 2 +#define BLKPG_RESIZE_PARTITION 3/* Sizes of name fields. Unused at present. */ #define BLKPG_DEVNAMELTH 64
include/linux/genhd.h +57 -0
70 lines not on this page · raw message
Signature · 1 line
1.7.7.6
PATCH v4 2/2 util-linux: resizepart: Utility to resize a partition
In reply to [email protected]A simple user space utility to resize an existing partition. It tries to read the start of partiton from sysfs.
This is a real quick dirty patch I used for my testing. I am sure there are better and faster ways of getting to partition "start" from device and partition number.
--- disk-utils/Makemodule.am | 7 +++- disk-utils/partx.h | 19 +++++++++ disk-utils/resizepart.8 | 38 ++++++++++++++++++ disk-utils/resizepart.c | 98 ++++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 161 insertions(+), 1 deletions(-) create mode 100644 disk-utils/resizepart.8 create mode 100644 disk-utils/resizepart.c
disk-utils/Makemodule.am +6 -1
@@ -113,7 +113,7 @@ endif # LINUX if BUILD_PARTX -usrsbin_exec_PROGRAMS += partx addpart delpart +usrsbin_exec_PROGRAMS += partx addpart delpart resizepart dist_man_MANS += \ disk-utils/addpart.8 \ disk-utils/delpart.8 \
@@ -130,6 +130,11 @@ delpart_SOURCES = \ disk-utils/partx.h delpart_LDADD = $(LDADD) libcommon.la +resizepart_SOURCES = \ + disk-utils/resizepart.c \ + disk-utils/partx.h +resizepart_LDADD = $(LDADD) libcommon.la + partx_SOURCES = \ disk-utils/partx.c \ disk-utils/partx.h
disk-utils/partx.h +19 -0
@@ -41,4 +41,23 @@ static inline int partx_add_partition(int fd, int partno, return ioctl(fd, BLKPG, &a); } +static inline int partx_resize_partition (int fd,int partno, +long long start,long long size) +{ +struct blkpg_ioctl_arg a; +struct blkpg_partition p; + + p.pno = partno; + p.start = start <<9 ; + p.length = size <<9 ; + p.devname[0 ] =0 ; + p.volname[0 ] =0 ; + a.op =BLKPG_RESIZE_PARTITION ; + a.flags =0 ; + a.datalen =sizeof (p); + a.data = &p; + +return ioctl (fd,BLKPG , &a); +} +#endif /* UTIL_LINUX_PARTX_H */
disk-utils/resizepart.8 new file +38 -0
@@ -0,0 +1,38 @@ +.\" resizepart.8 -- +.\" Copyright 2012 Vivek Goyal <[email protected]> +.\" Copyright 2012 Red Hat, Inc. +.\" May be distributed under the GNU General Public License +.TH RESIZEPART 8 "February 2012" "util-linux" "System Administration" +.SH NAME +resizepart \- +simple wrapper around the "resize partition" ioctl +.SH SYNOPSIS +.B resizepart +.I device partition length +.SH DESCRIPTION +.B resizepart +is a program that informs the Linux kernel of new partition size. + +This command doesn't manipulate partitions on hard drive. + +.SH PARAMETERS +.TP +.I device +Specify the disk device. +.TP +.I partition +Specify the partition number. +.TP +.I length +Specify the length of the partition (in 512-byte sectors). + +.SH SEE ALSO +.BR addpart (8), +.BR delpart (8), +.BR fdisk (8), +.BR parted (8), +.BR partprobe (8), +.BR partx (8) +.SH AVAILABILITY +The resizepart command is part of the util-linux package and is available from +ftp://ftp.kernel.org/pub/linux/utils/util-linux/.
disk-utils/resizepart.c new file +98 -0
98 lines not on this page · raw message
Signature · 1 line
1.7.7.6
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 2 lines · On 07/09/2012 05:34 PM, [email protected] wrote:
Phillip, do let me know if I should put your signed-off-by also in the patch.
Sure, kernel side looks good. My original util-linux patches also added a -u update mode to kpartx, which I think is the more useful interface than the lower level resizepart command, but I suppose I can rebase it to apply on top of this patch.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQEcBAEBAgAGBQJP+13DAAoJEJrBOlT6nu75cQIIAJvm6ZFxpNNvgkXq0I6blvIj Q3s5YbzJYecouHPZdy06UXIdfucHKO7WAaMvpmPnDk+JgtltNljVpA50d21NN2lY k2j2oU9mFHGEKLDnnYobnr6cO2UShaZkrcMtC29S4LaAdgAgPNyD8aTTWS9w0frv +p2ko+HKvp3neRpOBwfnYXq/rTBLUmOn0k7XsG8QjnNb3aMnMyYp/crV9Kzeb4YX uCbnIkzN++oDhmnqsLDGt82/VGXZdnA1umISbV9vZw+Q7FfeaiJVMneFxKe5w/FZ wiCixoCtGhbqtz1hSsUR+rs2ZaDozL0iygSB15Z71aLPim0TLumtRTpfpu+JR3w= =Vtl+
-----END PGP SIGNATURE-----
Quoted 8 lines · Phillip Susi
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1Quoted 2 lines · On 07/09/2012 05:34 PM, [email protected] wrote:
Phillip, do let me know if I should put your signed-off-by also in the patch.
Sure, kernel side looks good. My original util-linux patches also added a -u update mode to kpartx, which I think is the more useful interface than the lower level resizepart command, but I suppose I can rebase it to apply on top of this patch.
I wrote user space part only to do testing. We definitely need better user space support. Especially a utility which changes partition details both in kernel as well as on disk. Asking user to call two different utilities is error prone and irritating.
Resending this patch again with your Signed-off-by.
Add a new operation code (BLKPG_RESIZE_PARTITION) to the BLKPG ioctl that allows altering the size of an existing partition, even if it is currently in use.
This patch converts hd_struct->nr_sects into sequence counter because One might extend a partition while IO is happening to it and update of nr_sects can be non-atomic on 32bit machines with 64bit sector_t. This can lead to issues like reading inconsistent size of a partition. Sequence counter have been used so that readers don't have to take bdev mutex lock as we call sector_in_part() very frequently.
Now all the access to hd_struct->nr_sects should happen using sequence counter read/update helper functions part_nr_sects_read/part_nr_sects_write. There is one exception though, set_capacity()/get_capacity(). I think theoritically race should exist there too but this patch does not modify set_capacity()/get_capacity() due to sheer number of call sites and I am afraid that change might break something. I have left that as a TODO item. We can handle it later if need be. This patch does not introduce any new races as such w.r.t set_capacity()/get_capacity().
--- block/genhd.c | 20 +++++++++++---- block/ioctl.c | 59 ++++++++++++++++++++++++++++++++++++++++++-- block/partition-generic.c | 4 ++- include/linux/blkpg.h | 1 + include/linux/genhd.h | 57 +++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 132 insertions(+), 9 deletions(-)
block/genhd.c +15 -5
@@ -154,7 +154,7 @@ struct hd_struct *disk_part_iter_next(struct disk_part_iter *piter) part =rcu_dereference (ptbl->part[piter->idx]);if (!part)continue ; -if (!part->nr_sects && +if (!part_nr_sects_read (part) && !(piter->flags &DISK_PITER_INCL_EMPTY ) && !(piter->flags &DISK_PITER_INCL_EMPTY_PART0 && piter->idx ==0 ))
@@ -191,7 +191,7 @@ EXPORT_SYMBOL_GPL(disk_part_iter_exit);static inline int sector_in_part (struct hd_struct *part,sector_t sector) {return part->start_sect <= sector && - sector < part->start_sect + part->nr_sects; + sector < part->start_sect +part_nr_sects_read (part); }/**
@@ -769,8 +769,8 @@ void __init printk_all_partitions(void)printk ("%s%s %10llu %s %s" , is_part0 ?"" :" " ,bdevt_str (part_devt (part), devt_buf), - (unsigned long long )part->nr_sects >>1 , -disk_name (disk, part->partno, name_buf), + (unsigned long long )part_nr_sects_read (part) >>1 + ,disk_name (disk, part->partno, name_buf), uuid_buf);if (is_part0) { if (disk->driverfs_dev != NULL &&
@@ -862,7 +862,7 @@ static int show_partition(struct seq_file *seqf, void *v)while ((part =disk_part_iter_next (&piter)))seq_printf (seqf,"%4d %7d %10llu %s\n" ,MAJOR (part_devt (part)),MINOR (part_devt (part)), - (unsigned long long )part->nr_sects >>1 , + (unsigned long long )part_nr_sects_read (part) >>1 ,disk_name (sgp, part->partno, buf));disk_part_iter_exit (&piter);
@@ -1268,6 +1268,16 @@ struct gendisk *alloc_disk_node(int minors, int node_id) } disk->part_tbl->part[0 ] = &disk->part0; +/* +* set_capacity() and get_capacity() currently don't use +* seqcounter to read/update the part0->nr_sects. Still init +* the counter as we can read the sectors in IO submission +* patch using seqence counters. +* +* TODO: Ideally set_capacity() and get_capacity() should be +* converted to make use of bd_mutex and sequence counters. +*/ +seqcount_init (&disk->part0.nr_sects_seq);hd_ref_init (&disk->part0); disk->minors = minors;
block/ioctl.c +56 -3
77 lines not on this page · raw message
block/partition-generic.c +3 -1
@@ -84,7 +84,7 @@ ssize_t part_size_show(struct device *dev, struct device_attribute *attr, char *buf) { struct hd_struct *p = dev_to_part(dev); -return sprintf (buf,"%llu\n" ,(unsigned long long )p->nr_sects); +return sprintf (buf,"%llu\n" ,(unsigned long long )part_nr_sects_read (p)); } static ssize_t part_ro_show(struct device *dev,
@@ -294,6 +294,8 @@ struct hd_struct *add_partition(struct gendisk *disk, int partno, err = -ENOMEM ; goto out_free; } + +seqcount_init (&p->nr_sects_seq); pdev =part_to_dev (p); p->start_sect = start;
include/linux/blkpg.h +1 -0
@@ -40,6 +40,7 @@ struct blkpg_ioctl_arg {/* The subfunctions (for the op field) */ #define BLKPG_ADD_PARTITION 1#define BLKPG_DEL_PARTITION 2 +#define BLKPG_RESIZE_PARTITION 3/* Sizes of name fields. Unused at present. */ #define BLKPG_DEVNAMELTH 64
include/linux/genhd.h +57 -0
70 lines not on this page · raw message
Signature · 1 line
1.7.7.6
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 7 lines · Vivek Goyal
(quoted diff) +2
-0+static inline sector_t part_nr_sects_read(struct hd_struct *part) +{ +#if BITS_PER_LONG==32 && defined(CONFIG_LBDAF) &&
defined(CONFIG_SMP)+sector_tnr_sects; + unsigned seq; + do { +
seq =read_seqcount_begin(&part->nr_sects_seq); +nr_sects=part->nr_sects; + } while (read_seqcount_retry(&part->nr_sects_seq,
seq)); + returnnr_sects; +#elif BITS_PER_LONG==32 &&defined(CONFIG_PREEMPT)
Shouldn't this be BITS_PER_LONG==32 && defined(CONFIG_LBDAF) && defined(CONFIG_PREEMPT)? No sense disabling preemption when the sector size is also 32 bits.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQEcBAEBAgAGBQJP/Dh/AAoJEJrBOlT6nu75ussIANfCKaObXMJ6JhCNLSeiHUqr FfBd6p2lJIFd73NSymyigZZ1/rPsy9TpMBlcMwpuFh2erxQ7q3rFnP0O52fEgm2+ 20c9+oeUGkzYx62fh0KtfrzBpzhiHOivKR/muAZcfNbb75iKTGrZSZUFrdqAqHci 4zCuu8T37BRo4G9TGdIXD1WT3sltZ7yOk4I7RBhAIDkbt82vVakZ6mlW9hyWmyvD /sMnXMmkNjwTDdhQj2ho9mn9SFcnDA+aAtJfPXjVAT0W9CKNDYbXw28ud+ARxo5T rkTjoewdxKffZsBmkkSiNCuLWwpkZng+nTchQjyZbmp/pl4UPlQOfcUb6YxpDX4= =1tUj
-----END PGP SIGNATURE-----
Quoted 4 lines · Phillip Susi
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1On 7/10/2012 9:57 AM, Vivek Goyal wrote:
Quoted 11 lines
Quoted 7 lines
(quoted diff) +2
-0+static inline sector_t part_nr_sects_read(struct hd_struct *part) +{ +#if BITS_PER_LONG==32 && defined(CONFIG_LBDAF) &&
defined(CONFIG_SMP)+sector_tnr_sects; + unsigned seq; + do { +
seq =read_seqcount_begin(&part->nr_sects_seq); +nr_sects=part->nr_sects; + } while (read_seqcount_retry(&part->nr_sects_seq,
seq)); + returnnr_sects; +#elif BITS_PER_LONG==32 &&defined(CONFIG_PREEMPT)Shouldn't this be BITS_PER_LONG==32 &&
defined(CONFIG_LBDAF)&&defined(CONFIG_PREEMPT)? No sense disabling preemption when the sector size is also 32 bits.
Yes. Good catch. We don't want to disable/enable preemption for 32bit UP kernels with sector size 32bit. I will modify the patch and repost soon.
BTW, what happened to all the new lines in the code above. Looks like you mailer chewed these up.
Thanks
Vivek
On Tue, Jul 10, 2012 at 10:20:01AM -0400, Vivek Goyal wrote:
[..]
Quoted 10 lines
Quoted 4 lines
Shouldn't this be BITS_PER_LONG==32 &&
defined(CONFIG_LBDAF)&&defined(CONFIG_PREEMPT)? No sense disabling preemption when the sector size is also 32 bits.Yes. Good catch. We don't want to disable/enable preemption for 32bit UP kernels with sector size 32bit. I will modify the patch and repost soon.
BTW, what happened to all the new lines in the code above. Looks like you mailer chewed these up.
Here is the V2 of the patch with CONFIG_LBDAF test added to UP, PREEMPT case.
Thanks
Vivek
block: add partition resize function to blkpg ioctl
Add a new operation code (BLKPG_RESIZE_PARTITION) to the BLKPG ioctl that allows altering the size of an existing partition, even if it is currently in use.
This patch converts hd_struct->nr_sects into sequence counter because One might extend a partition while IO is happening to it and update of nr_sects can be non-atomic on 32bit machines with 64bit sector_t. This can lead to issues like reading inconsistent size of a partition. Sequence counter have been used so that readers don't have to take bdev mutex lock as we call sector_in_part() very frequently.
Now all the access to hd_struct->nr_sects should happen using sequence counter read/update helper functions part_nr_sects_read/part_nr_sects_write. There is one exception though, set_capacity()/get_capacity(). I think theoritically race should exist there too but this patch does not modify set_capacity()/get_capacity() due to sheer number of call sites and I am afraid that change might break something. I have left that as a TODO item. We can handle it later if need be. This patch does not introduce any new races as such w.r.t set_capacity()/get_capacity().
v2: Add CONFIG_LBDAF test to UP preempt case as suggested by Phillip.
--- block/genhd.c | 20 +++++++++++---- block/ioctl.c | 59 +++++++++++++++++++++++++++++++++++++++++++--- block/partition-generic.c | 4 ++- include/linux/blkpg.h | 1 include/linux/genhd.h | 57 ++++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 132 insertions(+), 9 deletions(-)
block/genhd.c +15 -5
@@ -154,7 +154,7 @@ struct hd_struct *disk_part_iter_next(st part =rcu_dereference (ptbl->part[piter->idx]);if (!part)continue ; -if (!part->nr_sects && +if (!part_nr_sects_read (part) && !(piter->flags &DISK_PITER_INCL_EMPTY ) && !(piter->flags &DISK_PITER_INCL_EMPTY_PART0 && piter->idx ==0 ))
@@ -191,7 +191,7 @@ EXPORT_SYMBOL_GPL(disk_part_iter_exit);static inline int sector_in_part (struct hd_struct *part,sector_t sector) {return part->start_sect <= sector && - sector < part->start_sect + part->nr_sects; + sector < part->start_sect +part_nr_sects_read (part); }/**
@@ -769,8 +769,8 @@ void __init printk_all_partitions(void)printk ("%s%s %10llu %s %s" , is_part0 ?"" :" " ,bdevt_str (part_devt (part), devt_buf), - (unsigned long long )part->nr_sects >>1 , -disk_name (disk, part->partno, name_buf), + (unsigned long long )part_nr_sects_read (part) >>1 + ,disk_name (disk, part->partno, name_buf), uuid_buf);if (is_part0) { if (disk->driverfs_dev != NULL &&
@@ -862,7 +862,7 @@ static int show_partition(struct seq_filwhile ((part =disk_part_iter_next (&piter)))seq_printf (seqf,"%4d %7d %10llu %s\n" ,MAJOR (part_devt (part)),MINOR (part_devt (part)), - (unsigned long long )part->nr_sects >>1 , + (unsigned long long )part_nr_sects_read (part) >>1 ,disk_name (sgp, part->partno, buf));disk_part_iter_exit (&piter);
@@ -1268,6 +1268,16 @@ struct gendisk *alloc_disk_node(int mino } disk->part_tbl->part[0 ] = &disk->part0; +/* +* set_capacity() and get_capacity() currently don't use +* seqcounter to read/update the part0->nr_sects. Still init +* the counter as we can read the sectors in IO submission +* patch using seqence counters. +* +* TODO: Ideally set_capacity() and get_capacity() should be +* converted to make use of bd_mutex and sequence counters. +*/ +seqcount_init (&disk->part0.nr_sects_seq);hd_ref_init (&disk->part0); disk->minors = minors;
block/ioctl.c +56 -3
77 lines not on this page · raw message
block/partition-generic.c +3 -1
@@ -84,7 +84,7 @@ ssize_t part_size_show(struct device *de struct device_attribute *attr, char *buf) { struct hd_struct *p = dev_to_part(dev); -return sprintf (buf,"%llu\n" ,(unsigned long long )p->nr_sects); +return sprintf (buf,"%llu\n" ,(unsigned long long )part_nr_sects_read (p)); } static ssize_t part_ro_show(struct device *dev,
@@ -294,6 +294,8 @@ struct hd_struct *add_partition(struct g err = -ENOMEM ; goto out_free; } + +seqcount_init (&p->nr_sects_seq); pdev =part_to_dev (p); p->start_sect = start;
include/linux/blkpg.h +1 -0
@@ -40,6 +40,7 @@ struct blkpg_ioctl_arg {/* The subfunctions (for the op field) */ #define BLKPG_ADD_PARTITION 1#define BLKPG_DEL_PARTITION 2 +#define BLKPG_RESIZE_PARTITION 3/* Sizes of name fields. Unused at present. */ #define BLKPG_DEVNAMELTH 64
include/linux/genhd.h +57 -0
70 lines not on this page · raw message
Quoted 6 lines · On Mon, Jul 09, 2012 at 05:34:18PM -0400, [email protected] wrote:
Hi,
Few people have pinged me in rencent past about status of this patch, hence, this is V4 of patch which adds support for online resizing of a partition. This patch is based on previously posted patches by Phillip Susi.
Hi Jens,
Can you please consider partition resize patches for inclusion.
Thanks
Vivek
Quoted 59 lines
There are two patches. Out of which one is kernel patch and other one is util-linux patch to add support of a user space utility "resizepart" to allow resizing the partition.
This ioctl only resizes the partition size in kenrel and does not change the size on disk. A user needs to make sure that corresponding changes are made to disk data structures also using fdisk(or partx), if changes are to be retained across reboot.
Changes since V3
----------------
- Dobdput()in error path as per the Maxim's review comments.Changes since V2
----------------
- Do not ignore the "start" parameter in RESIZE ioctl.
- Change resizepart utility to parse sysfs to get to partition start.Changes since V1
----------------
Following are changes since the version Phillip posted.
- RESIZE ioctl ignores the partition "start" and does not expect user to specify one. Caller needs to just specify "device", "partition number" and "size" of new partition.- Got rid of part_nr_sects_write_begin/part_nr_sects_write_end functions and replaced these with single
part_nr_sects_write().- Some sequence counter related changes are simply lifted from
i_size_write().- Initialized
part->nr_sects_sequsingseqcount_init().Phillip, do let me know if I should put your signed-off-by also in the patch.
Any review feedback is welcome.
I did following test.
- Create a partition of 10MB on a disk using fdisk.
- Add this partition to a volume group
- Use fdisk to increase the partition size to 20MB. (First delete the partition and then create a new one of 20MB size).
- Use resizepart to extend partition size in kernel.resizepart /dev/sdc 1 40960- Do pvresize on partition so that physical volume can be incrased in size online.
pvresize/dev/sda1pvresize does recognize the new size. Also lsblk and
/proc/partitionsreport the new size of partition.Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Jens Axboe
maintainerQuoted 11 lines · Vivek Goyal
Quoted 6 lines · On Mon, Jul 09, 2012 at 05:34:18PM -0400, [email protected] wrote:
Hi,
Few people have pinged me in rencent past about status of this patch, hence, this is V4 of patch which adds support for online resizing of a partition. This patch is based on previously posted patches by Phillip Susi.
Hi Jens,
Can you please consider partition resize patches for inclusion.
Vivek, they are in and were in the pull request sent out earlier today!
Signature · 1 line
Jens Axboe
Quoted 9 lines · Jens Axboe
Quoted 8 lines · Vivek Goyal
Quoted 6 lines · On Mon, Jul 09, 2012 at 05:34:18PM -0400, [email protected] wrote:
Hi,
Few people have pinged me in rencent past about status of this patch, hence, this is V4 of patch which adds support for online resizing of a partition. This patch is based on previously posted patches by Phillip Susi.
Quoted 5 lines
Quoted 3 lines
Hi Jens,
Can you please consider partition resize patches for inclusion.
Vivek, they are in and were in the pull request sent out earlier today!
Great. I missed that. Thanks for including the patch.
Vivek
Karel Zak
maintainerRe: [patch 2/2] util-linux: resizepart: Utility to resize a partition
In reply to [email protected]Quoted 2 lines · On Mon, Jul 09, 2012 at 05:34:20PM -0400, [email protected] wrote:
A simple user space utility to resize an existing partition. It tries to read the start of partiton from sysfs.
Applied with some changes -- will be in the next release util-linux 2.22-rc2
Thanks!
Karel
Signature · 2 lines
Karel Zak <[email protected]> http://karelzak.blogspot.com