net/netfilter/nfnetlink_queue_core.c:407:23: warning: unused variable '

Hi Florian,

There are new compile warnings show up in

tree:   git://150.214.188.80/nf-next mmap-netlink
head:   c7e7243d0b69e2323dde057c28f1102d00e5a3c6
commit: b55f8ac10d3ef4c4379afabaa1f766de4d81a8a5 [65/68] nfqueue: extend spinlocked section for mmap'd sockets

All warnings:

net/netfilter/nfnetlink_queue_core.c: In function 'nfqnl_enqueue_packet':
net/netfilter/nfnetlink_queue_core.c:407:23: warning: unused variable 'size' [-Wunused-variable]

vim +407 net/netfilter/nfnetlink_queue_core.c
404 int err = -ENOBUFS;
405 int failopen = 0;
406 struct sk_buff *entskb = entry->skb;

408
409 /* rcu_read_lock()ed by nf_hook_slow() */
410 queue = instance_lookup(queuenum);

---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <[email protected]> Intel Corporation

Thanks for reporting.

Pablo, please consider squashing this in with the original patch before submitting for inclusion:

From: Florian Westphal <[email protected]>
Date: Fri, 13 Jul 2012 09:59:30 +0200
Subject: [PATCH] netfilter: nf_queue: kill unused variable

In function 'nfqnl_enqueue_packet':
warning: unused variable 'size' [-Wunused-variable]

caused by commit b55f8ac10d3ef4c4379afabaa1f766de4d81a8a5 (nfqueue: extend spinlocked section for mmap'd sockets)

---
 net/netfilter/nfnetlink_queue_core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

index 82bcced..09c85d0 100644
@@ -404,7 +404,7 @@ nfqnl_enqueue_packet(struct nf_queue_entry *entry, unsigned int queuenum)
 	int err = -ENOBUFS;
 	int failopen = 0;
 	struct sk_buff *entskb = entry->skb;
-	size_t data_len = 0, size;
+	size_t data_len = 0;
 
 	/* rcu_read_lock()ed by nf_hook_slow() */
 	queue = instance_lookup(queuenum);

1.7.3.4

Thanks Florian, I'll do.