Khem Raj : lib/oe/sstatesig.py: Exclude git-native from sstate checksum

oe-commits Martin Jansa 1 participant 1 message Jul 20, 2012 1 message not in the archive

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): 20120717095159.1190C10333@opal

Martin Jansa

author

2012-07-20 07:57 UTC #1 lore raw

Quoted 18 lines · On Tue, Jul 17, 2012 at 09:51:57AM +0000, [email protected] wrote:

Module: openembedded-core.git
Branch: master
Commit: 72cc3df204c4b838cc0358a7ac989adfdd5c1760
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=72cc3df204c4b838cc0358a7ac989adfdd5c1760
Author: Khem Raj <[email protected]>
Date:   Mon Jul  9 12:31:38 2012 -0700
lib/oe/sstatesig.py: Exclude git-native from sstate checksum
gcc exposed this issue where cross gcc recipes were not having same task checksums as libgcc or gcc-runtime the target recipes which use same shared workdir and it was triggering the unpack fetch and patch tasks to reexecute and hence the trouble
Now that we have more than 1 package to consider lets combine the check

Quoted 6 lines

Thanks RP for help and this is on the line of patch 793ce6cd9aa632e0f13789c8293770a86085d28d
Signed-off-by Khem Raj <[email protected]>
Signed-off-by Saul Wold <[email protected]>
Signed-off-by Richard Purdie <[email protected]>

I still see this behavior with latest oe-core

Complete cooker.log + do_compile error:
http://build.shr-project.org/tests/jama/gcc-parallel-unpack/

interesting part from cooker.log (stripped eglibc tasks between)

NOTE: package gcc-crosssdk-initial-4.7.1.0+git1+d07e24f4ab59f264d68d21838795349faab5dede-r7: task do_compile: Started
NOTE: Running task 608 of 5331 (ID: 1559, /OE/shr-core/openembedded-core/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.7.bb, do_rm_old_works)
NOTE: package gcc-crosssdk-intermediate-4.7.1.0+git1+d07e24f4ab59f264d68d21838795349faab5dede-r7: task do_rm_old_works: Started
NOTE: package gcc-crosssdk-intermediate-4.7.1.0+git1+d07e24f4ab59f264d68d21838795349faab5dede-r7: task do_rm_old_works: Succeeded
NOTE: Running task 610 of 5331 (ID: 1554, /OE/shr-core/openembedded-core/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.7.bb, do_unpack)
NOTE: package gcc-crosssdk-intermediate-4.7.1.0+git1+d07e24f4ab59f264d68d21838795349faab5dede-r7: task do_unpack: Started
ERROR: Function failed: do_compile (see /OE/shr-core/tmp-eglibc/work/i686-oesdk-linux/gcc-crosssdk-initial/gcc-crosssdk-initial-4.7.1.0+git1+d07e24f4ab59f264d68d21838795349faab5dede-r7/temp/log.do_compile.19681 for further information)
NOTE: package gcc-crosssdk-initial-4.7.1.0+git1+d07e24f4ab59f264d68d21838795349faab5dede-r7: task do_compile: Failed
ERROR: Task 4532 (/OE/shr-core/openembedded-core/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.7.bb, do_compile) failed with exit code '1'
NOTE: package gcc-crosssdk-intermediate-4.7.1.0+git1+d07e24f4ab59f264d68d21838795349faab5dede-r7: task do_unpack: Succeeded
NOTE: Running task 614 of 5331 (ID: 1555, /OE/shr-core/openembedded-core/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.7.bb, do_patch)
NOTE: package gcc-crosssdk-intermediate-4.7.1.0+git1+d07e24f4ab59f264d68d21838795349faab5dede-r7: task do_patch: Started
NOTE: Running task 627 of 5331 (ID: 529, /OE/shr-core/openembedded-core/meta/recipes-devtools/gcc/gcc-crosssdk_4.7.bb, do_rm_old_works)
NOTE: package gcc-crosssdk-intermediate-4.7.1.0+git1+d07e24f4ab59f264d68d21838795349faab5dede-r7: task do_patch: Succeeded

Maybe it's caused by rm_old_works.bbclass..

Cheers,

Quoted 29 lines

---

 meta/lib/oe/sstatesig.py |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

meta/lib/oe/sstatesig.py +2 -4

index 4cd1221..20d94b2 100644
@@ -17,10 +17,8 @@ def sstate_rundepfilter(siggen, fn, recipename, task, dep, depname, dataCache):
         return True
 
     # Quilt (patch application) changing isn't likely to affect anything
-    if depname == "quilt-native" and recipename != "quilt-native":
-        return False
-    # Subversion also isn't likely to affect anything
-    if depname == "subversion-native" and recipename != "subversion-native":
+    excludelist = ['quilt-native', 'subversion-native', 'git-native']
+    if depname in excludelist and recipename != depname:
         return False
 
     # Don't change native/cross/nativesdk recipe dependencies any further

_______________________________________________
Openembedded-commits mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-commits

Signature · 1 line

Martin 'JaMa' Jansa     jabber: [email protected]