Prefix IO_XX flags with XFS_IO_XX to avoid namespace colision.
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
Sorry resent because I fat fingered the oss address.
Quoted 59 lines · Rich Johnston
Quoted 50 lines · Alain Renaud
From: Alain Renaud <[email protected]>
To: [email protected]
Subject: [PATCH] PrefixIO_XXflags withXFS_IO_XXto avoid namespace colision.
User-Agent: Heirloom mailx 12.2 01/07/07This mod simply add a
XFS_prefix to IO_DIRECT,XFS_IO_DELALLOC,XFS_IO_UNWRITTENandXFS_IO_OVERWRITE. This to avoid namespace conflict with other modules.Signed-off-by Alain Renaud <[email protected]>fs/xfs/xfs_aops.c +0
-0fs/xfs/xfs_aops.h +0
-3@@ -24,17 +24,17 @@ extern mempool_t *xfs_ioend_pool;* Types of I/O for bmap clustering and I/O completion tracking. */ enum { -IO_DIRECT =0 ,/* special case for direct I/O ioends */ -IO_DELALLOC ,/* mapping covers delalloc region */ -IO_UNWRITTEN ,/* mapping covers allocated but uninitialized data */
fs/xfs/xfs_aops.h +4
-4- IO_OVERWRITE, /* mapping covers already allocated extent */ +XFS_IO_DIRECT =0 ,/* special case for direct I/O ioends */ +XFS_IO_DELALLOC ,/* covers delalloc region */ +XFS_IO_UNWRITTEN ,/* covers allocated but uninitialized data */ + XFS_IO_OVERWRITE, /* covers already allocated extent */ };#define XFS_IO_TYPES \ { 0, "" }, \ - { IO_DELALLOC, "delalloc" }, \ - { IO_UNWRITTEN, "unwritten" }, \ - { IO_OVERWRITE, "overwrite" } > + {
XFS_IO_DELALLOC, "delalloc" }, \fs/xfs/xfs_aops.h +2
-0+ { XFS_IO_UNWRITTEN, "unwritten" }, \ + { XFS_IO_OVERWRITE, "overwrite" }/* * xfs_ioend struct manages large extent writes for XFS. Quoted 5 lines
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfsAlain looks like this patch does what claims to do :), looks good to me.
Quoted 3 lines
Reviewed-by Rich Johnston <[email protected]>
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs