Skip to contentSkip to conversation

Prefix IO_XX flags with XFS_IO_XX to avoid namespace colision.

PATCH Rich Johnston 1 participant 1 message Jul 20, 2012 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

Sorry resent because I fat fingered the oss address.

Quoted 59 lines · Rich Johnston
Quoted 50 lines · Alain Renaud

From: Alain Renaud <[email protected]>
To: [email protected]
Subject: [PATCH] Prefix IO_XX flags with XFS_IO_XX to avoid namespace colision.
User-Agent: Heirloom mailx 12.2 01/07/07

This mod simply add a XFS_ prefix to IO_DIRECT,XFS_IO_DELALLOC,
XFS_IO_UNWRITTEN and XFS_IO_OVERWRITE. This to avoid namespace conflict with other modules.

fs/xfs/xfs_aops.c +0 -0
index ae31c31..7d3f6ab 100644
...
...
fs/xfs/xfs_aops.h +0 -3
index 84eafbc..c325abb 100644
@@ -24,17 +24,17 @@ extern mempool_t *xfs_ioend_pool;
   * Types of I/O for bmap clustering and I/O completion tracking.
   */
  enum {
-    IO_DIRECT = 0,    /* special case for direct I/O ioends */
-    IO_DELALLOC,    /* mapping covers delalloc region */
-    IO_UNWRITTEN,    /* mapping covers allocated but uninitialized

data */

fs/xfs/xfs_aops.h +4 -4
-    IO_OVERWRITE,    /* mapping covers already allocated extent */
+    XFS_IO_DIRECT = 0,    /* special case for direct I/O ioends */
+    XFS_IO_DELALLOC,    /* covers delalloc region */
+    XFS_IO_UNWRITTEN,    /* covers allocated but uninitialized data */
+    XFS_IO_OVERWRITE,    /* covers already allocated extent */
  };
 
  #define XFS_IO_TYPES \
      { 0,            "" }, \
-    { IO_DELALLOC,        "delalloc" }, \
-    { IO_UNWRITTEN,        "unwritten" }, \
-    { IO_OVERWRITE,        "overwrite" } > +    {

XFS_IO_DELALLOC, "delalloc" }, \

fs/xfs/xfs_aops.h +2 -0
+    { XFS_IO_UNWRITTEN,        "unwritten" }, \
+    { XFS_IO_OVERWRITE,        "overwrite" }
 
  /*
   * xfs_ioend struct manages large extent writes for XFS.
Quoted 5 lines

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Alain looks like this patch does what claims to do :), looks good to me.

Quoted 3 lines

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs