tty: save newly allocated buffer in tty_free_termios()

PATCH In review Dan Carpenter 2 participants 2 messages Jul 20, 2012

Subsystems (2)

Kernel janitors TTY layer and serial drivers

lore

Share & tools

lore

Dan Carpenter

author

2012-07-20 13:32 UTC #0 lore raw

PATCH 1/1 tty: save newly allocated buffer in tty_free_termios()

We're trying to save the termios state and we need to allocate a buffer to do it. Smatch complains that the buffer is leaked at the end of the function.

Signed-off-by Dan Carpenter <[email protected]>

drivers/tty/tty_io.c +1 -0

index be18d60..58a1bdd 100644
@@ -1450,6 +1450,7 @@ void tty_free_termios(struct tty_struct *tty)
 			pr_warn("tty: no memory to save termios state.\n");
 			return;
 		}
+		tty->driver->termios[idx] = tp;
 	}
 	*tp = tty->termios;
 }

Alan Cox

Acked-by on v1 1/1

2012-07-20 13:57 UTC #1 lore raw

Quoted 5 lines · On Fri, 20 Jul 2012 16:32:45 +0300 Dan Carpenter <[email protected]>…

We're trying to save the termios state and we need to allocate a buffer to do it. Smatch complains that the buffer is leaked at the end of the function.
Signed-off-by Dan Carpenter <[email protected]>

Acked-by Alan Cox <[email protected]>

(introduced in the recent patches so no need to go back into stable or anywhere like that)