Skip to contentSkip to conversation

lib/atomic64_test.c:131:2: warning: #warning Please implement atomic64_dec_i

PATCH Catalin Marinas 3 participants 3 messages Jul 23, 2012 – Jul 24, 2012 Kernel janitors

lore
Share & tools
lore

Catalin Marinas

author
#0 lore raw

Hi Fengguang,

Quoted 11 lines · Fengguang Wu

There are new compile warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git akpm
head:   37e2ad4953983527f7bdb6831bf478eedcc84082
commit: ffacc905e2135e8408d43adbe0b8e21484b2c8e7 [244/309] atomic64_test: simplify the #ifdef for atomic64_dec_if_positive() test
config: sparc-allmodconfig (attached as .config)

All warnings:

lib/atomic64_test.c: In function 'test_atomic64':
lib/atomic64_test.c:131:2: warning: #warning Please implement atomic64_dec_if_positive for your architecture and select the above Kconfig symbol [-Wcpp]

Is this a new warning in the sense that the string is different now? Or you never got it before on sparc64. I don't have a sparc toolchain at hand now but it looks to me like atomic64_test.c should have given the warning before this patch as atomic64_dec_if_positive() does not seem to be defined on sparc64.

Thanks.

Signature · 1 line
Catalin
#1 lore raw
Quoted 12 lines · On Mon, 23 Jul 2012 09:28:23 +0100 Catalin Marinas <[email protected]>…

Hi Fengguang,

Quoted 9 lines · Fengguang Wu

There are new compile warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git akpm
head:   37e2ad4953983527f7bdb6831bf478eedcc84082
commit: ffacc905e2135e8408d43adbe0b8e21484b2c8e7 [244/309] atomic64_test: simplify the #ifdef for atomic64_dec_if_positive() test
config: sparc-allmodconfig (attached as .config)

All warnings:

Quoted 9 lines
Quoted 2 lines

lib/atomic64_test.c: In function 'test_atomic64':
lib/atomic64_test.c:131:2: warning: #warning Please implement atomic64_dec_if_positive for your architecture and select the above Kconfig symbol [-Wcpp]

Is this a new warning in the sense that the string is different now? Or you never got it before on sparc64. I don't have a sparc toolchain at hand now but it looks to me like atomic64_test.c should have given the warning before this patch as atomic64_dec_if_positive() does not seem to be defined on sparc64.

Before:
lib/atomic64_test.c:132:2: warning: #warning Please implement atomic64_dec_if_positive for your architecture, and add it to the IF above

After:
lib/atomic64_test.c:131:2: warning: #warning Please implement atomic64_dec_if_positive for your architecture and select the above Kconfig symbol

#2 lore raw
In reply to Catalin Marinas
Quoted 25 lines · Andrew Morton
Quoted 12 lines · On Mon, 23 Jul 2012 09:28:23 +0100 Catalin Marinas <[email protected]>…

Hi Fengguang,

Quoted 9 lines · Fengguang Wu

There are new compile warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git akpm
head:   37e2ad4953983527f7bdb6831bf478eedcc84082
commit: ffacc905e2135e8408d43adbe0b8e21484b2c8e7 [244/309] atomic64_test: simplify the #ifdef for atomic64_dec_if_positive() test
config: sparc-allmodconfig (attached as .config)

All warnings:

Quoted 9 lines
Quoted 2 lines

lib/atomic64_test.c: In function 'test_atomic64':
lib/atomic64_test.c:131:2: warning: #warning Please implement atomic64_dec_if_positive for your architecture and select the above Kconfig symbol [-Wcpp]

Is this a new warning in the sense that the string is different now? Or you never got it before on sparc64. I don't have a sparc toolchain at hand now but it looks to me like atomic64_test.c should have given the warning before this patch as atomic64_dec_if_positive() does not seem to be defined on sparc64.

Quoted 5 lines

Before:
lib/atomic64_test.c:132:2: warning: #warning Please implement atomic64_dec_if_positive for your architecture, and add it to the IF above

After:
lib/atomic64_test.c:131:2: warning: #warning Please implement atomic64_dec_if_positive for your architecture and select the above Kconfig symbol

Exactly. That changed message text will be recognized by my dumb script as "new" warning and I cannot do much about this..

Fengguang