drivers/vhost/tcm_vhost.c:537:23-29: ERROR: allocation function on line 533 r

Hi Nicholas,

There are new coccinelle warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git for-linus
head:   fd682824bcdab8cbb3d078f9f59ba531e3e41484
commit: fd682824bcdab8cbb3d078f9f59ba531e3e41484 [1/1] tcm_vhost: Initial merge for vhost level target fabric driver

All coccinelle warnings:

drivers/vhost/tcm_vhost.c:537:23-29: ERROR: allocation function on line 533 returns NULL not ERR_PTR on failure

vim +537 drivers/vhost/tcm_vhost.c
534 if (!sg)
535 return -ENOMEM;
536 pr_debug("%s sg %p sgl_count %u is_err %ld\n", __func__,

538 sg_init_table(sg, sgl_count);
539
540 tv_cmd->tvc_sgl = sg;

---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <[email protected]> Intel Corporation

Generated by: null/eno.cocci

The various basic memory allocation functions don't return ERR_PTR

@@ -534,7 +534,7 @@ static int vhost_scsi_map_iov_to_sgl(str
 	if (!sg)
 		return -ENOMEM;
 	pr_debug("%s sg %p sgl_count %u is_err %ld\n", __func__,
-	       sg, sgl_count, IS_ERR(sg));
+	       sg, sgl_count, !sg);
 	sg_init_table(sg, sgl_count);
 
 	tv_cmd->tvc_sgl = sg;

I've included this fix into a post-merge series for tcm-vhost.

Also FYI, I changed this patch slightly to use %d as it was still generating a format spec warning..

Thanks WU!