Skip to contentSkip to conversation

drivers/net/can/janz-ican3.c:964:7: warning: unused variable 'ret'

PATCH In review Fengguang Wu 2 participants 2 messages Jul 28, 2012 – Jul 30, 2012 Kernel janitors

lore
Share & tools
lore

Fengguang Wu

author
#0 lore raw

PATCH 61/99 drivers/net/can/janz-ican3.c:964:7: warning: unused variable 'ret'

Hi Ira,

There are new compile warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost-net-next
head:   163049aefdc04323a2d17ec9f2862027b43b0502
commit: 83702f69272e4591a91a27eb58eade1bcd361dae [61/99] can: janz-ican3: fix support for CAN_RAW_RECV_OWN_MSGS

All error/warnings:

drivers/net/can/janz-ican3.c: In function 'ican3_handle_cevtind':
drivers/net/can/janz-ican3.c:964:7: warning: unused variable 'ret' [-Wunused-variable]

vim +964 drivers/net/can/janz-ican3.c
961 * skb allocation when it will just be freed immediately.
962 */
963 if (isrc = CEVTIND_BEI) {

Quoted 1 line

964 int ret;

965 dev_dbg(mod->dev, "bus error interrupt\n");
966
967 /* TX error */

---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <[email protected]> Intel Corporation

#1 lore raw
Quoted 10 lines · Fengguang Wu

There are new compile warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost-net-next
head:   163049aefdc04323a2d17ec9f2862027b43b0502
commit: 83702f69272e4591a91a27eb58eade1bcd361dae [61/99] can: janz-ican3: fix support for CAN_RAW_RECV_OWN_MSGS

All error/warnings:

drivers/net/can/janz-ican3.c: In function 'ican3_handle_cevtind':
drivers/net/can/janz-ican3.c:964:7: warning: unused variable 'ret' [-Wunused-variable]

Good catch, this warning occurs in the middle a series of patches, but not after the full series has been applied. Next time we'll check better for bisecability.

Marc

Signature · 4 lines
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |