Skip to contentSkip to conversation

fs/nfs/write.c:1592:5: error: redefinition of 'nfs_commit_inode'

PATCH In review Fengguang Wu 3 participants 17 messages Jul 31, 2012

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 46/51 fs/nfs/write.c:1592:5: error: redefinition of 'nfs_commit_inode'

Hi Bryan,

Kernel build failed on

tree:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git devel
head:   5c13c9e1c15ee2ca9ab2b953224001af53d9be09
commit: 1c606fb74c758beafd98cbad9a9133eadeec2371 [46/51] NFS: Convert v3 into a module
config: blackfin-BF533-EZKIT_defconfig (attached as .config)

All related error/warning messages:

fs/nfs/write.c:1592:5: error: redefinition of 'nfs_commit_inode'
In file included from fs/nfs/write.c:19:0:
include/linux/nfs_fs.h:547:1: note: previous definition of 'nfs_commit_inode' was here

vim +1592 fs/nfs/write.c
1589 return status;
1590 }
1591

Quoted 1 line

1592 int nfs_commit_inode(struct inode *inode, int how)

1593 {
1594 LIST_HEAD(head);
1595 struct nfs_commit_info cinfo;

---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <[email protected]> Intel Corporation

#
# Automatically generated file; DO NOT EDIT.
# Linux/blackfin 3.5.0-rc6 Kernel Configuration
#
CONFIG_SYMBOL_PREFIX="_"
# CONFIG_MMU is not set
# CONFIG_FPU is not set CONFIG_RWSEM_GENERIC_SPINLOCK=y
# CONFIG_RWSEM_XCHGADD_ALGORITHM is not set CONFIG_BLACKFIN=y
CONFIG_GENERIC_CSUM=y
CONFIG_GENERIC_BUG=y
CONFIG_ZONE_DMA=y
CONFIG_GENERIC_GPIO=y CONFIG_FORCE_MAX_ZONEORDER=14 CONFIG_GENERIC_CALIBRATE_DELAY=y CONFIG_LOCKDEP_SUPPORT=y CONFIG_STACKTRACE_SUPPORT=y CONFIG_TRACE_IRQFLAGS_SUPPORT=y CONFIG_DEFCONFIG_LIST="/lib/modules/$UNAME_RELEASE/.config" CONFIG_HAVE_IRQ_WORK=y

#
# General setup
#
CONFIG_EXPERIMENTAL=y
CONFIG_BROKEN_ON_SMP=y
CONFIG_INIT_ENV_ARG_LIMIT=32
CONFIG_CROSS_COMPILE=""
CONFIG_LOCALVERSION=""
CONFIG_LOCALVERSION_AUTO=y
CONFIG_HAVE_KERNEL_GZIP=y
CONFIG_HAVE_KERNEL_BZIP2=y
CONFIG_HAVE_KERNEL_LZMA=y
CONFIG_HAVE_KERNEL_LZO=y
CONFIG_KERNEL_GZIP=y
# CONFIG_KERNEL_BZIP2 is not set
# CONFIG_KERNEL_LZMA is not set
# CONFIG_KERNEL_LZO is not set
CONFIG_DEFAULT_HOSTNAME="(none)"
CONFIG_SYSVIPC=y
CONFIG_SYSVIPC_SYSCTL=y
# CONFIG_POSIX_MQUEUE is not set
# CONFIG_BSD_PROCESS_ACCT is not set
# CONFIG_FHANDLE is not set
# CONFIG_TASKSTATS is not set
# CONFIG_AUDIT is not set
CONFIG_HAVE_GENERIC_HARDIRQS=y

#
# IRQ subsystem
#
CONFIG_GENERIC_HARDIRQS=y
CONFIG_GENERIC_IRQ_PROBE=y
CONFIG_GENERIC_CLOCKEVENTS=y
CONFIG_GENERIC_CLOCKEVENTS_BUILD=y

#
# Timers subsystem
#
CONFIG_TICK_ONESHOT=y
# CONFIG_NO_HZ is not set
CONFIG_HIGH_RES_TIMERS=y

#
# RCU Subsystem
#
CONFIG_TINY_RCU=y
# CONFIG_PREEMPT_RCU is not set
# CONFIG_TREE_RCU_TRACE is not set
CONFIG_IKCONFIG=y
CONFIG_IKCONFIG_PROC=y
CONFIG_LOG_BUF_SHIFT=14
# CONFIG_CHECKPOINT_RESTORE is not set
# CONFIG_NAMESPACES is not set
# CONFIG_SCHED_AUTOGROUP is not set
# CONFIG_SYSFS_DEPRECATED is not set
# CONFIG_RELAY is not set
CONFIG_BLK_DEV_INITRD=y
CONFIG_INITRAMFS_SOURCE=""
CONFIG_RD_GZIP=y
# CONFIG_RD_BZIP2 is not set
# CONFIG_RD_LZMA is not set
# CONFIG_RD_XZ is not set
# CONFIG_RD_LZO is not set
# CONFIG_CC_OPTIMIZE_FOR_SIZE is not set
CONFIG_SYSCTL=y
CONFIG_ANON_INODES=y
CONFIG_EXPERT=y
CONFIG_UID16=y
# CONFIG_SYSCTL_SYSCALL is not set
CONFIG_KALLSYMS=y
# CONFIG_KALLSYMS_ALL is not set
CONFIG_HOTPLUG=y
CONFIG_PRINTK=y
CONFIG_BUG=y
# CONFIG_ELF_CORE is not set
CONFIG_BASE_FULL=y
# CONFIG_FUTEX is not set
CONFIG_EPOLL=y
# CONFIG_SIGNALFD is not set
# CONFIG_TIMERFD is not set
# CONFIG_EVENTFD is not set
# CONFIG_AIO is not set
# CONFIG_EMBEDDED is not set
CONFIG_HAVE_PERF_EVENTS=y

#
# Kernel Performance Events And Counters
#
# CONFIG_PERF_EVENTS is not set
CONFIG_VM_EVENT_COUNTERS=y
CONFIG_COMPAT_BRK=y
CONFIG_SLAB=y
# CONFIG_SLUB is not set
# CONFIG_SLOB is not set
CONFIG_MMAP_ALLOW_UNINITIALIZED=y
# CONFIG_PROFILING is not set
CONFIG_HAVE_OPROFILE=y
CONFIG_HAVE_ARCH_TRACEHOOK=y
CONFIG_GENERIC_SMP_IDLE_THREAD=y

#
# GCOV-based kernel profiling
#
# CONFIG_GCOV_KERNEL is not set
# CONFIG_HAVE_GENERIC_DMA_COHERENT is not set
CONFIG_SLABINFO=y
CONFIG_BASE_SMALL=0
CONFIG_MODULES=y
# CONFIG_MODULE_FORCE_LOAD is not set
CONFIG_MODULE_UNLOAD=y
# CONFIG_MODULE_FORCE_UNLOAD is not set
# CONFIG_MODVERSIONS is not set
# CONFIG_MODULE_SRCVERSION_ALL is not set
CONFIG_BLOCK=y
# CONFIG_LBDAF is not set
# CONFIG_BLK_DEV_BSG is not set
# CONFIG_BLK_DEV_BSGLIB is not set
# CONFIG_BLK_DEV_INTEGRITY is not set

#
# Partition Types
#
# CONFIG_PARTITION_ADVANCED is not set
CONFIG_MSDOS_PARTITION=y

#
# IO Schedulers
#
CONFIG_IOSCHED_NOOP=y
# CONFIG_IOSCHED_DEADLINE is not set
# CONFIG_IOSCHED_CFQ is not set CONFIG_DEFAULT_NOOP=y CONFIG_DEFAULT_IOSCHED="noop"
# CONFIG_INLINE_SPIN_TRYLOCK is not set
# CONFIG_INLINE_SPIN_TRYLOCK_BH is not set # CONFIG_INLINE_SPIN_LOCK is not set
# CONFIG_INLINE_SPIN_LOCK_BH is not set
# CONFIG_INLINE_SPIN_LOCK_IRQ is not set
# CONFIG_INLINE_SPIN_LOCK_IRQSAVE is not set # CONFIG_INLINE_SPIN_UNLOCK_BH is not set CONFIG_INLINE_SPIN_UNLOCK_IRQ=y
# CONFIG_INLINE_SPIN_UNLOCK_IRQRESTORE is not set # CONFIG_INLINE_READ_TRYLOCK is not set
# CONFIG_INLINE_READ_LOCK is not set
# CONFIG_INLINE_READ_LOCK_BH is not set
# CONFIG_INLINE_READ_LOCK_IRQ is not set
# CONFIG_INLINE_READ_LOCK_IRQSAVE is not set CONFIG_INLINE_READ_UNLOCK=y
# CONFIG_INLINE_READ_UNLOCK_BH is not set CONFIG_INLINE_READ_UNLOCK_IRQ=y
# CONFIG_INLINE_READ_UNLOCK_IRQRESTORE is not set # CONFIG_INLINE_WRITE_TRYLOCK is not set
# CONFIG_INLINE_WRITE_LOCK is not set
# CONFIG_INLINE_WRITE_LOCK_BH is not set
# CONFIG_INLINE_WRITE_LOCK_IRQ is not set # CONFIG_INLINE_WRITE_LOCK_IRQSAVE is not set CONFIG_INLINE_WRITE_UNLOCK=y
# CONFIG_INLINE_WRITE_UNLOCK_BH is not set CONFIG_INLINE_WRITE_UNLOCK_IRQ=y
# CONFIG_INLINE_WRITE_UNLOCK_IRQRESTORE is not set # CONFIG_MUTEX_SPIN_ON_OWNER is not set
# CONFIG_PREEMPT_NONE is not set CONFIG_PREEMPT_VOLUNTARY=y
# CONFIG_PREEMPT is not set CONFIG_FREEZER=y

#
# Blackfin Processor Options
#

#
# Processor and Board Settings
#
# CONFIG_BF512 is not set
# CONFIG_BF514 is not set
# CONFIG_BF516 is not set
# CONFIG_BF518 is not set
# CONFIG_BF522 is not set
# CONFIG_BF523 is not set
# CONFIG_BF524 is not set
# CONFIG_BF525 is not set
# CONFIG_BF526 is not set
# CONFIG_BF527 is not set
# CONFIG_BF531 is not set
# CONFIG_BF532 is not set
CONFIG_BF533=y
# CONFIG_BF534 is not set
# CONFIG_BF536 is not set
# CONFIG_BF537 is not set
# CONFIG_BF538 is not set
# CONFIG_BF539 is not set
# CONFIG_BF542_std is not set
# CONFIG_BF542M is not set
# CONFIG_BF544_std is not set
# CONFIG_BF544M is not set
# CONFIG_BF547_std is not set
# CONFIG_BF547M is not set
# CONFIG_BF548_std is not set
# CONFIG_BF548M is not set
# CONFIG_BF549_std is not set
# CONFIG_BF549M is not set
# CONFIG_BF561 is not set
# CONFIG_BF609 is not set
CONFIG_BF_REV_MIN=3
CONFIG_BF_REV_MAX=6
CONFIG_BF_REV_0_3=y
# CONFIG_BF_REV_0_4 is not set
# CONFIG_BF_REV_0_5 is not set
# CONFIG_BF_REV_0_6 is not set
# CONFIG_BF_REV_ANY is not set
# CONFIG_BF_REV_NONE is not set
CONFIG_BF53x=y
CONFIG_MEM_MT48LC16M16A2TG_75=y
CONFIG_BFIN533_EZKIT=y
# CONFIG_BFIN533_STAMP is not set
# CONFIG_BLACKSTAMP is not set
# CONFIG_BFIN533_BLUETECHNIX_CM is not set

#
# BF533/2/1 Specific Configuration
#

#
# Interrupt Priority Assignment
#

#
# Priority
#
CONFIG_UART_ERROR=7
CONFIG_SPORT0_ERROR=7
CONFIG_SPI_ERROR=7
CONFIG_SPORT1_ERROR=7
CONFIG_PPI_ERROR=7
CONFIG_DMA_ERROR=7
CONFIG_PLLWAKE_ERROR=7
CONFIG_RTC_ERROR=8
CONFIG_DMA0_PPI=8
CONFIG_DMA1_SPORT0RX=9
CONFIG_DMA2_SPORT0TX=9
CONFIG_DMA3_SPORT1RX=9
CONFIG_DMA4_SPORT1TX=9
CONFIG_DMA5_SPI=10
CONFIG_DMA6_UARTRX=10
CONFIG_DMA7_UARTTX=10
CONFIG_TIMER0=11
CONFIG_TIMER1=11
CONFIG_TIMER2=11
CONFIG_PFA=12
CONFIG_PFB=12
CONFIG_MEMDMA0=13
CONFIG_MEMDMA1=13
CONFIG_WDTIMER=13

#
# Board customizations
#
# CONFIG_CMDLINE_BOOL is not set
CONFIG_BOOT_LOAD=0x1000
CONFIG_PHY_RAM_BASE_ADDRESS=0x0

#
# Clock/PLL Setup
#
CONFIG_CLKIN_HZ=27000000
# CONFIG_BFIN_KERNEL_CLOCK is not set
CONFIG_MAX_VCO_HZ=750000000
CONFIG_MIN_VCO_HZ=50000000
CONFIG_MAX_SCLK_HZ=133333333
CONFIG_MIN_SCLK_HZ=27000000

#
# Kernel Timer/Scheduler
#
# CONFIG_HZ_100 is not set
CONFIG_HZ_250=y
# CONFIG_HZ_300 is not set
# CONFIG_HZ_1000 is not set
CONFIG_HZ=250
CONFIG_SCHED_HRTICK=y
CONFIG_SET_GENERIC_CLOCKEVENTS=y

#
# Clock event device
#
# CONFIG_TICKSOURCE_GPTMR0 is not set
CONFIG_TICKSOURCE_CORETMR=y

#
# Clock souce
#
CONFIG_CYCLES_CLOCKSOURCE=y
# CONFIG_GPTMR0_CLOCKSOURCE is not set

#
# Misc
#
CONFIG_BFIN_SCRATCH_REG_RETN=y
# CONFIG_BFIN_SCRATCH_REG_RETE is not set
# CONFIG_BFIN_SCRATCH_REG_CYCLES is not set

#
# Blackfin Kernel Optimizations
#

#
# Memory Optimizations
#
CONFIG_I_ENTRY_L1=y
CONFIG_EXCPT_IRQ_SYSC_L1=y
CONFIG_DO_IRQ_L1=y
CONFIG_CORE_TIMER_IRQ_L1=y
CONFIG_IDLE_L1=y
CONFIG_SCHEDULE_L1=y
CONFIG_ARITHMETIC_OPS_L1=y
CONFIG_ACCESS_OK_L1=y
CONFIG_MEMSET_L1=y
CONFIG_MEMCPY_L1=y
CONFIG_STRCMP_L1=y
CONFIG_STRNCMP_L1=y
CONFIG_STRCPY_L1=y
CONFIG_STRNCPY_L1=y
CONFIG_SYS_BFIN_SPINLOCK_L1=y
# CONFIG_IP_CHECKSUM_L1 is not set
# CONFIG_SYSCALL_TAB_L1 is not set
# CONFIG_CPLB_SWITCH_TAB_L1 is not set
CONFIG_ICACHE_FLUSH_L1=y
CONFIG_DCACHE_FLUSH_L1=y
CONFIG_APP_STACK_L1=y

#
# Speed Optimizations
#
CONFIG_BFIN_INS_LOWOVERHEAD=y
CONFIG_RAMKERNEL=y
# CONFIG_ROMKERNEL is not set
CONFIG_SELECT_MEMORY_MODEL=y
CONFIG_FLATMEM_MANUAL=y
CONFIG_FLATMEM=y
CONFIG_FLAT_NODE_MEM_MAP=y
CONFIG_PAGEFLAGS_EXTENDED=y
CONFIG_SPLIT_PTLOCK_CPUS=4
# CONFIG_PHYS_ADDR_T_64BIT is not set
CONFIG_ZONE_DMA_FLAG=1
CONFIG_VIRT_TO_BUS=y
CONFIG_NOMMU_INITIAL_TRIM_EXCESS=0
CONFIG_NEED_PER_CPU_KM=y
# CONFIG_CLEANCACHE is not set
CONFIG_BFIN_GPTIMERS=m
# CONFIG_HAVE_PWM is not set
# CONFIG_DMA_UNCACHED_4M is not set
# CONFIG_DMA_UNCACHED_2M is not set
CONFIG_DMA_UNCACHED_1M=y
# CONFIG_DMA_UNCACHED_512K is not set
# CONFIG_DMA_UNCACHED_256K is not set
# CONFIG_DMA_UNCACHED_128K is not set
# CONFIG_DMA_UNCACHED_NONE is not set

#
# Cache Support
#
CONFIG_BFIN_ICACHE=y
CONFIG_BFIN_EXTMEM_ICACHEABLE=y
CONFIG_BFIN_DCACHE=y
# CONFIG_BFIN_DCACHE_BANKA is not set
CONFIG_BFIN_EXTMEM_DCACHEABLE=y
CONFIG_BFIN_EXTMEM_WRITEBACK=y
# CONFIG_BFIN_EXTMEM_WRITETHROUGH is not set

#
# Memory Protection Unit
#
# CONFIG_MPU is not set

#
# Asynchronous Memory Configuration
#

#
# EBIU_AMGCTL Global Control
#
CONFIG_C_AMCKEN=y
CONFIG_C_CDPRIO=y
# CONFIG_C_AMBEN is not set
# CONFIG_C_AMBEN_B0 is not set
# CONFIG_C_AMBEN_B0_B1 is not set
# CONFIG_C_AMBEN_B0_B1_B2 is not set
CONFIG_C_AMBEN_ALL=y

#
# EBIU_AMBCTL Control
#
CONFIG_BANK_0=0x7BB0
CONFIG_BANK_1=0x7BB0
CONFIG_BANK_2=0x7BB0
CONFIG_BANK_3=0xAAC2

#
# Bus options (PCI, PCMCIA, EISA, MCA, ISA)
#
# CONFIG_ARCH_SUPPORTS_MSI is not set
# CONFIG_PCCARD is not set

#
# Executable file formats
#
CONFIG_BINFMT_ELF_FDPIC=y
CONFIG_BINFMT_FLAT=y
CONFIG_BINFMT_ZFLAT=y
# CONFIG_BINFMT_SHARED_FLAT is not set
# CONFIG_HAVE_AOUT is not set
# CONFIG_BINFMT_MISC is not set

#
# Power management options
#
CONFIG_SUSPEND=y
CONFIG_SUSPEND_FREEZER=y
CONFIG_PM_SLEEP=y
# CONFIG_PM_AUTOSLEEP is not set
# CONFIG_PM_WAKELOCKS is not set
# CONFIG_PM_RUNTIME is not set
CONFIG_PM=y
# CONFIG_PM_DEBUG is not set
CONFIG_ARCH_SUSPEND_POSSIBLE=y
CONFIG_PM_BFIN_SLEEP_DEEPER=y
# CONFIG_PM_BFIN_SLEEP is not set

#
# Possible Suspend Mem / Hibernate Wake-Up Sources #

#
# CPU Frequency scaling
#

#
# CPU Frequency scaling
#
# CONFIG_CPU_FREQ is not set
CONFIG_NET=y

#
# Networking options
#
CONFIG_PACKET=y
CONFIG_UNIX=y
# CONFIG_UNIX_DIAG is not set
# CONFIG_XFRM_USER is not set
# CONFIG_NET_KEY is not set
CONFIG_INET=y
# CONFIG_IP_MULTICAST is not set
# CONFIG_IP_ADVANCED_ROUTER is not set
CONFIG_IP_PNP=y
# CONFIG_IP_PNP_DHCP is not set
# CONFIG_IP_PNP_BOOTP is not set
# CONFIG_IP_PNP_RARP is not set
# CONFIG_NET_IPIP is not set
# CONFIG_NET_IPGRE_DEMUX is not set
# CONFIG_ARPD is not set
# CONFIG_SYN_COOKIES is not set
# CONFIG_INET_AH is not set
# CONFIG_INET_ESP is not set
# CONFIG_INET_IPCOMP is not set
# CONFIG_INET_XFRM_TUNNEL is not set
# CONFIG_INET_TUNNEL is not set
# CONFIG_INET_XFRM_MODE_TRANSPORT is not set
# CONFIG_INET_XFRM_MODE_TUNNEL is not set
# CONFIG_INET_XFRM_MODE_BEET is not set
# CONFIG_INET_LRO is not set
# CONFIG_INET_DIAG is not set
# CONFIG_TCP_CONG_ADVANCED is not set
CONFIG_TCP_CONG_CUBIC=y
CONFIG_DEFAULT_TCP_CONG="cubic"
# CONFIG_TCP_MD5SIG is not set
# CONFIG_IPV6 is not set
# CONFIG_NETWORK_SECMARK is not set
# CONFIG_NETWORK_PHY_TIMESTAMPING is not set
# CONFIG_NETFILTER is not set
# CONFIG_IP_DCCP is not set
# CONFIG_IP_SCTP is not set
# CONFIG_RDS is not set
# CONFIG_TIPC is not set
# CONFIG_ATM is not set
# CONFIG_L2TP is not set
# CONFIG_BRIDGE is not set
# CONFIG_NET_DSA is not set
# CONFIG_VLAN_8021Q is not set
# CONFIG_DECNET is not set
# CONFIG_LLC2 is not set
# CONFIG_IPX is not set
# CONFIG_ATALK is not set
# CONFIG_X25 is not set
# CONFIG_LAPB is not set
# CONFIG_WAN_ROUTER is not set
# CONFIG_PHONET is not set
# CONFIG_IEEE802154 is not set
# CONFIG_NET_SCHED is not set
# CONFIG_DCB is not set
# CONFIG_BATMAN_ADV is not set
# CONFIG_OPENVSWITCH is not set
CONFIG_BQL=y

#
# Network testing
#
# CONFIG_NET_PKTGEN is not set
# CONFIG_HAMRADIO is not set
# CONFIG_CAN is not set
CONFIG_IRDA=m

#
# IrDA protocols
#
CONFIG_IRLAN=m
CONFIG_IRCOMM=m
# CONFIG_IRDA_ULTRA is not set

#
# IrDA options
#
CONFIG_IRDA_CACHE_LAST_LSAP=y
# CONFIG_IRDA_FAST_RR is not set
# CONFIG_IRDA_DEBUG is not set

#
# Infrared-port device drivers
#

#
# SIR device drivers
#
CONFIG_IRTTY_SIR=m
# CONFIG_BFIN_SIR is not set

#
# Dongle support
#
# CONFIG_DONGLE is not set

#
# FIR device drivers
#
# CONFIG_BT is not set
# CONFIG_AF_RXRPC is not set
# CONFIG_WIRELESS is not set
# CONFIG_WIMAX is not set
# CONFIG_RFKILL is not set
# CONFIG_NET_9P is not set
# CONFIG_CAIF is not set
# CONFIG_CEPH_LIB is not set
# CONFIG_NFC is not set

#
# Device Drivers
#

#
# Generic Driver Options
#
CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
# CONFIG_DEVTMPFS is not set
CONFIG_STANDALONE=y
CONFIG_PREVENT_FIRMWARE_BUILD=y
# CONFIG_FW_LOADER is not set
# CONFIG_DEBUG_DRIVER is not set
# CONFIG_DEBUG_DEVRES is not set
# CONFIG_SYS_HYPERVISOR is not set
# CONFIG_GENERIC_CPU_DEVICES is not set
# CONFIG_DMA_SHARED_BUFFER is not set
# CONFIG_CONNECTOR is not set
CONFIG_MTD=y
# CONFIG_MTD_TESTS is not set
# CONFIG_MTD_REDBOOT_PARTS is not set
# CONFIG_MTD_CMDLINE_PARTS is not set
# CONFIG_MTD_AR7_PARTS is not set

#
# User Modules And Translation Layers
#
CONFIG_MTD_CHAR=m
CONFIG_MTD_BLKDEVS=y
CONFIG_MTD_BLOCK=y
# CONFIG_FTL is not set
# CONFIG_NFTL is not set
# CONFIG_INFTL is not set
# CONFIG_RFD_FTL is not set
# CONFIG_SSFDC is not set
# CONFIG_SM_FTL is not set
# CONFIG_MTD_OOPS is not set

#
# RAM/ROM/Flash chip drivers
#
# CONFIG_MTD_CFI is not set
CONFIG_MTD_JEDECPROBE=m
CONFIG_MTD_GEN_PROBE=m
# CONFIG_MTD_CFI_ADV_OPTIONS is not set
CONFIG_MTD_MAP_BANK_WIDTH_1=y
CONFIG_MTD_MAP_BANK_WIDTH_2=y
CONFIG_MTD_MAP_BANK_WIDTH_4=y
# CONFIG_MTD_MAP_BANK_WIDTH_8 is not set
# CONFIG_MTD_MAP_BANK_WIDTH_16 is not set
# CONFIG_MTD_MAP_BANK_WIDTH_32 is not set
CONFIG_MTD_CFI_I1=y
CONFIG_MTD_CFI_I2=y
# CONFIG_MTD_CFI_I4 is not set
# CONFIG_MTD_CFI_I8 is not set
# CONFIG_MTD_CFI_INTELEXT is not set
# CONFIG_MTD_CFI_AMDSTD is not set
# CONFIG_MTD_CFI_STAA is not set
CONFIG_MTD_RAM=y
CONFIG_MTD_ROM=m
# CONFIG_MTD_ABSENT is not set

#
# Mapping drivers for chip access
#
CONFIG_MTD_COMPLEX_MAPPINGS=y
# CONFIG_MTD_PHYSMAP is not set
# CONFIG_MTD_GPIO_ADDR is not set
# CONFIG_MTD_UCLINUX is not set
# CONFIG_MTD_PLATRAM is not set
# CONFIG_MTD_LATCH_ADDR is not set

#
# Self-contained MTD device drivers
#
# CONFIG_MTD_DATAFLASH is not set
# CONFIG_MTD_M25P80 is not set
# CONFIG_MTD_SST25L is not set
# CONFIG_MTD_SLRAM is not set
# CONFIG_MTD_PHRAM is not set
# CONFIG_MTD_MTDRAM is not set
# CONFIG_MTD_BLOCK2MTD is not set

#
# Disk-On-Chip Device Drivers
#
# CONFIG_MTD_DOCG3 is not set
# CONFIG_MTD_NAND is not set
# CONFIG_MTD_ONENAND is not set

#
# LPDDR flash memory drivers
#
# CONFIG_MTD_LPDDR is not set
# CONFIG_MTD_UBI is not set
# CONFIG_PARPORT is not set
CONFIG_BLK_DEV=y
# CONFIG_BLK_DEV_COW_COMMON is not set
# CONFIG_BLK_DEV_LOOP is not set

#
# DRBD disabled because PROC_FS, INET or CONNECTOR not selected #
# CONFIG_BLK_DEV_NBD is not set
CONFIG_BLK_DEV_RAM=y
CONFIG_BLK_DEV_RAM_COUNT=16 CONFIG_BLK_DEV_RAM_SIZE=4096
# CONFIG_BLK_DEV_XIP is not set
# CONFIG_CDROM_PKTCDVD is not set
# CONFIG_ATA_OVER_ETH is not set
# CONFIG_BLK_DEV_HD is not set
# CONFIG_BLK_DEV_RBD is not set

#
# Misc devices
#
# CONFIG_SENSORS_LIS3LV02D is not set
# CONFIG_AD525X_DPOT is not set
# CONFIG_ENCLOSURE_SERVICES is not set
# CONFIG_TI_DAC7512 is not set
# CONFIG_BMP085_SPI is not set
# CONFIG_C2PORT is not set

#
# EEPROM support
#
# CONFIG_EEPROM_AT25 is not set
# CONFIG_EEPROM_93CX6 is not set
# CONFIG_EEPROM_93XX46 is not set

#
# Texas Instruments shared transport line discipline #
# CONFIG_TI_ST is not set
# CONFIG_SENSORS_LIS3_SPI is not set

#
# Altera FPGA firmware download module
#
CONFIG_HAVE_IDE=y
# CONFIG_IDE is not set

#
# SCSI device support
#
CONFIG_SCSI_MOD=y
# CONFIG_RAID_ATTRS is not set
# CONFIG_SCSI is not set
# CONFIG_SCSI_DMA is not set
# CONFIG_SCSI_NETLINK is not set
# CONFIG_ATA is not set
# CONFIG_MD is not set
CONFIG_NETDEVICES=y
CONFIG_NET_CORE=y
# CONFIG_BONDING is not set
# CONFIG_DUMMY is not set
# CONFIG_EQUALIZER is not set
CONFIG_MII=y
# CONFIG_NET_TEAM is not set
# CONFIG_MACVLAN is not set
# CONFIG_NETCONSOLE is not set
# CONFIG_NETPOLL is not set
# CONFIG_NET_POLL_CONTROLLER is not set
# CONFIG_TUN is not set
# CONFIG_VETH is not set

#
# CAIF transport drivers
#
CONFIG_ETHERNET=y
# CONFIG_NET_VENDOR_BROADCOM is not set
# CONFIG_NET_CALXEDA_XGMAC is not set
# CONFIG_NET_VENDOR_CHELSIO is not set
# CONFIG_DM9000 is not set
# CONFIG_DNET is not set
# CONFIG_NET_VENDOR_INTEL is not set
# CONFIG_NET_VENDOR_MARVELL is not set
# CONFIG_NET_VENDOR_MICREL is not set
# CONFIG_NET_VENDOR_MICROCHIP is not set
# CONFIG_NET_VENDOR_NATSEMI is not set
# CONFIG_ETHOC is not set
# CONFIG_NET_VENDOR_SEEQ is not set
CONFIG_NET_VENDOR_SMSC=y
CONFIG_SMC91X=y
# CONFIG_SMSC911X is not set
# CONFIG_NET_VENDOR_STMICRO is not set
CONFIG_NET_VENDOR_WIZNET=y
# CONFIG_WIZNET_W5100 is not set
# CONFIG_WIZNET_W5300 is not set
# CONFIG_PHYLIB is not set
# CONFIG_MICREL_KS8995MA is not set
# CONFIG_PPP is not set
# CONFIG_SLIP is not set
# CONFIG_WLAN is not set

#
# Enable WiMAX (Networking options) to see the WiMAX drivers #
# CONFIG_WAN is not set
# CONFIG_ISDN is not set

#
# Input device support
#
CONFIG_INPUT=m
# CONFIG_INPUT_FF_MEMLESS is not set
# CONFIG_INPUT_POLLDEV is not set
# CONFIG_INPUT_SPARSEKMAP is not set
# CONFIG_INPUT_MATRIXKMAP is not set

#
# Userland interfaces
#
# CONFIG_INPUT_MOUSEDEV is not set
# CONFIG_INPUT_JOYDEV is not set
CONFIG_INPUT_EVDEV=m
# CONFIG_INPUT_EVBUG is not set

#
# Input Device Drivers
#
# CONFIG_INPUT_KEYBOARD is not set
# CONFIG_INPUT_MOUSE is not set
# CONFIG_INPUT_JOYSTICK is not set
# CONFIG_INPUT_TABLET is not set
# CONFIG_INPUT_TOUCHSCREEN is not set
# CONFIG_INPUT_MISC is not set

#
# Hardware I/O ports
#
# CONFIG_SERIO is not set
# CONFIG_GAMEPORT is not set

#
# Character devices
#
# CONFIG_VT is not set
CONFIG_UNIX98_PTYS=y
# CONFIG_DEVPTS_MULTIPLE_INSTANCES is not set
# CONFIG_LEGACY_PTYS is not set
CONFIG_BFIN_JTAG_COMM=m
# CONFIG_SERIAL_NONSTANDARD is not set
# CONFIG_N_GSM is not set
# CONFIG_TRACE_SINK is not set
# CONFIG_DEVKMEM is not set

#
# Serial drivers
#
# CONFIG_SERIAL_8250 is not set

#
# Non-8250 serial port support
#
# CONFIG_SERIAL_MAX3100 is not set
# CONFIG_SERIAL_MAX3107 is not set
CONFIG_SERIAL_BFIN=y
CONFIG_SERIAL_BFIN_CONSOLE=y
CONFIG_SERIAL_BFIN_DMA=y
# CONFIG_SERIAL_BFIN_PIO is not set
CONFIG_SERIAL_BFIN_UART0=y
# CONFIG_BFIN_UART0_CTSRTS is not set
CONFIG_SERIAL_CORE=y
CONFIG_SERIAL_CORE_CONSOLE=y
# CONFIG_SERIAL_BFIN_SPORT is not set
# CONFIG_SERIAL_TIMBERDALE is not set
# CONFIG_SERIAL_ALTERA_JTAGUART is not set
# CONFIG_SERIAL_ALTERA_UART is not set
# CONFIG_SERIAL_IFX6X60 is not set
# CONFIG_SERIAL_XILINX_PS_UART is not set
# CONFIG_TTY_PRINTK is not set
# CONFIG_HVC_BFIN_JTAG is not set
# CONFIG_IPMI_HANDLER is not set
# CONFIG_HW_RANDOM is not set
# CONFIG_R3964 is not set
# CONFIG_RAW_DRIVER is not set
# CONFIG_TCG_TPM is not set
# CONFIG_I2C is not set
CONFIG_SPI=y
# CONFIG_SPI_DEBUG is not set
CONFIG_SPI_MASTER=y

#
# SPI Master Controller Drivers
#
# CONFIG_SPI_ALTERA is not set
CONFIG_SPI_BFIN5XX=y
# CONFIG_SPI_BFIN_SPORT is not set
# CONFIG_SPI_BITBANG is not set
# CONFIG_SPI_GPIO is not set
# CONFIG_SPI_OC_TINY is not set
# CONFIG_SPI_PXA2XX_PCI is not set
# CONFIG_SPI_XILINX is not set
# CONFIG_SPI_DESIGNWARE is not set

#
# SPI Protocol Masters
#
# CONFIG_SPI_SPIDEV is not set
# CONFIG_SPI_TLE62X0 is not set
# CONFIG_HSI is not set

#
# PPS support
#
# CONFIG_PPS is not set

#
# PPS generators support
#

#
# PTP clock support
#

#
# Enable Device Drivers -> PPS to see the PTP clock options. #
CONFIG_ARCH_HAVE_CUSTOM_GPIO_H=y CONFIG_ARCH_WANT_OPTIONAL_GPIOLIB=y CONFIG_GPIOLIB=y
# CONFIG_DEBUG_GPIO is not set
CONFIG_GPIO_SYSFS=y

#
# Memory mapped GPIO drivers:
#
# CONFIG_GPIO_GENERIC_PLATFORM is not set

#
# I2C GPIO expanders:
#

#
# PCI GPIO expanders:
#

#
# SPI GPIO expanders:
#
# CONFIG_GPIO_MAX7301 is not set
# CONFIG_GPIO_MCP23S08 is not set
# CONFIG_GPIO_MC33880 is not set
# CONFIG_GPIO_74X164 is not set

#
# AC97 GPIO expanders:
#

#
# MODULbus GPIO expanders:
#
# CONFIG_W1 is not set
# CONFIG_POWER_SUPPLY is not set
# CONFIG_HWMON is not set
# CONFIG_THERMAL is not set
CONFIG_WATCHDOG=y
# CONFIG_WATCHDOG_CORE is not set
# CONFIG_WATCHDOG_NOWAYOUT is not set

#
# Watchdog Device Drivers
#
# CONFIG_SOFT_WATCHDOG is not set
CONFIG_BFIN_WDT=y
CONFIG_SSB_POSSIBLE=y

#
# Sonics Silicon Backplane
#
# CONFIG_SSB is not set
CONFIG_BCMA_POSSIBLE=y

#
# Broadcom specific AMBA
#
# CONFIG_BCMA is not set

#
# Multifunction device drivers
#
# CONFIG_MFD_CORE is not set
# CONFIG_MFD_SM501 is not set
# CONFIG_HTC_PASIC3 is not set
# CONFIG_MFD_TPS65912_SPI is not set
# CONFIG_MFD_STMPE is not set
# CONFIG_MFD_TMIO is not set
# CONFIG_MFD_DA9052_SPI is not set
# CONFIG_MFD_WM831X_SPI is not set
# CONFIG_MFD_MC13XXX_SPI is not set
# CONFIG_ABX500_CORE is not set
# CONFIG_EZX_PCAP is not set
# CONFIG_REGULATOR is not set
# CONFIG_MEDIA_SUPPORT is not set

#
# Graphics support
#
# CONFIG_VGASTATE is not set
# CONFIG_VIDEO_OUTPUT_CONTROL is not set
# CONFIG_FB is not set
# CONFIG_EXYNOS_VIDEO is not set
# CONFIG_BACKLIGHT_LCD_SUPPORT is not set
# CONFIG_SOUND is not set

#
# HID support
#
CONFIG_HID=m
# CONFIG_HIDRAW is not set
CONFIG_HID_GENERIC=m

#
# Special HID drivers
#
# CONFIG_USB_ARCH_HAS_OHCI is not set
# CONFIG_USB_ARCH_HAS_EHCI is not set
# CONFIG_USB_ARCH_HAS_XHCI is not set
CONFIG_USB_SUPPORT=y
CONFIG_USB_ARCH_HAS_HCD=y
# CONFIG_USB is not set
# CONFIG_USB_OTG_WHITELIST is not set
# CONFIG_USB_OTG_BLACKLIST_HUB is not set

#
# NOTE: USB_STORAGE depends on SCSI but BLK_DEV_SD may #
# CONFIG_USB_GADGET is not set

#
# OTG and related infrastructure
#
# CONFIG_MMC is not set
# CONFIG_MEMSTICK is not set
# CONFIG_NEW_LEDS is not set
# CONFIG_ACCESSIBILITY is not set
CONFIG_RTC_LIB=y
CONFIG_RTC_CLASS=y
CONFIG_RTC_HCTOSYS=y
CONFIG_RTC_HCTOSYS_DEVICE="rtc0"
# CONFIG_RTC_DEBUG is not set

#
# RTC interfaces
#
CONFIG_RTC_INTF_SYSFS=y
CONFIG_RTC_INTF_PROC=y
CONFIG_RTC_INTF_DEV=y
# CONFIG_RTC_INTF_DEV_UIE_EMUL is not set
# CONFIG_RTC_DRV_TEST is not set

#
# SPI RTC drivers
#
# CONFIG_RTC_DRV_M41T93 is not set
# CONFIG_RTC_DRV_M41T94 is not set
# CONFIG_RTC_DRV_DS1305 is not set
# CONFIG_RTC_DRV_DS1390 is not set
# CONFIG_RTC_DRV_MAX6902 is not set
# CONFIG_RTC_DRV_R9701 is not set
# CONFIG_RTC_DRV_RS5C348 is not set
# CONFIG_RTC_DRV_DS3234 is not set
# CONFIG_RTC_DRV_PCF2123 is not set

#
# Platform RTC drivers
#
# CONFIG_RTC_DRV_DS1286 is not set
# CONFIG_RTC_DRV_DS1511 is not set
# CONFIG_RTC_DRV_DS1553 is not set
# CONFIG_RTC_DRV_DS1742 is not set
# CONFIG_RTC_DRV_STK17TA8 is not set
# CONFIG_RTC_DRV_M48T86 is not set
# CONFIG_RTC_DRV_M48T35 is not set
# CONFIG_RTC_DRV_M48T59 is not set
# CONFIG_RTC_DRV_MSM6242 is not set
# CONFIG_RTC_DRV_BQ4802 is not set
# CONFIG_RTC_DRV_RP5C01 is not set
# CONFIG_RTC_DRV_V3020 is not set

#
# on-CPU RTC drivers
#
CONFIG_RTC_DRV_BFIN=y
# CONFIG_DMADEVICES is not set
# CONFIG_AUXDISPLAY is not set
# CONFIG_UIO is not set

#
# Virtio drivers
#
# CONFIG_VIRTIO_BALLOON is not set
# CONFIG_VIRTIO_MMIO is not set

#
# Microsoft Hyper-V guest support
#
# CONFIG_STAGING is not set

#
# Hardware Spinlock drivers
#
CONFIG_IOMMU_SUPPORT=y

#
# Remoteproc drivers (EXPERIMENTAL)
#

#
# Rpmsg drivers (EXPERIMENTAL)
#
# CONFIG_VIRT_DRIVERS is not set
# CONFIG_PM_DEVFREQ is not set
# CONFIG_EXTCON is not set
# CONFIG_MEMORY is not set
# CONFIG_IIO is not set

#
# Firmware Drivers
#
# CONFIG_FIRMWARE_MEMMAP is not set

#
# File systems
#
# CONFIG_EXT2_FS is not set
# CONFIG_EXT3_FS is not set
# CONFIG_EXT4_FS is not set
# CONFIG_REISERFS_FS is not set
# CONFIG_JFS_FS is not set
# CONFIG_XFS_FS is not set
# CONFIG_BTRFS_FS is not set
# CONFIG_NILFS2_FS is not set
# CONFIG_FS_POSIX_ACL is not set
CONFIG_FILE_LOCKING=y
CONFIG_FSNOTIFY=y
# CONFIG_DNOTIFY is not set
CONFIG_INOTIFY_USER=y
# CONFIG_FANOTIFY is not set
# CONFIG_QUOTA is not set
# CONFIG_QUOTACTL is not set
# CONFIG_AUTOFS4_FS is not set
# CONFIG_FUSE_FS is not set

#
# Caches
#
# CONFIG_FSCACHE is not set

#
# CD-ROM/DVD Filesystems
#
# CONFIG_ISO9660_FS is not set
# CONFIG_UDF_FS is not set

#
# DOS/FAT/NT Filesystems
#
# CONFIG_MSDOS_FS is not set
# CONFIG_VFAT_FS is not set
# CONFIG_NTFS_FS is not set

#
# Pseudo filesystems
#
CONFIG_PROC_FS=y
CONFIG_PROC_SYSCTL=y
CONFIG_SYSFS=y
# CONFIG_HUGETLB_PAGE is not set
# CONFIG_CONFIGFS_FS is not set
CONFIG_MISC_FILESYSTEMS=y
# CONFIG_ADFS_FS is not set
# CONFIG_AFFS_FS is not set
# CONFIG_HFS_FS is not set
# CONFIG_HFSPLUS_FS is not set
# CONFIG_BEFS_FS is not set
# CONFIG_BFS_FS is not set
# CONFIG_EFS_FS is not set
CONFIG_JFFS2_FS=m
CONFIG_JFFS2_FS_DEBUG=0
CONFIG_JFFS2_FS_WRITEBUFFER=y
# CONFIG_JFFS2_FS_WBUF_VERIFY is not set
# CONFIG_JFFS2_SUMMARY is not set
# CONFIG_JFFS2_FS_XATTR is not set
# CONFIG_JFFS2_COMPRESSION_OPTIONS is not set
CONFIG_JFFS2_ZLIB=y
# CONFIG_JFFS2_LZO is not set
CONFIG_JFFS2_RTIME=y
# CONFIG_JFFS2_RUBIN is not set
# CONFIG_LOGFS is not set
# CONFIG_CRAMFS is not set
# CONFIG_SQUASHFS is not set
# CONFIG_VXFS_FS is not set
# CONFIG_MINIX_FS is not set
# CONFIG_OMFS_FS is not set
# CONFIG_HPFS_FS is not set
# CONFIG_QNX4FS_FS is not set
# CONFIG_QNX6FS_FS is not set
# CONFIG_ROMFS_FS is not set
# CONFIG_PSTORE is not set
# CONFIG_SYSV_FS is not set
# CONFIG_UFS_FS is not set
CONFIG_NETWORK_FILESYSTEMS=y
CONFIG_NFS_FS=m
CONFIG_NFS_V2=m
CONFIG_NFS_V3=m
# CONFIG_NFS_V3_ACL is not set
# CONFIG_NFS_V4 is not set
# CONFIG_NFSD is not set
CONFIG_LOCKD=m
CONFIG_LOCKD_V4=y
CONFIG_NFS_COMMON=y
CONFIG_SUNRPC=m
# CONFIG_SUNRPC_DEBUG is not set
# CONFIG_CEPH_FS is not set
# CONFIG_CIFS is not set
# CONFIG_NCP_FS is not set
# CONFIG_CODA_FS is not set
# CONFIG_AFS_FS is not set
# CONFIG_NLS is not set

#
# Kernel hacking
#
# CONFIG_PRINTK_TIME is not set CONFIG_DEFAULT_MESSAGE_LOGLEVEL=4 CONFIG_ENABLE_WARN_DEPRECATED=y CONFIG_ENABLE_MUST_CHECK=y CONFIG_FRAME_WARN=1024
# CONFIG_MAGIC_SYSRQ is not set
# CONFIG_STRIP_ASM_SYMS is not set
# CONFIG_READABLE_ASM is not set
# CONFIG_UNUSED_SYMBOLS is not set CONFIG_DEBUG_FS=y
# CONFIG_HEADERS_CHECK is not set
# CONFIG_DEBUG_SECTION_MISMATCH is not set CONFIG_DEBUG_KERNEL=y
CONFIG_DEBUG_SHIRQ=y
# CONFIG_LOCKUP_DETECTOR is not set
# CONFIG_HARDLOCKUP_DETECTOR is not set
# CONFIG_PANIC_ON_OOPS is not set CONFIG_PANIC_ON_OOPS_VALUE=0 CONFIG_DETECT_HUNG_TASK=y CONFIG_DEFAULT_HUNG_TASK_TIMEOUT=120
# CONFIG_BOOTPARAM_HUNG_TASK_PANIC is not set CONFIG_BOOTPARAM_HUNG_TASK_PANIC_VALUE=0 CONFIG_SCHED_DEBUG=y
# CONFIG_SCHEDSTATS is not set
# CONFIG_TIMER_STATS is not set
# CONFIG_DEBUG_OBJECTS is not set
# CONFIG_DEBUG_SLAB is not set
# CONFIG_DEBUG_SPINLOCK is not set
# CONFIG_DEBUG_MUTEXES is not set
# CONFIG_DEBUG_LOCK_ALLOC is not set
# CONFIG_PROVE_LOCKING is not set
# CONFIG_SPARSE_RCU_POINTER is not set
# CONFIG_LOCK_STAT is not set
# CONFIG_DEBUG_ATOMIC_SLEEP is not set
# CONFIG_DEBUG_LOCKING_API_SELFTESTS is not set # CONFIG_DEBUG_STACK_USAGE is not set
# CONFIG_DEBUG_KOBJECT is not set CONFIG_DEBUG_BUGVERBOSE=y
# CONFIG_DEBUG_INFO is not set
# CONFIG_DEBUG_VM is not set
# CONFIG_DEBUG_NOMMU_REGIONS is not set
# CONFIG_DEBUG_WRITECOUNT is not set
# CONFIG_DEBUG_MEMORY_INIT is not set
# CONFIG_DEBUG_LIST is not set
# CONFIG_TEST_LIST_SORT is not set
# CONFIG_DEBUG_SG is not set
# CONFIG_DEBUG_NOTIFIERS is not set
# CONFIG_DEBUG_CREDENTIALS is not set
# CONFIG_FRAME_POINTER is not set
# CONFIG_BOOT_PRINTK_DELAY is not set
# CONFIG_RCU_TORTURE_TEST is not set
# CONFIG_RCU_TRACE is not set
# CONFIG_BACKTRACE_SELF_TEST is not set
# CONFIG_DEBUG_BLOCK_EXT_DEVT is not set
# CONFIG_DEBUG_FORCE_WEAK_PER_CPU is not set # CONFIG_LKDTM is not set
# CONFIG_FAULT_INJECTION is not set
# CONFIG_DEBUG_PAGEALLOC is not set CONFIG_HAVE_FUNCTION_TRACER=y CONFIG_HAVE_FUNCTION_GRAPH_TRACER=y CONFIG_HAVE_FUNCTION_TRACE_MCOUNT_TEST=y CONFIG_HAVE_DYNAMIC_FTRACE=y CONFIG_HAVE_FTRACE_MCOUNT_RECORD=y CONFIG_TRACING_SUPPORT=y
# CONFIG_FTRACE is not set
# CONFIG_DYNAMIC_DEBUG is not set
# CONFIG_ATOMIC64_SELFTEST is not set
# CONFIG_SAMPLES is not set CONFIG_HAVE_ARCH_KGDB=y
# CONFIG_KGDB is not set
# CONFIG_TEST_KSTRTOX is not set
# CONFIG_DEBUG_STACKOVERFLOW is not set CONFIG_DEBUG_VERBOSE=y
CONFIG_DEBUG_MMRS=y
CONFIG_DEBUG_HWERR=y
CONFIG_EXACT_HWERR=y CONFIG_DEBUG_DOUBLEFAULT=y CONFIG_DEBUG_DOUBLEFAULT_PRINT=y
# CONFIG_DEBUG_DOUBLEFAULT_RESET is not set CONFIG_DEBUG_HUNT_FOR_ZERO=y CONFIG_DEBUG_BFIN_HWTRACE_ON=y
# CONFIG_DEBUG_BFIN_HWTRACE_COMPRESSION_OFF is not set CONFIG_DEBUG_BFIN_HWTRACE_COMPRESSION_ONE=y
# CONFIG_DEBUG_BFIN_HWTRACE_COMPRESSION_TWO is not set CONFIG_DEBUG_BFIN_HWTRACE_COMPRESSION=1
# CONFIG_DEBUG_BFIN_HWTRACE_EXPAND is not set CONFIG_DEBUG_BFIN_NO_KERN_HWTRACE=y CONFIG_EARLY_PRINTK=y
CONFIG_CPLB_INFO=y
CONFIG_ACCESS_CHECK=y
# CONFIG_BFIN_ISRAM_SELF_TEST is not set CONFIG_BFIN_PSEUDODBG_INSNS=y
# CONFIG_BFIN_PM_WAKEUP_TIME_BENCH is not set

#
# Security options
#
# CONFIG_KEYS is not set
# CONFIG_SECURITY_DMESG_RESTRICT is not set
# CONFIG_SECURITY is not set
# CONFIG_SECURITYFS is not set
CONFIG_DEFAULT_SECURITY_DAC=y
CONFIG_DEFAULT_SECURITY=""
CONFIG_CRYPTO=y

#
# Crypto core or helper
#
# CONFIG_CRYPTO_MANAGER is not set
# CONFIG_CRYPTO_MANAGER2 is not set
# CONFIG_CRYPTO_USER is not set
# CONFIG_CRYPTO_GF128MUL is not set
# CONFIG_CRYPTO_NULL is not set
# CONFIG_CRYPTO_CRYPTD is not set
# CONFIG_CRYPTO_AUTHENC is not set
# CONFIG_CRYPTO_TEST is not set

#
# Authenticated Encryption with Associated Data
#
# CONFIG_CRYPTO_CCM is not set
# CONFIG_CRYPTO_GCM is not set
# CONFIG_CRYPTO_SEQIV is not set

#
# Block modes
#
# CONFIG_CRYPTO_CBC is not set
# CONFIG_CRYPTO_CTR is not set
# CONFIG_CRYPTO_CTS is not set
# CONFIG_CRYPTO_ECB is not set
# CONFIG_CRYPTO_LRW is not set
# CONFIG_CRYPTO_PCBC is not set
# CONFIG_CRYPTO_XTS is not set

#
# Hash modes
#
# CONFIG_CRYPTO_HMAC is not set
# CONFIG_CRYPTO_XCBC is not set
# CONFIG_CRYPTO_VMAC is not set

#
# Digest
#
# CONFIG_CRYPTO_CRC32C is not set
# CONFIG_CRYPTO_GHASH is not set
# CONFIG_CRYPTO_MD4 is not set
# CONFIG_CRYPTO_MD5 is not set
# CONFIG_CRYPTO_MICHAEL_MIC is not set
# CONFIG_CRYPTO_RMD128 is not set
# CONFIG_CRYPTO_RMD160 is not set
# CONFIG_CRYPTO_RMD256 is not set
# CONFIG_CRYPTO_RMD320 is not set
# CONFIG_CRYPTO_SHA1 is not set
# CONFIG_CRYPTO_SHA256 is not set
# CONFIG_CRYPTO_SHA512 is not set
# CONFIG_CRYPTO_TGR192 is not set
# CONFIG_CRYPTO_WP512 is not set

#
# Ciphers
#
# CONFIG_CRYPTO_AES is not set
# CONFIG_CRYPTO_ANUBIS is not set
# CONFIG_CRYPTO_ARC4 is not set
# CONFIG_CRYPTO_BLOWFISH is not set
# CONFIG_CRYPTO_CAMELLIA is not set
# CONFIG_CRYPTO_CAST5 is not set
# CONFIG_CRYPTO_CAST6 is not set
# CONFIG_CRYPTO_DES is not set
# CONFIG_CRYPTO_FCRYPT is not set
# CONFIG_CRYPTO_KHAZAD is not set
# CONFIG_CRYPTO_SALSA20 is not set
# CONFIG_CRYPTO_SEED is not set
# CONFIG_CRYPTO_SERPENT is not set
# CONFIG_CRYPTO_TEA is not set
# CONFIG_CRYPTO_TWOFISH is not set

#
# Compression
#
# CONFIG_CRYPTO_DEFLATE is not set
# CONFIG_CRYPTO_ZLIB is not set
# CONFIG_CRYPTO_LZO is not set

#
# Random Number Generation
#
# CONFIG_CRYPTO_ANSI_CPRNG is not set
# CONFIG_CRYPTO_USER_API_HASH is not set
# CONFIG_CRYPTO_USER_API_SKCIPHER is not set
CONFIG_CRYPTO_HW=y
# CONFIG_BINARY_PRINTF is not set

#
# Library routines
#
CONFIG_BITREVERSE=y
CONFIG_GENERIC_IO=y
CONFIG_CRC_CCITT=m
# CONFIG_CRC16 is not set
# CONFIG_CRC_T10DIF is not set
# CONFIG_CRC_ITU_T is not set
CONFIG_CRC32=y
# CONFIG_CRC32_SELFTEST is not set
CONFIG_CRC32_SLICEBY8=y
# CONFIG_CRC32_SLICEBY4 is not set
# CONFIG_CRC32_SARWATE is not set
# CONFIG_CRC32_BIT is not set
# CONFIG_CRC7 is not set
# CONFIG_LIBCRC32C is not set
# CONFIG_CRC8 is not set
CONFIG_ZLIB_INFLATE=y
CONFIG_ZLIB_DEFLATE=m
# CONFIG_XZ_DEC is not set
# CONFIG_XZ_DEC_BCJ is not set
CONFIG_DECOMPRESS_GZIP=y
CONFIG_HAS_IOMEM=y
CONFIG_HAS_IOPORT=y
CONFIG_HAS_DMA=y
CONFIG_DQL=y
CONFIG_NLATTR=y
CONFIG_GENERIC_ATOMIC64=y
# CONFIG_AVERAGE is not set
# CONFIG_CORDIC is not set
# CONFIG_DDR is not set

#1 lore raw

Bryan,

Why did you switch to using IS_ENABLED in the first place, and why wasn't that put in a separate patch?

Quoted 38 lines

-----Original Message-----
From: Fengguang Wu [mailto:[email protected]]
Sent: Monday, July 30, 2012 10:43 PM
To: Schumaker, Bryan
Cc: [email protected]; Myklebust, Trond; linux- [email protected]
Subject: [nfs:devel 46/51] fs/nfs/write.c:1592:5: error: redefinition of 'nfs_commit_inode'

Hi Bryan,

Kernel build failed on

tree:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git devel
head:   5c13c9e1c15ee2ca9ab2b953224001af53d9be09
commit: 1c606fb74c758beafd98cbad9a9133eadeec2371 [46/51] NFS: Convert

v3 into a module
config: blackfin-BF533-EZKIT_defconfig (attached as .config)

All related error/warning messages:

fs/nfs/write.c:1592:5: error: redefinition of 'nfs_commit_inode' In file included from fs/nfs/write.c:19:0:
include/linux/nfs_fs.h:547:1: note: previous definition of 'nfs_commit_inode' was here

vim +1592 fs/nfs/write.c
1589 return status;
1590 }
1591

Quoted 1 line

1592 int nfs_commit_inode(struct inode *inode, int how)

1593 {
1594 LIST_HEAD(head);
1595 struct nfs_commit_info cinfo;

---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <[email protected]> Intel Corporation

#2 lore raw
Quoted 3 lines · Trond

Bryan,

Why did you switch to using IS_ENABLED in the first place, and why wasn't that put in a separate patch?

IS_ENABLED() will check for CONFIG_NFS_V*_MODULE, last I checked the defined() macro doesn't. Putting this into a separate patch makes the change non-bisectable since gcc will be checking against CONFIG_NFS_V3 but CONFIG_NFS_V3_MODULE is set. Should I have changed the CONFIG_ variables instead of using IS_ENABLED()?

Quoted 41 lines
Quoted 41 lines

-----Original Message-----
From: Fengguang Wu [mailto:[email protected]]
Sent: Monday, July 30, 2012 10:43 PM
To: Schumaker, Bryan
Cc: [email protected]; Myklebust, Trond; linux- [email protected]
Subject: [nfs:devel 46/51] fs/nfs/write.c:1592:5: error: redefinition of 'nfs_commit_inode'

Hi Bryan,

Kernel build failed on

tree:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git devel
head:   5c13c9e1c15ee2ca9ab2b953224001af53d9be09
commit: 1c606fb74c758beafd98cbad9a9133eadeec2371 [46/51] NFS: Convert

v3 into a module
config: blackfin-BF533-EZKIT_defconfig (attached as .config)

All related error/warning messages:

fs/nfs/write.c:1592:5: error: redefinition of 'nfs_commit_inode' In file included from fs/nfs/write.c:19:0:
include/linux/nfs_fs.h:547:1: note: previous definition of 'nfs_commit_inode' was here

vim +1592 fs/nfs/write.c
1589 return status;
1590 }
1591

Quoted 1 line

1592 int nfs_commit_inode(struct inode *inode, int how)

1593 {
1594 LIST_HEAD(head);
1595 struct nfs_commit_info cinfo;

---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <[email protected]> Intel Corporation

#3 lore raw

T24gVHVlLCAyMDEyLTA3LTMxIGF0IDA4OjQ3IC0wNDAwLCBCcnlhbiBTY2h1bWFrZXIgd3JvdGU6 DQo+IE9uIDA3LzMwLzIwMTIgMTE6MTQgUE0sIE15a2xlYnVzdCwgVHJvbmQgd3JvdGU6DQo+ID4g QnJ5YW4sDQo+ID4gDQo+ID4gV2h5IGRpZCB5b3Ugc3dpdGNoIHRvIHVzaW5nIElTX0VOQUJMRUQg aW4gdGhlIGZpcnN0IHBsYWNlLCBhbmQgd2h5IHdhc24ndCB0aGF0IHB1dCBpbiBhIHNlcGFyYXRl IHBhdGNoPw0KPiANCj4gSVNfRU5BQkxFRCgpIHdpbGwgY2hlY2sgZm9yIENPTkZJR19ORlNfVipf TU9EVUxFLCBsYXN0IEkgY2hlY2tlZCB0aGUgZGVmaW5lZCgpIG1hY3JvIGRvZXNuJ3QuICBQdXR0 aW5nIHRoaXMgaW50byBhIHNlcGFyYXRlIHBhdGNoIG1ha2VzIHRoZSBjaGFuZ2Ugbm9uLWJpc2Vj dGFibGUgc2luY2UgZ2NjIHdpbGwgYmUgY2hlY2tpbmcgYWdhaW5zdCBDT05GSUdfTkZTX1YzIGJ1 dCBDT05GSUdfTkZTX1YzX01PRFVMRSBpcyBzZXQuICBTaG91bGQgSSBoYXZlIGNoYW5nZWQgdGhl IENPTkZJR18gdmFyaWFibGVzIGluc3RlYWQgb2YgdXNpbmcgSVNfRU5BQkxFRCgpPw0KDQpXaHkg aXMgaXQgZXZhbHVhdGluZyBkaWZmZXJlbnRseSBpbiB0aGUgaW5jbHVkZSBmaWxlIHZzLiB0aGUg LmMgZmlsZT8NCkFyZSB3ZSBtaXNzaW5nIGFuIGluY2x1ZGUgaW4gbmZzX2ZzLmg/DQoNCj4gPiAN Cj4gPiANCj4gPiANCj4gPj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPj4gRnJvbTog RmVuZ2d1YW5nIFd1IFttYWlsdG86ZmVuZ2d1YW5nLnd1QGludGVsLmNvbV0NCj4gPj4gU2VudDog TW9uZGF5LCBKdWx5IDMwLCAyMDEyIDEwOjQzIFBNDQo+ID4+IFRvOiBTY2h1bWFrZXIsIEJyeWFu DQo+ID4+IENjOiBrZXJuZWwtamFuaXRvcnNAdmdlci5rZXJuZWwub3JnOyBNeWtsZWJ1c3QsIFRy b25kOyBsaW51eC0NCj4gPj4gbmZzQHZnZXIua2VybmVsLm9yZw0KPiA+PiBTdWJqZWN0OiBbbmZz OmRldmVsIDQ2LzUxXSBmcy9uZnMvd3JpdGUuYzoxNTkyOjU6IGVycm9yOiByZWRlZmluaXRpb24g b2YNCj4gPj4gJ25mc19jb21taXRfaW5vZGUnDQo+ID4+DQo+ID4+IEhpIEJyeWFuLA0KPiA+Pg0K PiA+PiBLZXJuZWwgYnVpbGQgZmFpbGVkIG9uDQo+ID4+DQo+ID4+IHRyZWU6ICAgZ2l0Oi8vZ2l0 LmxpbnV4LW5mcy5vcmcvcHJvamVjdHMvdHJvbmRteS9saW51eC1uZnMuZ2l0IGRldmVsDQo+ID4+ IGhlYWQ6ICAgNWMxM2M5ZTFjMTVlZTJjYTlhYjJiOTUzMjI0MDAxYWY1M2Q5YmUwOQ0KPiA+PiBj b21taXQ6IDFjNjA2ZmI3NGM3NThiZWFmZDk4Y2JhZDlhOTEzM2VhZGVlYzIzNzEgWzQ2LzUxXSBO RlM6IENvbnZlcnQNCj4gPj4gdjMgaW50byBhIG1vZHVsZQ0KPiA+PiBjb25maWc6IGJsYWNrZmlu LUJGNTMzLUVaS0lUX2RlZmNvbmZpZyAoYXR0YWNoZWQgYXMgLmNvbmZpZykNCj4gPj4NCj4gPj4g QWxsIHJlbGF0ZWQgZXJyb3Ivd2FybmluZyBtZXNzYWdlczoNCj4gPj4NCj4gPj4gZnMvbmZzL3dy aXRlLmM6MTU5Mjo1OiBlcnJvcjogcmVkZWZpbml0aW9uIG9mICduZnNfY29tbWl0X2lub2RlJw0K PiA+PiBJbiBmaWxlIGluY2x1ZGVkIGZyb20gZnMvbmZzL3dyaXRlLmM6MTk6MDoNCj4gPj4gaW5j bHVkZS9saW51eC9uZnNfZnMuaDo1NDc6MTogbm90ZTogcHJldmlvdXMgZGVmaW5pdGlvbiBvZiAn bmZzX2NvbW1pdF9pbm9kZScNCj4gPj4gd2FzIGhlcmUNCj4gPj4NCj4gPj4gdmltICsxNTkyIGZz L25mcy93cml0ZS5jDQo+ID4+ICAgMTU4OQkJcmV0dXJuIHN0YXR1czsNCj4gPj4gICAxNTkwCX0N Cj4gPj4gICAxNTkxDQo+ID4+PiAxNTkyCWludCBuZnNfY29tbWl0X2lub2RlKHN0cnVjdCBpbm9k ZSAqaW5vZGUsIGludCBob3cpDQo+ID4+ICAgMTU5Mwl7DQo+ID4+ICAgMTU5NAkJTElTVF9IRUFE KGhlYWQpOw0KPiA+PiAgIDE1OTUJCXN0cnVjdCBuZnNfY29tbWl0X2luZm8gY2luZm87DQo+ID4+ DQo+ID4+IC0tLQ0KPiA+PiAwLURBWSBrZXJuZWwgYnVpbGQgdGVzdGluZyBiYWNrZW5kICAgICAg ICAgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50cmUNCj4gPj4gRmVuZ2d1YW5nIFd1IDx3ZmdA bGludXguaW50ZWwuY29tPiAgICAgICAgICAgICAgICAgICAgIEludGVsIENvcnBvcmF0aW9uDQo+ IA0KDQo

#4 lore raw
Quoted 10 lines · Trond
Quoted 6 lines · Bryan Schumaker
Quoted 3 lines · Trond

Bryan,

Why did you switch to using IS_ENABLED in the first place, and why wasn't that put in a separate patch?

IS_ENABLED() will check for CONFIG_NFS_V*_MODULE, last I checked the defined() macro doesn't. Putting this into a separate patch makes the change non-bisectable since gcc will be checking against CONFIG_NFS_V3 but CONFIG_NFS_V3_MODULE is set. Should I have changed the CONFIG_ variables instead of using IS_ENABLED()?

Why is it evaluating differently in the include file vs. the .c file? Are we missing an include in nfs_fs.h?

Good question. I don't see any reason that it would evaluate differently, but I'm compiling the .config attached to the initial email to try to figure it out.

- Bryan

Quoted 44 lines
Quoted 43 lines
Quoted 42 lines
Quoted 42 lines

-----Original Message-----
From: Fengguang Wu [mailto:[email protected]]
Sent: Monday, July 30, 2012 10:43 PM
To: Schumaker, Bryan
Cc: [email protected]; Myklebust, Trond; linux- [email protected]
Subject: [nfs:devel 46/51] fs/nfs/write.c:1592:5: error: redefinition of 'nfs_commit_inode'

Hi Bryan,

Kernel build failed on

tree:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git devel
head:   5c13c9e1c15ee2ca9ab2b953224001af53d9be09
commit: 1c606fb74c758beafd98cbad9a9133eadeec2371 [46/51] NFS: Convert

v3 into a module
config: blackfin-BF533-EZKIT_defconfig (attached as .config)

All related error/warning messages:

fs/nfs/write.c:1592:5: error: redefinition of 'nfs_commit_inode' In file included from fs/nfs/write.c:19:0:
include/linux/nfs_fs.h:547:1: note: previous definition of 'nfs_commit_inode' was here

vim +1592 fs/nfs/write.c
1589 return status;
1590 }
1591

Quoted 1 line

1592 int nfs_commit_inode(struct inode *inode, int how)

1593 {
1594 LIST_HEAD(head);
1595 struct nfs_commit_info cinfo;

---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <[email protected]> Intel Corporation

#5 lore raw
Quoted 5 lines · Bryan Schumaker
Quoted 4 lines · Trond
Quoted 3 lines · Bryan Schumaker
Quoted 2 lines · Trond

Bryan,

Quoted 9 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line

Why did you switch to using IS_ENABLED in the first place, and why wasn't that put in a separate patch?

IS_ENABLED() will check for CONFIG_NFS_V*_MODULE, last I checked the defined() macro doesn't. Putting this into a separate patch makes the change non-bisectable since gcc will be checking against CONFIG_NFS_V3 but CONFIG_NFS_V3_MODULE is set. Should I have changed the CONFIG_ variables instead of using IS_ENABLED()?

Why is it evaluating differently in the include file vs. the .c file? Are we missing an include in nfs_fs.h?

Good question. I don't see any reason that it would evaluate differently, but I'm compiling the .config attached to the initial email to try to figure it out.

Looks like the IS_ENABLED() switch got pushed to the next patch for V3 in include/linux/nfs_fs.h. Want me to resend the patches? I took another look at how IS_ENABLED() is defined, and it'll work if I do the switch in the patch before I turn everything into separate modules if you want me to resend everything.

Quoted 47 lines

- Bryan

Quoted 44 lines
Quoted 43 lines
Quoted 42 lines
Quoted 42 lines

-----Original Message-----
From: Fengguang Wu [mailto:[email protected]]
Sent: Monday, July 30, 2012 10:43 PM
To: Schumaker, Bryan
Cc: [email protected]; Myklebust, Trond; linux- [email protected]
Subject: [nfs:devel 46/51] fs/nfs/write.c:1592:5: error: redefinition of 'nfs_commit_inode'

Hi Bryan,

Kernel build failed on

tree:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git devel
head:   5c13c9e1c15ee2ca9ab2b953224001af53d9be09
commit: 1c606fb74c758beafd98cbad9a9133eadeec2371 [46/51] NFS: Convert

v3 into a module
config: blackfin-BF533-EZKIT_defconfig (attached as .config)

All related error/warning messages:

fs/nfs/write.c:1592:5: error: redefinition of 'nfs_commit_inode' In file included from fs/nfs/write.c:19:0:
include/linux/nfs_fs.h:547:1: note: previous definition of 'nfs_commit_inode' was here

vim +1592 fs/nfs/write.c
1589 return status;
1590 }
1591

Quoted 1 line

1592 int nfs_commit_inode(struct inode *inode, int how)

1593 {
1594 LIST_HEAD(head);
1595 struct nfs_commit_info cinfo;

---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <[email protected]> Intel Corporation

#6 lore raw

T24gVHVlLCAyMDEyLTA3LTMxIGF0IDA5OjMwIC0wNDAwLCBCcnlhbiBTY2h1bWFrZXIgd3JvdGU6 DQo+IE9uIDA3LzMxLzIwMTIgMDk6MDUgQU0sIEJyeWFuIFNjaHVtYWtlciB3cm90ZToNCj4gPiBP biAwNy8zMS8yMDEyIDA4OjU1IEFNLCBNeWtsZWJ1c3QsIFRyb25kIHdyb3RlOg0KPiA+PiBPbiBU dWUsIDIwMTItMDctMzEgYXQgMDg6NDcgLTA0MDAsIEJyeWFuIFNjaHVtYWtlciB3cm90ZToNCj4g Pj4+IE9uIDA3LzMwLzIwMTIgMTE6MTQgUE0sIE15a2xlYnVzdCwgVHJvbmQgd3JvdGU6DQo+ID4+ Pj4gQnJ5YW4sDQo+ID4+Pj4NCj4gPj4+PiBXaHkgZGlkIHlvdSBzd2l0Y2ggdG8gdXNpbmcgSVNf RU5BQkxFRCBpbiB0aGUgZmlyc3QgcGxhY2UsIGFuZCB3aHkgd2Fzbid0IHRoYXQgcHV0IGluIGEg c2VwYXJhdGUgcGF0Y2g/DQo+ID4+Pg0KPiA+Pj4gSVNfRU5BQkxFRCgpIHdpbGwgY2hlY2sgZm9y IENPTkZJR19ORlNfVipfTU9EVUxFLCBsYXN0IEkgY2hlY2tlZCB0aGUgZGVmaW5lZCgpIG1hY3Jv IGRvZXNuJ3QuICBQdXR0aW5nIHRoaXMgaW50byBhIHNlcGFyYXRlIHBhdGNoIG1ha2VzIHRoZSBj aGFuZ2Ugbm9uLWJpc2VjdGFibGUgc2luY2UgZ2NjIHdpbGwgYmUgY2hlY2tpbmcgYWdhaW5zdCBD T05GSUdfTkZTX1YzIGJ1dCBDT05GSUdfTkZTX1YzX01PRFVMRSBpcyBzZXQuICBTaG91bGQgSSBo YXZlIGNoYW5nZWQgdGhlIENPTkZJR18gdmFyaWFibGVzIGluc3RlYWQgb2YgdXNpbmcgSVNfRU5B QkxFRCgpPw0KPiA+Pg0KPiA+PiBXaHkgaXMgaXQgZXZhbHVhdGluZyBkaWZmZXJlbnRseSBpbiB0 aGUgaW5jbHVkZSBmaWxlIHZzLiB0aGUgLmMgZmlsZT8NCj4gPj4gQXJlIHdlIG1pc3NpbmcgYW4g aW5jbHVkZSBpbiBuZnNfZnMuaD8NCj4gPiANCj4gPiBHb29kIHF1ZXN0aW9uLiAgSSBkb24ndCBz ZWUgYW55IHJlYXNvbiB0aGF0IGl0IHdvdWxkIGV2YWx1YXRlIGRpZmZlcmVudGx5LCBidXQgSSdt IGNvbXBpbGluZyB0aGUgLmNvbmZpZyBhdHRhY2hlZCB0byB0aGUgaW5pdGlhbCBlbWFpbCB0byB0 cnkgdG8gZmlndXJlIGl0IG91dC4NCj4gPiANCj4gDQo+IExvb2tzIGxpa2UgdGhlIElTX0VOQUJM RUQoKSBzd2l0Y2ggZ290IHB1c2hlZCB0byB0aGUgbmV4dCBwYXRjaCBmb3IgVjMgaW4gaW5jbHVk ZS9saW51eC9uZnNfZnMuaC4gIFdhbnQgbWUgdG8gcmVzZW5kIHRoZSBwYXRjaGVzPyAgSSB0b29r IGFub3RoZXIgbG9vayBhdCBob3cgSVNfRU5BQkxFRCgpIGlzIGRlZmluZWQsIGFuZCBpdCdsbCB3 b3JrIGlmIEkgZG8gdGhlIHN3aXRjaCBpbiB0aGUgcGF0Y2ggYmVmb3JlIEkgdHVybiBldmVyeXRo aW5nIGludG8gc2VwYXJhdGUgbW9kdWxlcyBpZiB5b3Ugd2FudCBtZSB0byByZXNlbmQgZXZlcnl0 aGluZy4NCg0KUGxlYXNlIGp1c3QgbWFrZSBpdCBpbmNyZW1lbnRhbCB0byB0aGUgcGF0Y2ggc2Vy aWVzIHRoYXQgaXMgYWxyZWFkeQ0KbWVyZ2VkIGluIHRvZGF5J3MgbmZzLWZvci0zLjYuDQoNCkNo ZWVycw0KICBUcm9uZA0KDQo+ID4gLSBCcnlhbg0KPiA+IA0KPiA+Pg0KPiA+Pj4+DQo+ID4+Pj4N Cj4gPj4+Pg0KPiA+Pj4+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+Pj4+PiBGcm9t OiBGZW5nZ3VhbmcgV3UgW21haWx0bzpmZW5nZ3Vhbmcud3VAaW50ZWwuY29tXQ0KPiA+Pj4+PiBT ZW50OiBNb25kYXksIEp1bHkgMzAsIDIwMTIgMTA6NDMgUE0NCj4gPj4+Pj4gVG86IFNjaHVtYWtl ciwgQnJ5YW4NCj4gPj4+Pj4gQ2M6IGtlcm5lbC1qYW5pdG9yc0B2Z2VyLmtlcm5lbC5vcmc7IE15 a2xlYnVzdCwgVHJvbmQ7IGxpbnV4LQ0KPiA+Pj4+PiBuZnNAdmdlci5rZXJuZWwub3JnDQo+ID4+ Pj4+IFN1YmplY3Q6IFtuZnM6ZGV2ZWwgNDYvNTFdIGZzL25mcy93cml0ZS5jOjE1OTI6NTogZXJy b3I6IHJlZGVmaW5pdGlvbiBvZg0KPiA+Pj4+PiAnbmZzX2NvbW1pdF9pbm9kZScNCj4gPj4+Pj4N Cj4gPj4+Pj4gSGkgQnJ5YW4sDQo+ID4+Pj4+DQo+ID4+Pj4+IEtlcm5lbCBidWlsZCBmYWlsZWQg b24NCj4gPj4+Pj4NCj4gPj4+Pj4gdHJlZTogICBnaXQ6Ly9naXQubGludXgtbmZzLm9yZy9wcm9q ZWN0cy90cm9uZG15L2xpbnV4LW5mcy5naXQgZGV2ZWwNCj4gPj4+Pj4gaGVhZDogICA1YzEzYzll MWMxNWVlMmNhOWFiMmI5NTMyMjQwMDFhZjUzZDliZTA5DQo+ID4+Pj4+IGNvbW1pdDogMWM2MDZm Yjc0Yzc1OGJlYWZkOThjYmFkOWE5MTMzZWFkZWVjMjM3MSBbNDYvNTFdIE5GUzogQ29udmVydA0K PiA+Pj4+PiB2MyBpbnRvIGEgbW9kdWxlDQo+ID4+Pj4+IGNvbmZpZzogYmxhY2tmaW4tQkY1MzMt RVpLSVRfZGVmY29uZmlnIChhdHRhY2hlZCBhcyAuY29uZmlnKQ0KPiA+Pj4+Pg0KPiA+Pj4+PiBB bGwgcmVsYXRlZCBlcnJvci93YXJuaW5nIG1lc3NhZ2VzOg0KPiA+Pj4+Pg0KPiA+Pj4+PiBmcy9u ZnMvd3JpdGUuYzoxNTkyOjU6IGVycm9yOiByZWRlZmluaXRpb24gb2YgJ25mc19jb21taXRfaW5v ZGUnDQo+ID4+Pj4+IEluIGZpbGUgaW5jbHVkZWQgZnJvbSBmcy9uZnMvd3JpdGUuYzoxOTowOg0K PiA+Pj4+PiBpbmNsdWRlL2xpbnV4L25mc19mcy5oOjU0NzoxOiBub3RlOiBwcmV2aW91cyBkZWZp bml0aW9uIG9mICduZnNfY29tbWl0X2lub2RlJw0KPiA+Pj4+PiB3YXMgaGVyZQ0KPiA+Pj4+Pg0K PiA+Pj4+PiB2aW0gKzE1OTIgZnMvbmZzL3dyaXRlLmMNCj4gPj4+Pj4gICAxNTg5CQlyZXR1cm4g c3RhdHVzOw0KPiA+Pj4+PiAgIDE1OTAJfQ0KPiA+Pj4+PiAgIDE1OTENCj4gPj4+Pj4+IDE1OTIJ aW50IG5mc19jb21taXRfaW5vZGUoc3RydWN0IGlub2RlICppbm9kZSwgaW50IGhvdykNCj4gPj4+ Pj4gICAxNTkzCXsNCj4gPj4+Pj4gICAxNTk0CQlMSVNUX0hFQUQoaGVhZCk7DQo+ID4+Pj4+ICAg MTU5NQkJc3RydWN0IG5mc19jb21taXRfaW5mbyBjaW5mbzsNCj4gPj4+Pj4NCj4gPj4+Pj4gLS0t DQo+ID4+Pj4+IDAtREFZIGtlcm5lbCBidWlsZCB0ZXN0aW5nIGJhY2tlbmQgICAgICAgICBPcGVu IFNvdXJjZSBUZWNobm9sb2d5IENlbnRyZQ0KPiA+Pj4+PiBGZW5nZ3VhbmcgV3UgPHdmZ0BsaW51 eC5pbnRlbC5jb20+ICAgICAgICAgICAgICAgICAgICAgSW50ZWwgQ29ycG9yYXRpb24NCj4gPj4+ DQo+ID4+DQo+ID4gDQo+IA0KDQo

#7 lore raw
Quoted 14 lines · Trond
Quoted 13 lines · Bryan Schumaker
Quoted 12 lines · Bryan Schumaker
Quoted 10 lines · Trond
Quoted 6 lines · Bryan Schumaker
Quoted 3 lines · Trond

Bryan,

Why did you switch to using IS_ENABLED in the first place, and why wasn't that put in a separate patch?

IS_ENABLED() will check for CONFIG_NFS_V*_MODULE, last I checked the defined() macro doesn't. Putting this into a separate patch makes the change non-bisectable since gcc will be checking against CONFIG_NFS_V3 but CONFIG_NFS_V3_MODULE is set. Should I have changed the CONFIG_ variables instead of using IS_ENABLED()?

Why is it evaluating differently in the include file vs. the .c file? Are we missing an include in nfs_fs.h?

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

Good question. I don't see any reason that it would evaluate differently, but I'm compiling the .config attached to the initial email to try to figure it out.

Looks like the IS_ENABLED() switch got pushed to the next patch for V3 in include/linux/nfs_fs.h. Want me to resend the patches? I took another look at how IS_ENABLED() is defined, and it'll work if I do the switch in the patch before I turn everything into separate modules if you want me to resend everything.

Please just make it incremental to the patch series that is already merged in today's nfs-for-3.6.

Easy enough, the patch that fixes it is the last one in the series that I sent in yesterday.

Quoted 53 lines

Cheers
Trond

Quoted 48 lines
Quoted 47 lines

- Bryan

Quoted 44 lines
Quoted 43 lines
Quoted 42 lines
Quoted 42 lines

-----Original Message-----
From: Fengguang Wu [mailto:[email protected]]
Sent: Monday, July 30, 2012 10:43 PM
To: Schumaker, Bryan
Cc: [email protected]; Myklebust, Trond; linux- [email protected]
Subject: [nfs:devel 46/51] fs/nfs/write.c:1592:5: error: redefinition of 'nfs_commit_inode'

Hi Bryan,

Kernel build failed on

tree:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git devel
head:   5c13c9e1c15ee2ca9ab2b953224001af53d9be09
commit: 1c606fb74c758beafd98cbad9a9133eadeec2371 [46/51] NFS: Convert

v3 into a module
config: blackfin-BF533-EZKIT_defconfig (attached as .config)

All related error/warning messages:

fs/nfs/write.c:1592:5: error: redefinition of 'nfs_commit_inode' In file included from fs/nfs/write.c:19:0:
include/linux/nfs_fs.h:547:1: note: previous definition of 'nfs_commit_inode' was here

vim +1592 fs/nfs/write.c
1589 return status;
1590 }
1591

Quoted 1 line

1592 int nfs_commit_inode(struct inode *inode, int how)

1593 {
1594 LIST_HEAD(head);
1595 struct nfs_commit_info cinfo;

---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <[email protected]> Intel Corporation

#8 lore raw

Bryan,

Do you have a git tree that I can run tests upon? That would help prevent problems from sneaking into Trond's tree, and hence mess up the maintainer's tree and waste everyone's time.

Thanks,
Fengguang

#9 lore raw

I've got one at: git://git.linux-nfs.org/projects/bjschuma/linux-nfs.git. I don't always do a good job keeping it up-to-date, but I can try to get into the habit of putting my patches there before submitting them.

- Bryan

Quoted 9 lines · Fengguang Wu

Bryan,

Do you have a git tree that I can run tests upon? That would help prevent problems from sneaking into Trond's tree, and hence mess up the maintainer's tree and waste everyone's time.

Thanks,
Fengguang

#12 lore raw
In reply to Bryan Schumaker

T24gVHVlLCAyMDEyLTA3LTMxIGF0IDA5OjQ0IC0wNDAwLCBCcnlhbiBTY2h1bWFrZXIgd3JvdGU6 DQo+IE9uIDA3LzMxLzIwMTIgMDk6MzMgQU0sIE15a2xlYnVzdCwgVHJvbmQgd3JvdGU6DQo+ID4g T24gVHVlLCAyMDEyLTA3LTMxIGF0IDA5OjMwIC0wNDAwLCBCcnlhbiBTY2h1bWFrZXIgd3JvdGU6 DQo+ID4+IE9uIDA3LzMxLzIwMTIgMDk6MDUgQU0sIEJyeWFuIFNjaHVtYWtlciB3cm90ZToNCj4g Pj4+IE9uIDA3LzMxLzIwMTIgMDg6NTUgQU0sIE15a2xlYnVzdCwgVHJvbmQgd3JvdGU6DQo+ID4+ Pj4gT24gVHVlLCAyMDEyLTA3LTMxIGF0IDA4OjQ3IC0wNDAwLCBCcnlhbiBTY2h1bWFrZXIgd3Jv dGU6DQo+ID4+Pj4+IE9uIDA3LzMwLzIwMTIgMTE6MTQgUE0sIE15a2xlYnVzdCwgVHJvbmQgd3Jv dGU6DQo+ID4+Pj4+PiBCcnlhbiwNCj4gPj4+Pj4+DQo+ID4+Pj4+PiBXaHkgZGlkIHlvdSBzd2l0 Y2ggdG8gdXNpbmcgSVNfRU5BQkxFRCBpbiB0aGUgZmlyc3QgcGxhY2UsIGFuZCB3aHkgd2Fzbid0 IHRoYXQgcHV0IGluIGEgc2VwYXJhdGUgcGF0Y2g/DQo+ID4+Pj4+DQo+ID4+Pj4+IElTX0VOQUJM RUQoKSB3aWxsIGNoZWNrIGZvciBDT05GSUdfTkZTX1YqX01PRFVMRSwgbGFzdCBJIGNoZWNrZWQg dGhlIGRlZmluZWQoKSBtYWNybyBkb2Vzbid0LiAgUHV0dGluZyB0aGlzIGludG8gYSBzZXBhcmF0 ZSBwYXRjaCBtYWtlcyB0aGUgY2hhbmdlIG5vbi1iaXNlY3RhYmxlIHNpbmNlIGdjYyB3aWxsIGJl IGNoZWNraW5nIGFnYWluc3QgQ09ORklHX05GU19WMyBidXQgQ09ORklHX05GU19WM19NT0RVTEUg aXMgc2V0LiAgU2hvdWxkIEkgaGF2ZSBjaGFuZ2VkIHRoZSBDT05GSUdfIHZhcmlhYmxlcyBpbnN0 ZWFkIG9mIHVzaW5nIElTX0VOQUJMRUQoKT8NCj4gPj4+Pg0KPiA+Pj4+IFdoeSBpcyBpdCBldmFs dWF0aW5nIGRpZmZlcmVudGx5IGluIHRoZSBpbmNsdWRlIGZpbGUgdnMuIHRoZSAuYyBmaWxlPw0K PiA+Pj4+IEFyZSB3ZSBtaXNzaW5nIGFuIGluY2x1ZGUgaW4gbmZzX2ZzLmg/DQo+ID4+Pg0KPiA+ Pj4gR29vZCBxdWVzdGlvbi4gIEkgZG9uJ3Qgc2VlIGFueSByZWFzb24gdGhhdCBpdCB3b3VsZCBl dmFsdWF0ZSBkaWZmZXJlbnRseSwgYnV0IEknbSBjb21waWxpbmcgdGhlIC5jb25maWcgYXR0YWNo ZWQgdG8gdGhlIGluaXRpYWwgZW1haWwgdG8gdHJ5IHRvIGZpZ3VyZSBpdCBvdXQuDQo+ID4+Pg0K PiA+Pg0KPiA+PiBMb29rcyBsaWtlIHRoZSBJU19FTkFCTEVEKCkgc3dpdGNoIGdvdCBwdXNoZWQg dG8gdGhlIG5leHQgcGF0Y2ggZm9yIFYzIGluIGluY2x1ZGUvbGludXgvbmZzX2ZzLmguICBXYW50 IG1lIHRvIHJlc2VuZCB0aGUgcGF0Y2hlcz8gIEkgdG9vayBhbm90aGVyIGxvb2sgYXQgaG93IElT X0VOQUJMRUQoKSBpcyBkZWZpbmVkLCBhbmQgaXQnbGwgd29yayBpZiBJIGRvIHRoZSBzd2l0Y2gg aW4gdGhlIHBhdGNoIGJlZm9yZSBJIHR1cm4gZXZlcnl0aGluZyBpbnRvIHNlcGFyYXRlIG1vZHVs ZXMgaWYgeW91IHdhbnQgbWUgdG8gcmVzZW5kIGV2ZXJ5dGhpbmcuDQo+ID4gDQo+ID4gUGxlYXNl IGp1c3QgbWFrZSBpdCBpbmNyZW1lbnRhbCB0byB0aGUgcGF0Y2ggc2VyaWVzIHRoYXQgaXMgYWxy ZWFkeQ0KPiA+IG1lcmdlZCBpbiB0b2RheSdzIG5mcy1mb3ItMy42Lg0KPiANCj4gRWFzeSBlbm91 Z2gsIHRoZSBwYXRjaCB0aGF0IGZpeGVzIGl0IGlzIHRoZSBsYXN0IG9uZSBpbiB0aGUgc2VyaWVz IHRoYXQgSSBzZW50IGluIHllc3RlcmRheS4NCg0KSSBkb24ndCB1bmRlcnN0YW5kLiBUaGF0IGlz IHRoZSBwYXRjaCBzZXJpZXMgdGhhdCBGZW5nZ3Vhbmcgd2FzIHRlc3RpbmcNCmFmYWlrLiBIaXMg dGVzdHMgd2VyZSBvbiANCg0KdHJlZTogICBnaXQ6Ly9naXQubGludXgtbmZzLm9yZy9wcm9qZWN0 cy90cm9uZG15L2xpbnV4LW5mcy5naXQgZGV2ZWwNCmhlYWQ6ICAgNWMxM2M5ZTFjMTVlZTJjYTlh YjJiOTUzMjI0MDAxYWY1M2Q5YmUwOQ0KDQp3aGljaCBpbmNsdWRlcyB5b3VyIHBhdGNoIHNlcmll cyBmcm9tIHllc3RlcmRheSwgbm8/DQoNCj4gPiANCj4gPiBDaGVlcnMNCj4gPiAgIFRyb25kDQo+ ID4gDQo+ID4+PiAtIEJyeWFuDQo+ID4+Pg0KPiA+Pj4+DQo+ID4+Pj4+Pg0KPiA+Pj4+Pj4NCj4g Pj4+Pj4+DQo+ID4+Pj4+Pj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPj4+Pj4+PiBG cm9tOiBGZW5nZ3VhbmcgV3UgW21haWx0bzpmZW5nZ3Vhbmcud3VAaW50ZWwuY29tXQ0KPiA+Pj4+ Pj4+IFNlbnQ6IE1vbmRheSwgSnVseSAzMCwgMjAxMiAxMDo0MyBQTQ0KPiA+Pj4+Pj4+IFRvOiBT Y2h1bWFrZXIsIEJyeWFuDQo+ID4+Pj4+Pj4gQ2M6IGtlcm5lbC1qYW5pdG9yc0B2Z2VyLmtlcm5l bC5vcmc7IE15a2xlYnVzdCwgVHJvbmQ7IGxpbnV4LQ0KPiA+Pj4+Pj4+IG5mc0B2Z2VyLmtlcm5l bC5vcmcNCj4gPj4+Pj4+PiBTdWJqZWN0OiBbbmZzOmRldmVsIDQ2LzUxXSBmcy9uZnMvd3JpdGUu YzoxNTkyOjU6IGVycm9yOiByZWRlZmluaXRpb24gb2YNCj4gPj4+Pj4+PiAnbmZzX2NvbW1pdF9p bm9kZScNCj4gPj4+Pj4+Pg0KPiA+Pj4+Pj4+IEhpIEJyeWFuLA0KPiA+Pj4+Pj4+DQo+ID4+Pj4+ Pj4gS2VybmVsIGJ1aWxkIGZhaWxlZCBvbg0KPiA+Pj4+Pj4+DQo+ID4+Pj4+Pj4gdHJlZTogICBn aXQ6Ly9naXQubGludXgtbmZzLm9yZy9wcm9qZWN0cy90cm9uZG15L2xpbnV4LW5mcy5naXQgZGV2 ZWwNCj4gPj4+Pj4+PiBoZWFkOiAgIDVjMTNjOWUxYzE1ZWUyY2E5YWIyYjk1MzIyNDAwMWFmNTNk OWJlMDkNCj4gPj4+Pj4+PiBjb21taXQ6IDFjNjA2ZmI3NGM3NThiZWFmZDk4Y2JhZDlhOTEzM2Vh ZGVlYzIzNzEgWzQ2LzUxXSBORlM6IENvbnZlcnQNCj4gPj4+Pj4+PiB2MyBpbnRvIGEgbW9kdWxl DQo+ID4+Pj4+Pj4gY29uZmlnOiBibGFja2Zpbi1CRjUzMy1FWktJVF9kZWZjb25maWcgKGF0dGFj aGVkIGFzIC5jb25maWcpDQo+ID4+Pj4+Pj4NCj4gPj4+Pj4+PiBBbGwgcmVsYXRlZCBlcnJvci93 YXJuaW5nIG1lc3NhZ2VzOg0KPiA+Pj4+Pj4+DQo+ID4+Pj4+Pj4gZnMvbmZzL3dyaXRlLmM6MTU5 Mjo1OiBlcnJvcjogcmVkZWZpbml0aW9uIG9mICduZnNfY29tbWl0X2lub2RlJw0KPiA+Pj4+Pj4+ IEluIGZpbGUgaW5jbHVkZWQgZnJvbSBmcy9uZnMvd3JpdGUuYzoxOTowOg0KPiA+Pj4+Pj4+IGlu Y2x1ZGUvbGludXgvbmZzX2ZzLmg6NTQ3OjE6IG5vdGU6IHByZXZpb3VzIGRlZmluaXRpb24gb2Yg J25mc19jb21taXRfaW5vZGUnDQo+ID4+Pj4+Pj4gd2FzIGhlcmUNCj4gPj4+Pj4+Pg0KPiA+Pj4+ Pj4+IHZpbSArMTU5MiBmcy9uZnMvd3JpdGUuYw0KPiA+Pj4+Pj4+ICAgMTU4OQkJcmV0dXJuIHN0 YXR1czsNCj4gPj4+Pj4+PiAgIDE1OTAJfQ0KPiA+Pj4+Pj4+ICAgMTU5MQ0KPiA+Pj4+Pj4+PiAx NTkyCWludCBuZnNfY29tbWl0X2lub2RlKHN0cnVjdCBpbm9kZSAqaW5vZGUsIGludCBob3cpDQo+ ID4+Pj4+Pj4gICAxNTkzCXsNCj4gPj4+Pj4+PiAgIDE1OTQJCUxJU1RfSEVBRChoZWFkKTsNCj4g Pj4+Pj4+PiAgIDE1OTUJCXN0cnVjdCBuZnNfY29tbWl0X2luZm8gY2luZm87DQo+ID4+Pj4+Pj4N Cj4gPj4+Pj4+PiAtLS0NCj4gPj4+Pj4+PiAwLURBWSBrZXJuZWwgYnVpbGQgdGVzdGluZyBiYWNr ZW5kICAgICAgICAgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50cmUNCj4gPj4+Pj4+PiBGZW5n Z3VhbmcgV3UgPHdmZ0BsaW51eC5pbnRlbC5jb20+ICAgICAgICAgICAgICAgICAgICAgSW50ZWwg Q29ycG9yYXRpb24NCj4gPj4+Pj4NCj4gPj4+Pg0KPiA+Pj4NCj4gPj4NCj4gPiANCj4gDQoNCg=

#13 lore raw
Quoted 21 lines · Trond
Quoted 20 lines · Bryan Schumaker
Quoted 19 lines · Trond
Quoted 17 lines · Bryan Schumaker
Quoted 5 lines · Bryan Schumaker
Quoted 4 lines · Trond
Quoted 3 lines · Bryan Schumaker
Quoted 2 lines · Trond

Bryan,

Quoted 9 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line

Why did you switch to using IS_ENABLED in the first place, and why wasn't that put in a separate patch?

IS_ENABLED() will check for CONFIG_NFS_V*_MODULE, last I checked the defined() macro doesn't. Putting this into a separate patch makes the change non-bisectable since gcc will be checking against CONFIG_NFS_V3 but CONFIG_NFS_V3_MODULE is set. Should I have changed the CONFIG_ variables instead of using IS_ENABLED()?

Why is it evaluating differently in the include file vs. the .c file? Are we missing an include in nfs_fs.h?

Good question. I don't see any reason that it would evaluate differently, but I'm compiling the .config attached to the initial email to try to figure it out.

Looks like the IS_ENABLED() switch got pushed to the next patch for V3 in include/linux/nfs_fs.h. Want me to resend the patches? I took another look at how IS_ENABLED() is defined, and it'll work if I do the switch in the patch before I turn everything into separate modules if you want me to resend everything.

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

Please just make it incremental to the patch series that is already merged in today's nfs-for-3.6.

Easy enough, the patch that fixes it is the last one in the series that I sent in yesterday.

I don't understand. That is the patch series that Fengguang was testing afaik. His tests were on

I'm guessing he's checking each patch individually and it notified about the first bad one. Here is what happened:

In patch 9 (Convert v3 into a module) one of my calls to IS_ENABLED() somehow got pushed into patch 10. Here is the bit from patch 10 that fixes the problem:

include/linux/nfs_fs.h +1 -1
index 4b6043c..2889877 100644
@@ -538,7 +538,7 @@ extern void nfs_writeback_done(struct rpc_task *, struct nfs_write_data *);
 extern int nfs_wb_all(struct inode *inode);
 extern int nfs_wb_page(struct inode *inode, struct page* page);
 extern int nfs_wb_page_cancel(struct inode *inode, struct page* page);
-#if defined(CONFIG_NFS_V3) || defined(CONFIG_NFS_V4)
+#if IS_ENABLED(CONFIG_NFS_V3) || IS_ENABLED(CONFIG_NFS_V4)
 extern int  nfs_commit_inode(struct inode *, int);
 extern struct nfs_commit_data *nfs_commitdata_alloc(void);
 extern void nfs_commit_free(struct nfs_commit_data *data);

- Bryan

Quoted 61 lines
tree:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git devel
head:   5c13c9e1c15ee2ca9ab2b953224001af53d9be09

which includes your patch series from yesterday, no?

Quoted 54 lines
Quoted 53 lines

Cheers
Trond

Quoted 48 lines
Quoted 47 lines

- Bryan

Quoted 44 lines
Quoted 43 lines
Quoted 42 lines
Quoted 42 lines

-----Original Message-----
From: Fengguang Wu [mailto:[email protected]]
Sent: Monday, July 30, 2012 10:43 PM
To: Schumaker, Bryan
Cc: [email protected]; Myklebust, Trond; linux- [email protected]
Subject: [nfs:devel 46/51] fs/nfs/write.c:1592:5: error: redefinition of 'nfs_commit_inode'

Hi Bryan,

Kernel build failed on

tree:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git devel
head:   5c13c9e1c15ee2ca9ab2b953224001af53d9be09
commit: 1c606fb74c758beafd98cbad9a9133eadeec2371 [46/51] NFS: Convert

v3 into a module
config: blackfin-BF533-EZKIT_defconfig (attached as .config)

All related error/warning messages:

fs/nfs/write.c:1592:5: error: redefinition of 'nfs_commit_inode' In file included from fs/nfs/write.c:19:0:
include/linux/nfs_fs.h:547:1: note: previous definition of 'nfs_commit_inode' was here

vim +1592 fs/nfs/write.c
1589 return status;
1590 }
1591

Quoted 1 line

1592 int nfs_commit_inode(struct inode *inode, int how)

1593 {
1594 LIST_HEAD(head);
1595 struct nfs_commit_info cinfo;

---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <[email protected]> Intel Corporation

#14 lore raw
In reply to Myklebust, Trond
Quoted 9 lines
Quoted 1 line

Easy enough, the patch that fixes it is the last one in the series that I sent in yesterday.

I don't understand. That is the patch series that Fengguang was testing afaik. His tests were on

tree:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git devel
head:   5c13c9e1c15ee2ca9ab2b953224001af53d9be09

which includes your patch series from yesterday, no?

Trond, I typically do commit-by-commit tests and will complain if *any* point of the tree is not bisect-able. A fix at the HEAD won't stop the email notification for a defect in the middle point..

On the other hand, I do maintain a list of non-rebaseable tree/branches, on which the HEAD commit will be tested first, and only if any problems are found, go back to find out the first bad commit.

If you prefer the latter behavior, I can add your tree or any branch of it to the non-rebaseable list.

Thanks,
Fengguang

#10 lore raw
In reply to Bryan Schumaker
Quoted 4 lines · Bryan Schumaker

I've got one at:
git://git.linux-nfs.org/projects/bjschuma/linux-nfs.git. I don't always do a good job keeping it up-to-date, but I can try to get into the habit of putting my patches there before submitting them.

Tree added :) By default I'll test every branch of the monitored trees. You may ask me to permanently blacklist/whitelist some of your branches. Or, if a topic branch is currently in heavy development and will become testable eventually, you may temporarily carry a line

Dont-Auto-Build

in any of the branch's commits (in the changelog). Then the script will skip that branch automatically.

Thanks,
Fengguang

Quoted 10 lines · Fengguang Wu
Quoted 9 lines

Bryan,

Do you have a git tree that I can run tests upon? That would help prevent problems from sneaking into Trond's tree, and hence mess up the maintainer's tree and waste everyone's time.

Thanks,
Fengguang

#11 lore raw
Quoted 11 lines · Fengguang Wu
Quoted 4 lines · Bryan Schumaker

I've got one at:
git://git.linux-nfs.org/projects/bjschuma/linux-nfs.git. I don't always do a good job keeping it up-to-date, but I can try to get into the habit of putting my patches there before submitting them.

Tree added :) By default I'll test every branch of the monitored trees. You may ask me to permanently blacklist/whitelist some of your branches. Or, if a topic branch is currently in heavy development and will become testable eventually, you may temporarily carry a line

Quoted 4 lines

Dont-Auto-Build

in any of the branch's commits (in the changelog). Then the script will skip that branch automatically.

Sounds good. I'll update it as I work on things!

- Bryan

Quoted 14 lines

Thanks,
Fengguang

Quoted 10 lines · Fengguang Wu
Quoted 9 lines

Bryan,

Do you have a git tree that I can run tests upon? That would help prevent problems from sneaking into Trond's tree, and hence mess up the maintainer's tree and waste everyone's time.

Thanks,
Fengguang

#15 lore raw
In reply to Fengguang Wu

T24gVHVlLCAyMDEyLTA3LTMxIGF0IDIyOjEwICswODAwLCBGZW5nZ3VhbmcgV3Ugd3JvdGU6DQo+ ID4gPiBFYXN5IGVub3VnaCwgdGhlIHBhdGNoIHRoYXQgZml4ZXMgaXQgaXMgdGhlIGxhc3Qgb25l IGluIHRoZSBzZXJpZXMgdGhhdCBJIHNlbnQgaW4geWVzdGVyZGF5Lg0KPiA+IA0KPiA+IEkgZG9u J3QgdW5kZXJzdGFuZC4gVGhhdCBpcyB0aGUgcGF0Y2ggc2VyaWVzIHRoYXQgRmVuZ2d1YW5nIHdh cyB0ZXN0aW5nDQo+ID4gYWZhaWsuIEhpcyB0ZXN0cyB3ZXJlIG9uIA0KPiA+IA0KPiA+IHRyZWU6 ICAgZ2l0Oi8vZ2l0LmxpbnV4LW5mcy5vcmcvcHJvamVjdHMvdHJvbmRteS9saW51eC1uZnMuZ2l0 IGRldmVsDQo+ID4gaGVhZDogICA1YzEzYzllMWMxNWVlMmNhOWFiMmI5NTMyMjQwMDFhZjUzZDli ZTA5DQo+ID4gDQo+ID4gd2hpY2ggaW5jbHVkZXMgeW91ciBwYXRjaCBzZXJpZXMgZnJvbSB5ZXN0 ZXJkYXksIG5vPw0KPiANCj4gVHJvbmQsIEkgdHlwaWNhbGx5IGRvIGNvbW1pdC1ieS1jb21taXQg dGVzdHMgYW5kIHdpbGwgY29tcGxhaW4gaWYNCj4gKmFueSogcG9pbnQgb2YgdGhlIHRyZWUgaXMg bm90IGJpc2VjdC1hYmxlLiBBIGZpeCBhdCB0aGUgSEVBRCB3b24ndA0KPiBzdG9wIHRoZSBlbWFp bCBub3RpZmljYXRpb24gZm9yIGEgZGVmZWN0IGluIHRoZSBtaWRkbGUgcG9pbnQuLg0KPiANCj4g T24gdGhlIG90aGVyIGhhbmQsIEkgZG8gbWFpbnRhaW4gYSBsaXN0IG9mIG5vbi1yZWJhc2VhYmxl DQo+IHRyZWUvYnJhbmNoZXMsIG9uIHdoaWNoIHRoZSBIRUFEIGNvbW1pdCB3aWxsIGJlIHRlc3Rl ZCBmaXJzdCwgYW5kIG9ubHkNCj4gaWYgYW55IHByb2JsZW1zIGFyZSBmb3VuZCwgZ28gYmFjayB0 byBmaW5kIG91dCB0aGUgZmlyc3QgYmFkIGNvbW1pdC4NCj4gDQo+IElmIHlvdSBwcmVmZXIgdGhl IGxhdHRlciBiZWhhdmlvciwgSSBjYW4gYWRkIHlvdXIgdHJlZSBvciBhbnkgYnJhbmNoDQo+IG9m IGl0IHRvIHRoZSBub24tcmViYXNlYWJsZSBsaXN0Lg0KDQpBaC4uLiBJIHNlZSBub3cuLi4gU28g eW91IGFyZSBzYXlpbmcgdGhhdCB0aGUgZW5kIHJlc3VsdCBpcyBpbmRlZWQNCmNvcnJlY3QsIGJ1 dCB0aGUgYmlzZWN0aW9uIGZhaWxzLi4uDQoNClRoZSAnZGV2ZWwnIHRyZWUgaXMgdXN1YWxseSBh IG1peHR1cmUgb2YgcmViYXNlYWJsZSBhbmQgbm9uLXJlYmFzZWFibGU6DQphbnl0aGluZyB0aGF0 IGlzIGFscmVhZHkgYmVlbiBjb21taXR0ZWQgdG8gdGhlIG5mcy1mb3ItbmV4dCBicmFuY2ggaXMN Cm5vbi1yZWJhc2VhYmxlLCB3aGlsZSB0aGUgcmVzdCB1c3VhbGx5IGlzLi4uDQoNCkNoZWVycw0K ICBUcm9uZA0K

#16 lore raw
Quoted 19 lines · Trond Myklebust
Quoted 18 lines · Fengguang Wu
Quoted 9 lines
Quoted 1 line

Easy enough, the patch that fixes it is the last one in the series that I sent in yesterday.

I don't understand. That is the patch series that Fengguang was testing afaik. His tests were on

tree:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git devel
head:   5c13c9e1c15ee2ca9ab2b953224001af53d9be09

which includes your patch series from yesterday, no?

Trond, I typically do commit-by-commit tests and will complain if *any* point of the tree is not bisect-able. A fix at the HEAD won't stop the email notification for a defect in the middle point..

On the other hand, I do maintain a list of non-rebaseable tree/branches, on which the HEAD commit will be tested first, and only if any problems are found, go back to find out the first bad commit.

Quoted 5 lines
Quoted 2 lines

If you prefer the latter behavior, I can add your tree or any branch of it to the non-rebaseable list.

Ah... I see now... So you are saying that the end result is indeed correct, but the bisection fails...

Sorry for the confusions!

Quoted 3 lines

The 'devel' tree is usually a mixture of rebaseable and non-rebaseable:
anything that is already been committed to the nfs-for-next branch is non-rebaseable, while the rest usually is...

Got it. I'll mark 'nfs-for-next' and 'devel' as non-rebaseable, and do thorough bisect tests on the other branches.

Thanks,
Fengguang