Skip to contentSkip to conversation

net:appletalk:ddp:fixed coding style issue again relating to

PATCH Jeffrin Jose 2 participants 2 messages Aug 7, 2012

lore
Share & tools
lore
#0 lore raw

/ Is putting "rc = put_user(amount, (int __user *)argp);" on the same / indentation level as "amount = skb->len - sizeof(struct ddpehdr);" / really what you want to do?

No. I was trying to place those lines at one
indentation back from their current position.

Thanks

/Jeffrin.

Signature · 4 lines
software engineer
Bohr Lab
department of computer science
Rajagiri school of engineering and technology.
#1 lore raw
Quoted 6 lines · Jeffrin Jose

/ Is putting "rc = put_user(amount, (int __user *)argp);" on the same / indentation level as "amount = skb->len - sizeof(struct ddpehdr);" / really what you want to do?

No. I was trying to place those lines at one
indentation back from their current position.

If you are using checkpatch as a guide, run "./scripts/checkpatch.pl -f --strict net/appletalk/ddp.c" after you patch it and also correct any problems found in the area you want to update too.

A second option is to use emacs with the proper linux style indentation.

(See: Documentation/CodingStyle, Chapter 9: You've made a mess of it)

Another option is not to patch the file at all.

Also, don't submit multiple patches, resubmit 1 single patch with all the appropriate corrections.