block: avoid unnecessary plug should_sort test.

PATCH In review Jianpeng Ma 1 participant 1 message Aug 10, 2012 Block layer

Share & tools

Jianpeng Ma

author

2012-08-10 11:44 UTC #0 lore raw

PATCH 1/3 block: avoid unnecessary plug should_sort test.

If request_count >= BLK_MAX_REQUEST_COUNT,then it will exec blk_flush_plug_list which plug all request.So no need to do plug->should_sort test.

Signed-off-by Jianpeng Ma <[email protected]>

---
 block/blk-core.c |    9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

block/blk-core.c +4 -5

index 4b4dbdf..7a3abc6 100644
@@ -1514,17 +1514,16 @@ get_rq:
 		if (list_empty(&plug->list))
 			trace_block_plug(q);
 		else {
-			if (!plug->should_sort) {
+			if (request_count >= BLK_MAX_REQUEST_COUNT) {
+				blk_flush_plug_list(plug, false);
+				trace_block_plug(q);
+			} else if (!plug->should_sort) {
 				struct request *__rq;
 
 				__rq = list_entry_rq(plug->list.prev);
 				if (__rq->q != q)
 					plug->should_sort = 1;
 			}
-			if (request_count >= BLK_MAX_REQUEST_COUNT) {
-				blk_flush_plug_list(plug, false);
-				trace_block_plug(q);
-			}
 		}
 		list_add_tail(&req->queuelist, &plug->list);
 		drive_stat_acct(req, 1);

Signature · 2 lines

1.7.9.5
�翳簕.n�+壏煯壄�+%娝�遍荻w�簕.n�+壏{炳G珴�妠ay�蕠跈�,jf＂穐殢飦�戧鐉_璁(殠娸"濟�m���G珴�⒏?櫒璀�&ｘ忈秈O曟瑉窔v豝�m����鹅�⒏?朓�