Skip to contentSkip to conversation

block: Remove unnecessary requests sort.

PATCH In review Jianpeng Ma 1 participant 1 message Aug 10, 2012 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 3/3 block: Remove unnecessary requests sort.

When adding request to plug,it already sort.So there is not unnecessary.

---
 block/blk-core.c |   12 ------------
 1 file changed, 12 deletions(-)
block/blk-core.c +0 -12
index 034f186..9dbdef6 100644
@@ -2879,13 +2879,6 @@ void blk_start_plug(struct blk_plug *plug)
 }
 EXPORT_SYMBOL(blk_start_plug);
 
-static int plug_rq_cmp(void *priv, struct list_head *a, struct list_head *b)
-{
-	struct request *rqa = container_of(a, struct request, queuelist);
-	struct request *rqb = container_of(b, struct request, queuelist);
-
-	return !(rqa->q <= rqb->q);
-}
 
 /*
  * If 'from_schedule' is true, then postpone the dispatch of requests
@@ -2980,11 +2973,6 @@ void blk_flush_plug_list(struct blk_plug *plug, bool from_schedule)
 
 	list_splice_init(&plug->list, &list);
 
-	if (plug->should_sort) {
-		list_sort(NULL, &list, plug_rq_cmp);
-		plug->should_sort = 0;
-	}
-
 	q = NULL;
 	depth = 0;
 
Signature · 2 lines
1.7.9.5
�翳簕.n�+壏煯壄�+%娝�遍荻w�簕.n�+壏{炳G珴�妠ay�蕠跈�,jf"穐殢飦�戧鐉_璁(殠娸"濟�m���G珴�⒏?櫒璀�&x忈秈O曟瑉窔v豝�m����鹅�⒏?朓�