s2255drv: remove V4L2_FL_LOCK_ALL_FOPS
Hello Hans Verkuil,
This is a semi-automatic email about new static checker warnings.
The patch 0e1f0edfdd25: "[media] s2255drv: remove V4L2_FL_LOCK_ALL_FOPS" from Jun 24, 2012, leads to the following Smatch complaint:
drivers/media/video/s2255drv.c:1867 s2255_mmap_v4l()
warn: variable dereferenced before check 'fh' (see line 1864)
drivers/media/video/s2255drv.c
1863 struct s2255_fh *fh = file->private_data;
1864 struct s2255_dev *dev = fh->dev;
^^^^^^^New dereference.
1865 int ret;
1866
1867 if (!fh)
^^^
Old check.
1868 return -ENODEV; 1869 dprintk(4, "%s, vma=0x%08lx\n", __func__, (unsigned long)vma);
regards,
dan carpenter