mvsas: fix a && vs & bug
Subsystems (2)
PATCH 1/1 mvsas: fix a && vs & bug
The "1 << (slot_idx % 32)" condition is always true. The intent was to test a bit field here using bitwise AND. We do the test correctly a few lines later in the do while loop.
Signed-off-by Dan Carpenter <[email protected]>
---
Static checker fix. Untested. Would apply to the -stable kernel.
drivers/scsi/mvsas/mv_94xx.c +1 -1
@@ -622,7 +622,7 @@ static void mvs_94xx_command_active(struct mvs_info *mvi, u32 slot_idx) {u32 tmp; tmp =mvs_cr32 (mvi,MVS_COMMAND_ACTIVE +(slot_idx >>3 )); -if (tmp &&1 << (slot_idx %32 )) { +if (tmp &1 << (slot_idx %32 )) {mv_printk ("command active %08X, slot [%x].\n" , tmp, slot_idx);mvs_cw32 (mvi,MVS_COMMAND_ACTIVE + (slot_idx >>3 ),1 << (slot_idx %32 ));
Quoted 5 lines · Dan Carpenter
The "1 << (
slot_idx% 32)" condition is always true. The intent was to test a bit field here using bitwise AND. We do the test correctly a few lines later in the do while loop.Signed-off-by Dan Carpenter <[email protected]>
Acked-by Jeff Garzik <[email protected]>