staging: comedi: cb_pcimdda: fix bug in call to subdev_8255_cleanup
PATCH 30/35 staging: comedi: cb_pcimdda: fix bug in call to subdev_8255_cleanup
The attach function only allocated 2 subdevices, an analog output sundevice (index 0) and the 8255 dio subdevice (index 1). The detach function is passing the wrong subdevice (index 2) to the subdev_8255_cleanup function which will result in a bug when it tries to do the kfree(s->private).
Signed-off-by H Hartley Sweeten <[email protected]>
Cc Ian Abbott <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
--- drivers/staging/comedi/drivers/cb_pcimdda.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/comedi/drivers/cb_pcimdda.c +1 -1
@@ -257,7 +257,7 @@ static void cb_pcimdda_detach(struct comedi_device *dev)struct pci_dev *pcidev =comedi_to_pci_dev (dev);if (dev->subdevices) -subdev_8255_cleanup (dev, dev->subdevices +2 ); +subdev_8255_cleanup (dev, dev->subdevices +1 );if (pcidev) {if (dev->iobase)comedi_pci_disable (pcidev);
Signature · 1 line
1.7.11