staging: comedi: adv_pci_dio: fix bug in 'detach'

PATCH In review H Hartley Sweeten 1 participant 1 message Aug 18, 2012 Staging

Share & tools

H Hartley Sweeten

author

2012-08-18 01:21 UTC #0 lore raw

PATCH 20/20 staging: comedi: adv_pci_dio: fix bug in 'detach'

The 'attach' function can fail between when the devpriv and the comedi subdevices are allocated. If it does the 'detach' will try to access unallocated memory when it goes thru the subdevices.

Signed-off-by H Hartley Sweeten <[email protected]>

Cc Ian Abbott <[email protected]>

Cc Greg Kroah-Hartman <[email protected]>

---
 drivers/staging/comedi/drivers/adv_pci_dio.c | 2 ++
 1 file changed, 2 insertions(+)

drivers/staging/comedi/drivers/adv_pci_dio.c +2 -0

index 4da0e7b..a4c1b13 100644
@@ -1184,6 +1184,8 @@ static void pci_dio_detach(struct comedi_device *dev)
 	if (devpriv) {
 		if (devpriv->valid)
 			pci_dio_reset(dev);
+	}
+	if (dev->subdevices) {
 		for (i = 0; i < dev->n_subdevices; i++) {
 			s = dev->subdevices + i;
 			if (s->type == COMEDI_SUBD_DIO)

Signature · 1 line

1.7.11