Skip to contentSkip to conversation

xfstests: Replace lstat64 with cat in test 120

PATCH New [email protected] 1 participant 1 message Aug 23, 2012 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH v2 1/1 xfstests: Replace lstat64 with cat in test 120

Test 120 only copies src/lstat64 to $SCRATCH_MNT without verifying it is a standalone binary. If xfstests is compiled with a version of libtools that creates the wrapper as described above, then only the wrapper is copied to $SCRATCH_MNT and the wrapper will fail to find $SCRATCH_MNT/.libs/lstat64.

~/xfstests # diff 120.out 120.out.bad
/mnt/scratch/lstat64: error: `/mnt/scratch/.libs/lstat64' does not exist This script is just a wrapper for lstat64.
See the libtool documentation for more information.

This patch copies /bin/cat (which is readily availible on unix systems) to $SCRATCH_MNT instead of src/lstat64.

---
 120 |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
120 +4 -4
Index: b/120
===================================================================
@@ -68,12 +68,12 @@ fi
 
 #executable file
 echo "*** copying file ***"
-cp src/lstat64 $SCRATCH_MNT
-src/lstat64 $SCRATCH_MNT/lstat64 >$tmp.out
+cp /bin/cat $SCRATCH_MNT
+src/lstat64 $SCRATCH_MNT/cat >$tmp.out
 sleep 5
 echo "*** executing file ***"
-$SCRATCH_MNT/lstat64 $SCRATCH_MNT/lstat64 >/dev/null
-_compare_access_times $SCRATCH_MNT/lstat64 "executing file"
+$SCRATCH_MNT/cat $SCRATCH_MNT/cat >/dev/null
+_compare_access_times $SCRATCH_MNT/cat "executing file"
 
 #reading file
 echo "*** creating file ***"

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs