Skip to contentSkip to conversation

Support Xen versions up to xen-4.1

PATCH In review Petr Tesarik 3 participants 5 messages Aug 24, 2012 – Aug 28, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v3 cover Support Xen versions up to xen-4.1

Hello everybody,

this is version 3 of my patch set. I'm very much indebted to Norbert Trapp for his extensive testing of my previous patch set, which revealed that Xen hypervisor static data was not kept with the previous version of the patch set.

I could also add the performance improvements, but I'm afraid it would make for an incremental patch, so let's wait until the filtering is finally right.

I have re-tested this patch set with the same result as v2:

- Xen-3.2.3 - WORKS
- Xen-4.0.1 - WORKS (only with --xen-syms)
- Xen-4.0.2 - WORKS
- Xen-4.1.2 - WORKS

Filtering free pages (-d16 and above) doesn't work (even after I manually provided the missing "max_pfn" symbol), but that seems unrelated, so I'm going to address it in a subsequent patch set.

Norbert, if you test these patches, please send your comments to the mailing list.

Atsushi-san, if the patch set passes Norbert's testing, what else do you need to accept the changes in upstream?

Regards,
Petr Tesarik
SUSE Linux

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#1 lore raw

Hello Petr,

Quoted 6 lines · On Fri, 24 Aug 2012 17:41:27 +0200 Petr Tesařík <[email protected]> wrote:

Hello everybody,

this is version 3 of my patch set. I'm very much indebted to Norbert Trapp for his extensive testing of my previous patch set, which revealed that Xen hypervisor static data was not kept with the previous version of the patch set.

Thank you for your hard work, Petr and Norbert.

Quoted 16 lines

I could also add the performance improvements, but I'm afraid it would make for an incremental patch, so let's wait until the filtering is finally right.

I have re-tested this patch set with the same result as v2:

- Xen-3.2.3 - WORKS
- Xen-4.0.1 - WORKS (only with --xen-syms)
- Xen-4.0.2 - WORKS
- Xen-4.1.2 - WORKS

Filtering free pages (-d16 and above) doesn't work (even after I manually provided the missing "max_pfn" symbol), but that seems unrelated, so I'm going to address it in a subsequent patch set.

Quoted 5 lines

Norbert, if you test these patches, please send your comments to the mailing list.

Atsushi-san, if the patch set passes Norbert's testing, what else do you need to accept the changes in upstream?

I'll review your v3 patch set as best I can.
If I can't see any problem, then I'll merge them into v1.5.1. Now, I plan to release v1.5.1 before the end of September.

Thanks
Atsushi Kumagai

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#2 lore raw
In reply to Petr Tesarik

Hello Petr,

Quoted 7 lines

-----Original Message-----
From: Petr Tesarik [mailto:[email protected]]
Sent: Friday, August 24, 2012 5:46 PM
To: [email protected]
Cc: Trapp, Norbert
Subject: [PATCHv3 0/9] Support Xen versions up to xen-4.1

Quoted 6 lines

Hello everybody,

this is version 3 of my patch set. I'm very much indebted to Norbert Trapp for his extensive testing of my previous patch set, which revealed that Xen hypervisor static data was not kept with the previous version of the patch set.

Thank you, Petr. I also admire your patches for all sorts of versions.

Quoted 4 lines

I could also add the performance improvements, but I'm afraid it would make for an incremental patch, so let's wait until the filtering is finally right.

Alright to abandon the performance improvements for the time being but I would vote for adding the 1GB page recognition. That is:
...(pgd_entry & _PAGE_PSE)... in kvto_xen_x86_64. I think you would need a huge amount of memory to recognize this problem.

With kind regards,
Norbert Trapp

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#3 lore raw

Dne Po 27. srpna 2012 18:19:20 Trapp, Norbert napsal(a):

Quoted 18 lines

Hello Petr,

Quoted 7 lines

-----Original Message-----
From: Petr Tesarik [mailto:[email protected]]
Sent: Friday, August 24, 2012 5:46 PM
To: [email protected]
Cc: Trapp, Norbert
Subject: [PATCHv3 0/9] Support Xen versions up to xen-4.1

Quoted 6 lines

Hello everybody,

this is version 3 of my patch set. I'm very much indebted to Norbert Trapp for his extensive testing of my previous patch set, which revealed that Xen hypervisor static data was not kept with the previous version of the patch set.

Thank you, Petr. I also admire your patches for all sorts of versions.

Quoted 8 lines
Quoted 3 lines

I could also add the performance improvements, but I'm afraid it would make for an incremental patch, so let's wait until the filtering is finally right.

Alright to abandon the performance improvements for the time being but I would vote for adding the 1GB page recognition. That is:
...(pgd_entry & _PAGE_PSE)... in kvto_xen_x86_64. I think you would need a huge amount of memory to recognize this problem.

It would still be good to get it into the next release. So, if we finally got everything right here, I'll be posting the improvements right away.

Petr Tesarik
SUSE Linux

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#4 lore raw
In reply to Trapp, Norbert

Dne Po 27. srpna 2012 18:19:20 Trapp, Norbert napsal(a):

Quoted 9 lines

[...]

Quoted 3 lines

I could also add the performance improvements, but I'm afraid it would make for an incremental patch, so let's wait until the filtering is finally right.

Alright to abandon the performance improvements for the time being but I would vote for adding the 1GB page recognition. That is:
...(pgd_entry & _PAGE_PSE)... in kvto_xen_x86_64. I think you would need a huge amount of memory to recognize this problem.

Oh! I missed the part that adds support for 1G pages. This is not merely performance improvement, but a bugfix - the routine is not able to translate 1G mappings without the change.

The thing with 1G pages is that they are not available on all platforms (AFAIK only AMD has them).

Anyway, it should be two patches, in fact. Please stay tuned.

Petr Tesarik
SUSE Linux

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec