Skip to contentSkip to conversation

3270 console: Drop unused spinlock

PATCH Martin Schwidefsky 1 participant 1 message Sep 6, 2012 1 message not in the archive s390

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 17 lines · On Thu, 6 Sep 2012 09:55:56 +0200 Jean Delvare <[email protected]> wrote:

I was checking why this spinlock was never initialized, but it turns out it's not used anywhere, so we can drop it.

Cc Martin Schwidefsky <[email protected]>
Cc Heiko Carstens <[email protected]>

---
I can't even build-test this.

 drivers/s390/char/con3270.c |    1 -
 1 file changed, 1 deletion(-)

drivers/s390/char/con3270.c static struct raw3270_fn con3270_fn; · line 40

Quoted 7 lines
drivers/s390/char/con3270.c +0 -1
@@ -35,7 +35,6 @@ static struct raw3270_fn con3270_fn;
  */
 struct con3270 {
 	struct raw3270_view view;
-	spinlock_t lock;
 	struct list_head freemem;	/* list of free memory for strings. */
 
 	/* Output stuff. */

That is true, the code always uses the view->lock. I'll add this to the queue. Thanks.

Signature · 4 lines
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.