Skip to contentSkip to conversation

About function __create_file in debugfs

DISCUSSION Jianpeng Ma 2 participants 3 messages Sep 8, 2012 – Sep 10, 2012 Driver core

lore
Share & tools
lore
#0 lore raw

Hi:
At present,i used blktrace to trace block io.But i always met error, the message like:

Quoted 10 lines

BLKTRACESETUP(2) /dev/sdc failed: 2/No such file or directory
Thread 0 failed open /sys/kernel/debug/block/(null)/trace0: 2/No such file or directory Thread 2 failed open /sys/kernel/debug/block/(null)/trace2: 2/No such file or directory Thread 3 failed open /sys/kernel/debug/block/(null)/trace3: 2/No such file or directory

Thread 1 failed open /sys/kernel/debug/block/(null)/trace1: 2/No such file or directory FAILED to start thread on CPU 0: 1/Operation not permitted
FAILED to start thread on CPU 1: 1/Operation not permitted
FAILED to start thread on CPU 2: 1/Operation not permitted
FAILED to start thread on CPU 3: 1/Operation not permitted

But those isn't important. I add some message in kernel and found the reason is inode already existed. But the function __create_file dosen't return correctly errno.So blktrace tool can't print correctly message. I think func __create_file should return correctly message(ERR_PTR(error)) not NULL. �翳簕.n�+壏煯壄�+%娝�遍荻w�簕.n�+壏{炳G珴�妠ay�蕠跈�,jf"穐殢飦�戧鐉_璁(殠娸"濟�m���G珴�⒏?櫒璀�&x忈秈O曟瑉窔v豝�m��� �鹅�⒏?朓�

maintainer
#1 lore raw
Quoted 13 lines · Jianpeng Ma

Hi:
At present,i used blktrace to trace block io.But i always met error, the message like:

Quoted 10 lines

BLKTRACESETUP(2) /dev/sdc failed: 2/No such file or directory
Thread 0 failed open /sys/kernel/debug/block/(null)/trace0: 2/No such file or directory Thread 2 failed open /sys/kernel/debug/block/(null)/trace2: 2/No such file or directory Thread 3 failed open /sys/kernel/debug/block/(null)/trace3: 2/No such file or directory

Thread 1 failed open /sys/kernel/debug/block/(null)/trace1: 2/No such file or directory FAILED to start thread on CPU 0: 1/Operation not permitted
FAILED to start thread on CPU 1: 1/Operation not permitted
FAILED to start thread on CPU 2: 1/Operation not permitted
FAILED to start thread on CPU 3: 1/Operation not permitted

Quoted 3 lines

But those isn't important. I add some message in kernel and found the reason is inode already existed. But the function __create_file dosen't return correctly errno.So blktrace tool can't print correctly message. I think func __create_file should return correctly message(ERR_PTR(error)) not NULL.

Patches are always welcome :)

greg k-h

#2 lore raw

On 2012-09-08 23:25 gregkh <[email protected]> Wrote:

Quoted 14 lines · Jianpeng Ma
Quoted 13 lines

Hi:
At present,i used blktrace to trace block io.But i always met error, the message like:

Quoted 10 lines

BLKTRACESETUP(2) /dev/sdc failed: 2/No such file or directory
Thread 0 failed open /sys/kernel/debug/block/(null)/trace0: 2/No such file or directory Thread 2 failed open /sys/kernel/debug/block/(null)/trace2: 2/No such file or directory Thread 3 failed open /sys/kernel/debug/block/(null)/trace3: 2/No such file or directory

Thread 1 failed open /sys/kernel/debug/block/(null)/trace1: 2/No such file or directory FAILED to start thread on CPU 0: 1/Operation not permitted
FAILED to start thread on CPU 1: 1/Operation not permitted
FAILED to start thread on CPU 2: 1/Operation not permitted
FAILED to start thread on CPU 3: 1/Operation not permitted

Quoted 7 lines
Quoted 3 lines

But those isn't important. I add some message in kernel and found the reason is inode already existed. But the function __create_file dosen't return correctly errno.So blktrace tool can't print correctly message. I think func __create_file should return correctly message(ERR_PTR(error)) not NULL.

Patches are always welcome :)

greg k-h

Thanks, the patch is:
Func debugfs_create_symlink/debugfs_create_file/debugfs_create_dir, it only return NULL when error counted. We should correctly error info instead of.

---
 fs/debugfs/inode.c |   10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
fs/debugfs/inode.c +6 -4
index 4733eab..1e94350 100644
@@ -302,8 +302,10 @@ struct dentry *__create_file(const char *name, umode_t mode,
 
 	error = simple_pin_fs(&debug_fs_type, &debugfs_mount,
 			      &debugfs_mount_count);
-	if (error)
+	if (error) {
+		dentry = ERR_PTR(error);
 		goto exit;
+	}
 
 	/* If the parent is not specified, we create it in the root.
 	 * We need the root dentry to do this, which is in the super 
@@ -337,7 +339,7 @@ struct dentry *__create_file(const char *name, umode_t mode,
 	mutex_unlock(&parent->d_inode->i_mutex);
 
 	if (error) {
-		dentry = NULL;
+		dentry = ERR_PTR(error);
 		simple_release_fs(&debugfs_mount, &debugfs_mount_count);
 	}
 exit:
@@ -442,10 +444,10 @@ struct dentry *debugfs_create_symlink(const char *name, struct dentry *parent,
 
 	link = kstrdup(target, GFP_KERNEL);
 	if (!link)
-		return NULL;
+		return ERR_PTR(-ENOMEM);
 
 	result = __create_file(name, S_IFLNK | S_IRWXUGO, parent, link, NULL);
-	if (!result)
+	if (IS_ERR_OR_NULL(result))
 		kfree(link);
 	return result;
 }
Signature · 6 lines
1.7.9.5


But i searched kernel-code and found at-least 100 places used those code.
How about those code? Am i correct those or not?
Thanks!�翳簕.n�+壏煯壄�+%娝�遍荻w�簕.n�+壏{炳G珴�妠ay�蕠跈�,jf"穐殢飦�戧鐉_璁(殠娸"濟�m���G珴�⒏?櫒璀�&x忈秈O曟瑉窔v豝�m����鹅�⒏?朓�