Skip to contentSkip to conversation

virtio-spec: serial: english tweak

PATCH In review Michael S. Tsirkin 4 participants 5 messages Sep 9, 2012 – Jan 3, 2013 virtio core

lore
Share & tools
lore

Michael S. Tsirkin

author maintainer
#0 lore raw

PATCH 1/1 virtio-spec: serial: english tweak

"A number of virtqueues are created" seems clearer than "the number of virtqueues": it's virtqueues that are created not the number.

---

I'm not a native english speaker but the below seems correct to me. Rusty?

 virtio-spec.lyx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
virtio-spec.lyx +1 -1
index d9626a9..a29315c 100644
@@ -6406,7 +6406,7 @@ If the VIRTIO_CONSOLE_F_MULTIPORT feature is negotiated, the driver can
  spawn multiple ports, not all of which may be attached to a console.
  Some could be generic ports.
  In this case, the control virtqueues are enabled and according to the max_nr_po
-rts configuration-space value, the appropriate number of virtqueues are
+rts configuration-space value, an appropriate number of virtqueues are
  created.
  A control message indicating the driver is ready is sent to the host.
  The host can then send control messages for adding new ports to the device.
Signature · 1 line
MST
author maintainer
#2 lore raw
In reply to Michael S. Tsirkin
Quoted 5 lines · Michael S. Tsirkin

"A number of virtqueues are created" seems clearer than "the number of virtqueues": it's virtqueues that are created not the number.

ping

Quoted 23 lines

---

I'm not a native english speaker but the below seems correct to me. Rusty?

 virtio-spec.lyx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
virtio-spec.lyx +1 -1
index d9626a9..a29315c 100644
@@ -6406,7 +6406,7 @@ If the VIRTIO_CONSOLE_F_MULTIPORT feature is negotiated, the driver can
  spawn multiple ports, not all of which may be attached to a console.
  Some could be generic ports.
  In this case, the control virtqueues are enabled and according to the max_nr_po
-rts configuration-space value, the appropriate number of virtqueues are
+rts configuration-space value, an appropriate number of virtqueues are
  created.
  A control message indicating the driver is ready is sent to the host.
  The host can then send control messages for adding new ports to the device.
Signature · 1 line
MST
Acked-by on v1 1/1
#3 lore raw
In reply to Michael S. Tsirkin

----- Original Message -----

Quoted 5 lines

"A number of virtqueues are created" seems clearer than "the number of virtqueues": it's virtqueues that are created not the number.

Two opposite problem exists:

virtio-0.9.5.lyx renamed from virtio-0.9.5.lyx.orig +2 -2
@@ -8685,7 +8685,7 @@ s on QueueNum, QueueAlign and QueuePFN a
 \begin_inset Newline newline
 \end_inset
 
- Queue size is a number of elements in the queue, therefore size of the
+ Queue size is the number of elements in the queue, therefore size of the
  descriptor table and both available and used rings.
 \begin_inset Newline newline
 \end_inset
@@ -8850,7 +8850,7 @@ reference "sub:Device-Initialization-Seq
 \end_layout
 
 \begin_layout Standard
-Virtual queue size is a number of elements in the queue, therefore size
+Virtual queue size is the number of elements in the queue, therefore size
  of the descriptor table and both available and used rings.
 \end_layout
 
Quoted 35 lines

---

I'm not a native english speaker but the below seems correct to me. Rusty?

 virtio-spec.lyx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
virtio-spec.lyx +0 -0
index d9626a9..a29315c 100644
@@ -6406,7 +6406,7 @@ If the VIRTIO_CONSOLE_F_MULTIPORT feature is

negotiated, the driver can
spawn multiple ports, not all of which may be attached to a console.
Some could be generic ports.
In this case, the control virtqueues are enabled and according to the max_nr_po
-rts configuration-space value, the appropriate number of virtqueues are
+rts configuration-space value, an appropriate number of virtqueues are
created.
A control message indicating the driver is ready is sent to the host.
The host can then send control messages for adding new ports to the device.
--
MST
_______________________________________________
Virtualization mailing list [email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

#4 lore raw
In reply to Michael S. Tsirkin
Quoted 3 lines · Michael S. Tsirkin

"A number of virtqueues are created" seems clearer than "the number of virtqueues": it's virtqueues that are created not the number.

"the appropriate number" <- there is only one appropriate number. "an appropriate number" <- there is at least one appropriate number.

If it's a specified number, the former is more precise.

Cheers,
Rusty.