Skip to contentSkip to conversation

Staging: silicom: remove S_IWOTH from proc declaration

PATCH In review Dan Carpenter 2 participants 2 messages Sep 12, 2012

Subsystems (2)
Staging Kernel janitors
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 Staging: silicom: remove S_IWOTH from proc declaration

We don't need these to be world writable or group writable.

Signed-off-by Dan Carpenter <[email protected]>

---
This is linux-next stuff. The code in bp_proc.c is ifdefed out, and I wasn't able to compile it.

drivers/staging/silicom/bp_proc.c +1 -2
index 4fe862d..6ad4b27 100644
@@ -106,8 +106,7 @@ bypass_proc_create_entry_sd(struct pfs_unit *pfs_unit_curr,
 	pfs_unit_curr->proc_entry = create_proc_entry(pfs_unit_curr->proc_name,
 						      S_IFREG | S_IRUSR |
 						      S_IWUSR | S_IRGRP |
-						      S_IWGRP | S_IROTH |
-						      S_IWOTH, parent_pfs);
+						      S_IROTH, parent_pfs);
 	if (pfs_unit_curr->proc_entry = 0) {
 
 		return -1;
drivers/staging/silicom/bp_mod.c +1 -2
index 0d96196..6e999c7 100644
@@ -7724,8 +7724,7 @@ bypass_proc_create_entry_sd(struct pfs_unit_sd *pfs_unit_curr,
 	pfs_unit_curr->proc_entry = create_proc_entry(pfs_unit_curr->proc_name,
 						      S_IFREG | S_IRUSR |
 						      S_IWUSR | S_IRGRP |
-						      S_IWGRP | S_IROTH |
-						      S_IWOTH, parent_pfs);
+						      S_IROTH, parent_pfs);
 	if (pfs_unit_curr->proc_entry = 0) {
 
 		return -1;
#1 lore raw
Quoted 26 lines · Dan Carpenter

We don't need these to be world writable or group writable.

Signed-off-by Dan Carpenter <[email protected]>

---
This is linux-next stuff. The code in bp_proc.c is ifdefed out, and I wasn't able to compile it.

drivers/staging/silicom/bp_proc.c +1 -2
index 4fe862d..6ad4b27 100644
@@ -106,8 +106,7 @@ bypass_proc_create_entry_sd(struct pfs_unit *pfs_unit_curr,
 	pfs_unit_curr->proc_entry = create_proc_entry(pfs_unit_curr->proc_name,
 						      S_IFREG | S_IRUSR |
 						      S_IWUSR | S_IRGRP |
-						      S_IWGRP | S_IROTH |
-						      S_IWOTH, parent_pfs);
+						      S_IROTH, parent_pfs);
 	if (pfs_unit_curr->proc_entry = 0) {
 
 		return -1;
drivers/staging/silicom/bp_mod.c +0 -0
index 0d96196..6e999c7 100644

drivers/staging/silicom/bp_mod.c bypass_proc_create_entry_sd(struct pfs_unit_sd *pfs_unit_curr, · line 7730

Quoted 9 lines
drivers/staging/silicom/bp_mod.c +1 -2
@@ -7724,8 +7724,7 @@ bypass_proc_create_entry_sd(struct pfs_unit_sd *pfs_unit_curr,
 	pfs_unit_curr->proc_entry = create_proc_entry(pfs_unit_curr->proc_name,
 						      S_IFREG | S_IRUSR |
 						      S_IWUSR | S_IRGRP |
-						      S_IWGRP | S_IROTH |
-						      S_IWOTH, parent_pfs);
+						      S_IROTH, parent_pfs);
 	if (pfs_unit_curr->proc_entry = 0) {
 
 		return -1;

I need to check my test setup tonight, but I do think apps need group write.

Regards,
Daniel Cotey