Skip to contentSkip to conversation

nouveau_connector.c:535 nouveau_connector_set_property() warn: variable derefe

PATCH New Fengguang Wu 1 participant 1 message Sep 19, 2012 Kernel janitors

lore
Share & tools
lore
#0 lore raw

PATCH 1/80 nouveau_connector.c:535 nouveau_connector_set_property() warn: variable derefe

Hi Ben,

FYI, a pretty old smatch warning:

drivers/gpu/drm/nouveau/nouveau_connector.c:535 nouveau_connector_set_property() warn: variable dereferenced before check 'nv_encoder' (see line 413)

vim +535 drivers/gpu/drm/nouveau/nouveau_connector.c
412 struct nouveau_encoder *nv_encoder = nv_connector->detected_encoder;
413 struct drm_encoder *encoder = to_drm_encoder(nv_encoder);
...
534

Quoted 1 line

535 if (nv_encoder && nv_encoder->dcb->type = OUTPUT_TV)

536 return get_slave_funcs(encoder)->set_property(
537 encoder, connector, property, value);
538
539 return -EINVAL;
540 }

---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <[email protected]> Intel Corporation