usb-serial.c:1415 code aligned with following code on line 1416

DISCUSSION Fengguang Wu 2 participants 2 messages Sep 19, 2012 Kernel janitors

lore

Share & tools

lore

Fengguang Wu

author

2012-09-19 00:57 UTC #0 lore raw

Hi Greg,

FYI, coccinelle warns about

drivers/usb/serial/usb-serial.c:1415:3-51: code aligned with following code on line 1416

vim +1415 drivers/usb/serial/usb-serial.c

1412 /* we only set the reset_resume field if the serial_driver has one */
1413 for (sd = serial_drivers; *sd; ++sd) {
1414 if ((*sd)->reset_resume)

Quoted 2 lines

1415 udriver->reset_resume = usb_serial_reset_resume;
1416 break;

1417 }

---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu, Yuanhan Liu Intel Corporation

Greg Kroah-Hartman

2012-09-19 07:14 UTC #1 lore raw

Quoted 6 lines · Fengguang Wu

Hi Greg,
FYI, coccinelle warns about
drivers/usb/serial/usb-serial.c:1415:3-51: code aligned with following code on line 1416

Quoted 8 lines

vim +1415 drivers/usb/serial/usb-serial.c
1412 /* we only set the reset_resume field if the serial_driver has one */
1413 for (sd = serial_drivers; *sd; ++sd) {
1414 if ((*sd)->reset_resume)
Quoted 2 lines
1415 udriver->reset_resume = usb_serial_reset_resume;
1416 break;
1417 }

Ah, nice catch, that's been there for a while now (since 3.5-rc1), I'll go fix it up.

thanks,

greg k-h