drivers/scsi/qla2xxx/qla_os.c:3722 code aligned with following code on line 3723

Fengguang Wu

author

2012-09-19 03:10 UTC #0 lore raw

Hi Saurav,

FYI, there are new coccinelle warnings show up in

commit aaf4d3e2c647b5d1b24082b766c173e6c7edf79b

Author:     Saurav Kashyap <[email protected]>
Commit:     James Bottomley <[email protected]>
CommitDate: Thu May 10 08:18:04 2012 +0100

[SCSI] qla2xxx: Properly check for current state after the fabric-login request.

+ drivers/scsi/qla2xxx/qla_os.c:3722:7-21: code aligned with following code on line 3723

vim +3722 drivers/scsi/qla2xxx/qla_os.c
3712 } else {
3713 status = qla2x00_fabric_login(vha,
3714 fcport, &next_loopid);
3715 if (status = QLA_SUCCESS) {
3716 int status2;
3717 uint8_t opts;
3718
3719 opts = 0;
3720 if (fcport->flags &
3721 FCF_FCP2_DEVICE)

Quoted 1 line

3722 opts |= BIT_1;

3723 status2 3724 qla2x00_get_port_database(
3725 vha, fcport,
3726 opts);
3727 if (status2 != QLA_SUCCESS)
3728 status = 1;
3729 }
3730 }
3731 } else
3732 status = qla2x00_local_device_login(vha,

---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu, Yuanhan Liu Intel Corporation

Saurav Kashyap

2012-09-20 05:24 UTC #1 lore raw

+Chad, Giri

Hi Fengguang,

It not very clear on what the warning is reported for, can you provide more information regarding this?

Thanks,
~Saurav

Quoted 38 lines

Hi Saurav,
FYI, there are new coccinelle warnings show up in
commit aaf4d3e2c647b5d1b24082b766c173e6c7edf79b
Author:     Saurav Kashyap <[email protected]>
Commit:     James Bottomley <[email protected]>
CommitDate: Thu May 10 08:18:04 2012 +0100
[SCSI] qla2xxx: Properly check for current state after the
fabric-login request.
+ drivers/scsi/qla2xxx/qla_os.c:3722:7-21: code aligned with following code on line 3723
vim +3722 drivers/scsi/qla2xxx/qla_os.c
3712 } else {
3713 status = qla2x00_fabric_login(vha,
3714 fcport, &next_loopid);
3715 if (status = QLA_SUCCESS) {
3716 int status2;
3717 uint8_t opts;
3718
3719 opts = 0;
3720 if (fcport->flags &
3721 FCF_FCP2_DEVICE)
Quoted 1 line
3722 opts |= BIT_1;
3723 status2 > 3724 qla2x00_get_port_database(
3725 vha, fcport,
3726 opts);
3727 if (status2 != QLA_SUCCESS)
3728 status = 1;
3729 }
3730 }
3731 } else
3732 status = qla2x00_local_device_login(vha,

Quoted 4 lines

---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu, Yuanhan Liu Intel Corporation

This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.

Fengguang Wu

author

2012-09-20 05:29 UTC #2 lore raw

In reply to Fengguang Wu

Quoted 6 lines · Saurav Kashyap

+Chad, Giri
Hi Fengguang,
It not very clear on what the warning is reported for, can you provide more information regarding this?

This warning will be triggered for such code:

        if (xxx)
                yyy;
                zzz;

Where one would expect the reasonable format to be either

        if (xxx) {
                yyy;
                zzz;
        }

or

        if (xxx)
                yyy;
        zzz;

Thanks,
Fengguang

Quoted 45 lines

Quoted 38 lines
Hi Saurav,
FYI, there are new coccinelle warnings show up in
commit aaf4d3e2c647b5d1b24082b766c173e6c7edf79b
Author:     Saurav Kashyap <[email protected]>
Commit:     James Bottomley <[email protected]>
CommitDate: Thu May 10 08:18:04 2012 +0100
[SCSI] qla2xxx: Properly check for current state after the
fabric-login request.
+ drivers/scsi/qla2xxx/qla_os.c:3722:7-21: code aligned with following code on line 3723
vim +3722 drivers/scsi/qla2xxx/qla_os.c
3712 } else {
3713 status = qla2x00_fabric_login(vha,
3714 fcport, &next_loopid);
3715 if (status = QLA_SUCCESS) {
3716 int status2;
3717 uint8_t opts;
3718
3719 opts = 0;
3720 if (fcport->flags &
3721 FCF_FCP2_DEVICE)
Quoted 1 line
3722 opts |= BIT_1;
3723 status2 > > 3724 qla2x00_get_port_database(
3725 vha, fcport,
3726 opts);
3727 if (status2 != QLA_SUCCESS)
3728 status = 1;
3729 }
3730 }
3731 } else
3732 status = qla2x00_local_device_login(vha,
Quoted 4 lines
---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu, Yuanhan Liu Intel Corporation
This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.

Saurav Kashyap

2012-09-20 05:40 UTC #3 lore raw

In reply to Fengguang Wu

Thanks Fengguang for clarification. The following patch should fix this warning

drivers/scsi/qla2xxx/qla_os.c +0 -1

index c7dd298..de9dfcf 100644
@@ -3721,8 +3721,8 @@ void qla2x00_relogin(struct scsi_qla_host *vha)
                                                if (fcport->flags &
                                                    FCF_FCP2_DEVICE)
                                                        opts |= BIT_1;
-                                                       status2 -

qla2x00_get_port_database(
+ status2 +
qla2x00_get_port_database(
vha,
fcport,

                                                                opts);
                                                if (status2 != QLA_SUCCESS)

lines 1-15/15 (END)

It passed the checkpatch.pl.

Thanks,
~Saurav

Quoted 21 lines · Saurav Kashyap

Quoted 6 lines
+Chad, Giri
Hi Fengguang,
It not very clear on what the warning is reported for, can you provide more information regarding this?
This warning will be triggered for such code:
       if (xxx)
               yyy;
               zzz;
Where one would expect the reasonable format to be either
       if (xxx) {
               yyy;
               zzz;
       }

Quoted 70 lines

or
       if (xxx)
               yyy;
       zzz;
Thanks,
Fengguang
Quoted 61 lines
Quoted 13 lines
Hi Saurav,
FYI, there are new coccinelle warnings show up in
commit aaf4d3e2c647b5d1b24082b766c173e6c7edf79b
Author:     Saurav Kashyap <[email protected]>
Commit:     James Bottomley <[email protected]>
CommitDate: Thu May 10 08:18:04 2012 +0100
[SCSI] qla2xxx: Properly check for current state after the
fabric-login request.
Quoted 7 lines
+ drivers/scsi/qla2xxx/qla_os.c:3722:7-21: code aligned with following code on line 3723
vim +3722 drivers/scsi/qla2xxx/qla_os.c
3712 } else {
3713 status >>qla2x00_fabric_login(vha,
3714 fcport,
&next_loopid);
Quoted 1 line
3715 if (status =
QLA_SUCCESS) {
Quoted 5 lines
3716 int status2;
3717 uint8_t opts;
3718
3719 opts = 0;
3720 if
(fcport->flags &
Quoted 1 line
3721
FCF_FCP2_DEVICE)
Quoted 3 lines
Quoted 1 line
3722 opts |>>BIT_1;
3723 status2
Quoted 1 line
Quoted 1 line
3724
qla2x00_get_port_database(
Quoted 1 line
3725
vha, fcport,
Quoted 1 line
3726
opts);
Quoted 2 lines
3727 if (status2 !>>QLA_SUCCESS)
3728 status
= 1;
Quoted 7 lines
3729 }
3730 }
3731 } else
3732 status >>qla2x00_local_device_login(vha,
---
0-DAY kernel build testing backend Open Source Technology
Centre
Quoted 1 line
Fengguang Wu, Yuanhan Liu Intel
Corporation
Quoted 1 line
This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.

This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.