Skip to contentSkip to conversation

drivers/mfd/max8907.c:179:16: sparse: symbol 'max8907_pm_off' was not declared.

PATCH In review Fengguang Wu 3 participants 3 messages Sep 19, 2012 – Sep 20, 2012

Subsystems (2)
Kernel janitors Multifunction devices (MFD)
lore
Share & tools
lore

Fengguang Wu

author
#0 lore raw

PATCH 47/76 drivers/mfd/max8907.c:179:16: sparse: symbol 'max8907_pm_off' was not declared.

Hi Stephen,

FYI, there are new sparse warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/sameo/mfd-2.6.git for-next
head:   144c94c99ad2f20ff37ca77147a10da7718895ad
commit: 9582fdcb6fcf1b596a83b161a2ea886272d2a62f [47/76] mfd: max8907: Add power off control

All sparse warnings:

+ drivers/mfd/max8907.c:179:16: sparse: symbol 'max8907_pm_off' was not declared. Should it be static?

vim +179 drivers/mfd/max8907.c
169
170 static const struct regmap_irq_chip max8907_rtc_irq_chip = {
171 .name = "max8907 rtc",
172 .status_base = MAX8907_REG_RTC_IRQ,
173 .mask_base = MAX8907_REG_RTC_IRQ_MASK,
174 .num_regs = 1,
175 .irqs = max8907_rtc_irqs,
176 .num_irqs = ARRAY_SIZE(max8907_rtc_irqs),
177 };
178

Quoted 1 line

179 struct max8907 *max8907_pm_off;

180 static void max8907_power_off(void)
181 {
182 regmap_update_bits(max8907_pm_off->regmap_gen, MAX8907_REG_RESET_CNFG,
183 MAX8907_MASK_POWER_OFF, MAX8907_MASK_POWER_OFF);
184 }
185
186 static __devinit int max8907_i2c_probe(struct i2c_client *i2c,
187 const struct i2c_device_id *id)
188 {
189 struct max8907 *max8907;

Please consider folding the attached diff :-)

---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu, Yuanhan Liu Intel Corporation

drivers/mfd/max8907.c +1 -1
index 2303641..17f2593 100644
@@ -176,7 +176,7 @@ static const struct regmap_irq_chip max8907_rtc_irq_chip = {
 	.num_irqs = ARRAY_SIZE(max8907_rtc_irqs),
 };
 
-struct max8907 *max8907_pm_off;
+static struct max8907 *max8907_pm_off;
 static void max8907_power_off(void)
 {
 	regmap_update_bits(max8907_pm_off->regmap_gen, MAX8907_REG_RESET_CNFG,
#1 lore raw

Re: [mfd:for-next 47/76] drivers/mfd/max8907.c:179:16: sparse: symbol 'max8907_pm_off' was not decla

Hi Fengguang,

Quoted 35 lines · Fengguang Wu

Hi Stephen,

FYI, there are new sparse warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/sameo/mfd-2.6.git for-next
head:   144c94c99ad2f20ff37ca77147a10da7718895ad
commit: 9582fdcb6fcf1b596a83b161a2ea886272d2a62f [47/76] mfd: max8907: Add power off control

All sparse warnings:

+ drivers/mfd/max8907.c:179:16: sparse: symbol 'max8907_pm_off' was not declared. Should it be static?

vim +179 drivers/mfd/max8907.c
169

   170	static const struct regmap_irq_chip max8907_rtc_irq_chip = {
   171		.name = "max8907 rtc",
   172		.status_base = MAX8907_REG_RTC_IRQ,
   173		.mask_base = MAX8907_REG_RTC_IRQ_MASK,
   174		.num_regs = 1,
   175		.irqs = max8907_rtc_irqs,
   176		.num_irqs = ARRAY_SIZE(max8907_rtc_irqs),
   177	};
   178
Quoted 1 line

179 struct max8907 *max8907_pm_off;

180 static void max8907_power_off(void)

   181	{
   182		regmap_update_bits(max8907_pm_off->regmap_gen, MAX8907_REG_RESET_CNFG,
   183				MAX8907_MASK_POWER_OFF, MAX8907_MASK_POWER_OFF);
   184	}
   185	
   186	static __devinit int max8907_i2c_probe(struct i2c_client *i2c,
   187					       const struct i2c_device_id *id)
   188	{
   189		struct max8907 *max8907;
Quoted 1 line

Please consider folding the attached diff :-)

I applied this one on top of my for-next branch. I took the freedom to add your SOB on it, please let me know if that's an issue for you.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/
Acked-by on v1 47/76
#2 lore raw

RE: [mfd:for-next 47/76] drivers/mfd/max8907.c:179:16: sparse: symbol 'max8907_pm_off' was not decla

In reply to Fengguang Wu

Fengguang Wu wrote at Wednesday, September 19, 2012 5:34 PM:

Quoted 11 lines

Hi Stephen,

FYI, there are new sparse warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/sameo/mfd-2.6.git for-next
head:   144c94c99ad2f20ff37ca77147a10da7718895ad
commit: 9582fdcb6fcf1b596a83b161a2ea886272d2a62f [47/76] mfd: max8907: Add power off control

All sparse warnings:

+ drivers/mfd/max8907.c:179:16: sparse: symbol 'max8907_pm_off' was not declared. Should it be static?

...

Quoted 1 line

Please consider folding the attached diff :-)

Yes, the diff is correct; please consider it:

Acked-by Stephen Warren <[email protected]>
Signature · 1 line
nvpublic