Skip to contentSkip to conversation

workqueue: remove spurious WARN_ON_ONCE(in_irq()) from try_to_grab_pending()

PATCH New Tejun Heo 1 participant 1 message Sep 20, 2012 1 message not in the archive Workqueue

lore
Share & tools
lore

Tejun Heo

author maintainer
#1 lore raw

PATCH 1/1 workqueue: remove spurious WARN_ON_ONCE(in_irq()) from try_to_grab_pending()

In reply to a message not in the archive
Quoted 1 line

From 7c6e72e46c9ea4a88f3f8ba96edce9db4bd48726 Mon Sep 17 00:00:00 2001

From: Tejun Heo <[email protected]>
Date: Thu, 20 Sep 2012 10:03:19 -0700

e0aecdd874 ("workqueue: use irqsafe timer for delayed_work") made try_to_grab_pending() safe to use from irq context but forgot to remove WARN_ON_ONCE(in_irq()). Remove it.

Signed-off-by Tejun Heo <[email protected]>
Reported-by Fengguang Wu <[email protected]>
---
 kernel/workqueue.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
kernel/workqueue.c +0 -2
index 4f5c61f..143fd8c 100644
@@ -1070,8 +1070,6 @@ static int try_to_grab_pending(struct work_struct *work, bool is_dwork,
 {
 	struct global_cwq *gcwq;
 
-	WARN_ON_ONCE(in_irq());
-
 	local_irq_save(*flags);
 
 	/* try to steal the timer if it exists */
Signature · 1 line
1.7.7.3