Skip to contentSkip to conversation

kernel/signal.c:3119:35: error: expected identifier before '(' token

PATCH In review Fengguang Wu 2 participants 2 messages Sep 21, 2012 Kernel janitors

lore
Share & tools
lore

Fengguang Wu

author
#0 lore raw

PATCH 94/94 kernel/signal.c:3119:35: error: expected identifier before '(' token

Hi Al,

FYI, kernel build failed on

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/viro/signal.git master
head:   1320d2cc9be60744e2e0bbb73f8e2653a77bf59c
commit: 1320d2cc9be60744e2e0bbb73f8e2653a77bf59c [94/94] mips: sigaltstack conversion
config: mips-allnoconfig

All related error/warning messages:

kernel/signal.c: In function 'sys_sigaltstack':
kernel/signal.c:3119:35: error: expected identifier before '(' token kernel/signal.c:3120:1: warning: control reaches end of non-void function [-Wreturn-type]

vim +3119 kernel/signal.c
3113 return error;
3114 }
3115
3116 #ifdef __ARCH_WANT_SYS_SIGALTSTACK
3117 SYSCALL_DEFINE2(sigaltstack, const stack_t __user *, uss, stack_t *, uoss)
3118 {

Quoted 1 line

3119 return do_sigaltstack(uss, uoss, current_user_stack_pointer());

3120 }
3121 #endif
3122

---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu, Yuanhan Liu Intel Corporation

#1 lore raw
Quoted 9 lines · Fengguang Wu

Hi Al,

FYI, kernel build failed on

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/viro/signal.git master
head:   1320d2cc9be60744e2e0bbb73f8e2653a77bf59c
commit: 1320d2cc9be60744e2e0bbb73f8e2653a77bf59c [94/94] mips: sigaltstack conversion
config: mips-allnoconfig
Quoted 5 lines

All related error/warning messages:

kernel/signal.c: In function 'sys_sigaltstack':
kernel/signal.c:3119:35: error: expected identifier before '(' token kernel/signal.c:3120:1: warning: control reaches end of non-void function [-Wreturn-type]

D'oh... broken user_stack_pointer() definition -
#define foo(regs) ((regs)->regs[something])
is a bad idea... Fixed.