kernel/irq/irqdomain.c:331:2: error: implicit declaration of func

PATCH Fengguang Wu 1 participant 2 messages Sep 21, 2012 – Sep 22, 2012 Kernel janitors

Share & tools

Fengguang Wu

author

2012-09-21 23:48 UTC #0 lore raw

Hi Lee,

I'm simply testing every branches that can be found. Are there some branches in your tree not suitable for testing? If so, I can add them to the opt-out list.

Thanks,
Fengguang

Quoted 47 lines · Lee Jones

Hmm... just of out interest, why are you using that branch?
Kind regards,
Lee
Quoted 40 lines · Yuanhan Liu
Hi Lee,
FYI, kernel build failed on
tree:   git://git.linaro.org/people/ljones/linux-3.0-ux500.gitpreview-for-next
head:   3cc064be4244a038bbbd303ce18b78e06b5fd508
commit: 04939876856788a50902e273c260d922001d32fe [26/62] Revert "of/irq:
Create stub for of_irq_find_parent when !CONFIG_OF"
config: x86_64-allyesdebian (attached as .config)
All related error/warning messages:
kernel/irq/irqdomain.c: In function 'irq_find_host':
kernel/irq/irqdomain.c:331:2: error: implicit declaration of function 'of_irq_find_parent' [-Werror=implicit-function-declaration] kernel/irq/irqdomain.c:331:14: warning: assignment makes pointer from integer without a cast [enabled by default]
cc1: some warnings being treated as errors
vim +331 kernel/irq/irqdomain.c
   325  {
   326          struct irq_domain *h, *found = NULL;
   327          struct device_node *parent_node;
   328          int rc;
   329
   330          /* Take heed if an 'interrupt-parent' was specified. */
Quoted 1 line
331 parent_node = of_irq_find_parent(node);
332 if (parent_node)
   333                  node = parent_node;
   334
-------
I do see that the following commit: 446f1bfe(Revert "irqdomain:.*") would fix
this build error. But this commit break the bisectabilty. And I guess this issue
can be fixed by reverse the revert order: 446f1bfe(Revert "of/irq:.*") and then
04939876(Revert "irqdomain:.*").

Quoted 12 lines

Quoted 4 lines
---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu, Yuanhan Liu Intel Corporation
Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org â”‚ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Fengguang Wu

author

2012-09-22 11:49 UTC #1 lore raw

Hi Lee,

Quoted 7 lines · Lee Jones

It would be better if you didn't test any of them from that tree, as there could be anything in them.
Anything that is going upstream will be in the upstream maintainer's -next branches.
Please test these instead.

The maintainer's -next trees often cannot be rebased when errors are found there. That's the reason I try to test commits earlier in the individual developers' trees.

However if you still prefer it, I can remove your tree from auto tests.

Thanks,
Fengguang

Quoted 88 lines · Fengguang Wu

Quoted 79 lines
Hi Lee,
I'm simply testing every branches that can be found. Are there some branches in your tree not suitable for testing? If so, I can add them to the opt-out list.
Thanks,
Fengguang
Quoted 12 lines · Lee Jones
Hmm... just of out interest, why are you using that branch?
Kind regards,
Lee
Quoted 5 lines · Yuanhan Liu
Hi Lee,
FYI, kernel build failed on
tree: git://
git.linaro.org/people/ljones/linux-3.0-ux500.gitpreview-for-next
Quoted 2 lines
Quoted 2 lines
head:   3cc064be4244a038bbbd303ce18b78e06b5fd508
commit: 04939876856788a50902e273c260d922001d32fe [26/62] Revert
"of/irq:
Quoted 24 lines
Quoted 24 lines
Create stub for of_irq_find_parent when !CONFIG_OF"
config: x86_64-allyesdebian (attached as .config)
All related error/warning messages:
kernel/irq/irqdomain.c: In function 'irq_find_host':
kernel/irq/irqdomain.c:331:2: error: implicit declaration of function 'of_irq_find_parent' [-Werror=implicit-function-declaration] kernel/irq/irqdomain.c:331:14: warning: assignment makes pointer from integer without a cast [enabled by default]
cc1: some warnings being treated as errors
vim +331 kernel/irq/irqdomain.c
   325  {
   326          struct irq_domain *h, *found = NULL;
   327          struct device_node *parent_node;
   328          int rc;
   329
   330          /* Take heed if an 'interrupt-parent' was specified. */
Quoted 1 line
331 parent_node = of_irq_find_parent(node);
332 if (parent_node)
   333                  node = parent_node;
   334
Quoted 2 lines
Quoted 2 lines
-------
I do see that the following commit: 446f1bfe(Revert "irqdomain:.*")
would
Quoted 2 lines
Quoted 2 lines
fix
this build error. But this commit break the bisectabilty. And I guess
this
Quoted 2 lines
Quoted 2 lines
issue
can be fixed by reverse the revert order: 446f1bfe(Revert "of/irq:.*")
and
Quoted 5 lines
Quoted 5 lines
then
04939876(Revert "irqdomain:.*").
---
0-DAY kernel build testing backend Open Source Technology
Centre
Quoted 1 line
Quoted 1 line
Fengguang Wu, Yuanhan Liu Intel
Corporation
Quoted 9 lines
Quoted 1 line
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog