Skip to contentSkip to conversation

sparc: bpf_jit_comp: add XOR instruction for BPF JIT JIT

PATCH In review Daniel Borkmann 2 participants 2 messages Sep 24, 2012 – Sep 27, 2012

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sparc: bpf_jit_comp: add XOR instruction for BPF JIT JIT

This patch is a follow-up for patch "filter: add XOR instruction for use with X/K" that implements BPF SPARC JIT parts for the BPF XOR operation.

---

I don't own a SPARC machine. This code is untested and uncompiled, but following the other instructions, this should integrate cleanly. Can someone confirm that? Thanks.

 arch/sparc/net/bpf_jit_comp.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
arch/sparc/net/bpf_jit_comp.c +4 -0
index e9073e9..2836870 100644
@@ -464,8 +464,12 @@ void bpf_jit_compile(struct sk_filter *fp)
 				emit_alu_K(OR, K);
 				break;
 			case BPF_S_ANC_ALU_XOR_X: /* A ^= X; */
+			case BPF_S_ALU_XOR_X:
 				emit_alu_X(XOR);
 				break;
+			case BPF_S_ALU_XOR_K:	/* A ^= K */
+				emit_alu_K(XOR, K);
+				break;
 			case BPF_S_ALU_LSH_X:	/* A <<= X */
 				emit_alu_X(SLL);
 				break;
maintainer
#1 lore raw

From: Daniel Borkmann <[email protected]>
Date: Mon, 24 Sep 2012 23:57:54 +0200

Quoted 4 lines

This patch is a follow-up for patch "filter: add XOR instruction for use with X/K" that implements BPF SPARC JIT parts for the BPF XOR operation.

Looks good, applied, thanks Daniel.