Skip to contentSkip to conversation

staging: rtl8192u: fix a macro expansion bug

PATCH New Dan Carpenter 1 participant 1 message Oct 2, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8192u: fix a macro expansion bug

Clang detected this macro expansion bug:
drivers/staging/rtl8192u/r8192U_core.c:2384:76: warning: operator '?:'
has lower precedence than '+'; '+' will be evaluated first [-Wparentheses]

The line from the .c file looks like this:

	u1bAIFS = qos_parameters->aifs[i] * ((mode&(IEEE_G|IEEE_N_24G)) ?9:20) + aSifsTime;

We need to put parenthesis around the entire macro to fix the bug.

drivers/staging/rtl8192u/ieee80211/ieee80211.h +4 -1
index 13f45c3..502bfdb 100644
@@ -235,7 +235,10 @@ enum	_ReasonCode{
 
 
 
-#define aSifsTime	 ((priv->ieee80211->current_network.mode = IEEE_A)||(priv->ieee80211->current_network.mode = IEEE_N_24G)||(priv->ieee80211->current_network.mode = IEEE_N_5G))? 16 : 10
+#define aSifsTime ((priv->ieee80211->current_network.mode = IEEE_A || \
+		    priv->ieee80211->current_network.mode = IEEE_N_24G || \
+		    priv->ieee80211->current_network.mode = IEEE_N_5G) ? \
+		   16 : 10)
 
 #define MGMT_QUEUE_NUM 5