ERROR: "radeon_legacy_get_backlight_level" [drivers/gpu/drm/radeon/radeon.ko]

PATCH In review Fengguang Wu 2 participants 5 messages Oct 4, 2012 – Oct 15, 2012

Subsystems (3)

DRM drivers Kernel janitors Radeon and amdgpu DRM drivers

lore

Share & tools

lore

Fengguang Wu

author

2012-10-04 09:40 UTC #0 lore raw

PATCH 186/301 ERROR: "radeon_legacy_get_backlight_level" [drivers/gpu/drm/radeon/radeon.ko]

Hi Alex,

FYI, kernel build failed on

tree:   git://people.freedesktop.org/~airlied/linux.git drm-next
head:   268d28371cd326be4dfcd7eba5917bf4b9d30c8f
commit: 6d92f81dcf2d40b8ebb947bba5435642b830f649 [186/301] drm/radeon: add get_backlight_level callback
config: ia64-defconfig

All error/warnings:

ERROR: "radeon_legacy_get_backlight_level" [drivers/gpu/drm/radeon/radeon.ko] undefined!
ERROR: "atombios_set_backlight_level" [drivers/gpu/drm/radeon/radeon.ko] undefined!
ERROR: "atombios_get_backlight_level" [drivers/gpu/drm/radeon/radeon.ko] undefined!
ERROR: "radeon_legacy_set_backlight_level" [drivers/gpu/drm/radeon/radeon.ko] undefined!
ERROR: "backlight_force_update" [drivers/gpu/drm/radeon/radeon.ko] undefined!

---
0-DAY kernel build testing backend Open Source Technology Center
Fengguang Wu, Yuanhan Liu Intel Corporation

Deucher, Alexander

maintainer

2012-10-04 13:13 UTC #1 lore raw

RE: [drm:drm-next 186/301] ERROR: "radeon_legacy_get_backlight_level" [drivers/gpu/drm/radeon/radeon

Quoted 21 lines

-----Original Message-----
From: Fengguang Wu [mailto:[email protected]]
Sent: Thursday, October 04, 2012 5:41 AM
To: Deucher, Alexander
Cc: [email protected]
Subject: [drm:drm-next 186/301] ERROR:
"radeon_legacy_get_backlight_level" [drivers/gpu/drm/radeon/radeon.ko] undefined!
Hi Alex,
FYI, kernel build failed on
tree:   git://people.freedesktop.org/~airlied/linux.git drm-next
head:   268d28371cd326be4dfcd7eba5917bf4b9d30c8f
commit: 6d92f81dcf2d40b8ebb947bba5435642b830f649 [186/301]
drm/radeon: add get_backlight_level callback
config: ia64-defconfig
All error/warnings:

Quoted 10 lines

ERROR: "radeon_legacy_get_backlight_level" [drivers/gpu/drm/radeon/radeon.ko] undefined!
ERROR: "atombios_set_backlight_level" [drivers/gpu/drm/radeon/radeon.ko] undefined!
ERROR: "atombios_get_backlight_level" [drivers/gpu/drm/radeon/radeon.ko] undefined!
ERROR: "radeon_legacy_set_backlight_level" [drivers/gpu/drm/radeon/radeon.ko] undefined!
ERROR: "backlight_force_update" [drivers/gpu/drm/radeon/radeon.ko] undefined!

Should be fixed with the attached patch.

Alex

From bfe7cddc85d8bf3af38cfaebbc42f09d1acee268 Mon Sep 17 00:00:00 2001
From: Alex Deucher <[email protected]>
Date: Thu, 4 Oct 2012 09:10:10 -0400
Subject: [PATCH] drm/radeon: fix compilation with backlight disabled

Signed-off-by Alex Deucher <[email protected]>

---
 drivers/gpu/drm/radeon/radeon_acpi.c            |    2 +
 drivers/gpu/drm/radeon/radeon_legacy_encoders.c |   42 +++++++++++-----------
 2 files changed, 23 insertions(+), 21 deletions(-)

drivers/gpu/drm/radeon/radeon_acpi.c +2 -0

index faf1ed5..6a4d75a 100644
@@ -372,6 +372,7 @@ int radeon_atif_handler(struct radeon_device *rdev,
 
 			radeon_set_backlight_level(rdev, enc, req.backlight_level);
 
+#if defined(CONFIG_BACKLIGHT_CLASS_DEVICE) || defined(CONFIG_BACKLIGHT_CLASS_DEVICE_MODULE)
 			if (rdev->is_atom_bios) {
 				struct radeon_encoder_atom_dig *dig = enc->enc_priv;
 				backlight_force_update(dig->bl_dev,

@@ -381,6 +382,7 @@ int radeon_atif_handler(struct radeon_device *rdev,
 				backlight_force_update(dig->bl_dev,
 						       BACKLIGHT_UPDATE_HOTKEY);
 			}
+#endif
 		}
 	}
 	/* TODO: check other events */

drivers/gpu/drm/radeon/radeon_legacy_encoders.c +21 ~~-21~~

54 lines not on this page · raw message

Signature · 1 line

1.7.7.5

Fengguang Wu

author

2012-10-15 11:40 UTC #2 lore raw

Re: [drm:drm-next 186/301] ERROR: "radeon_legacy_get_backlight_level" [drivers/gpu/drm/radeon/radeon

In reply to Fengguang Wu

ping

Quoted 20 lines · Fengguang Wu

Hi Alex,
FYI, kernel build failed on
tree:   git://people.freedesktop.org/~airlied/linux.git drm-next
head:   268d28371cd326be4dfcd7eba5917bf4b9d30c8f
commit: 6d92f81dcf2d40b8ebb947bba5435642b830f649 [186/301] drm/radeon: add get_backlight_level callback
config: ia64-defconfig
All error/warnings:
ERROR: "radeon_legacy_get_backlight_level" [drivers/gpu/drm/radeon/radeon.ko] undefined!
ERROR: "atombios_set_backlight_level" [drivers/gpu/drm/radeon/radeon.ko] undefined!
ERROR: "atombios_get_backlight_level" [drivers/gpu/drm/radeon/radeon.ko] undefined!
ERROR: "radeon_legacy_set_backlight_level" [drivers/gpu/drm/radeon/radeon.ko] undefined!
ERROR: "backlight_force_update" [drivers/gpu/drm/radeon/radeon.ko] undefined!
---
0-DAY kernel build testing backend Open Source Technology Center
Fengguang Wu, Yuanhan Liu Intel Corporation

Deucher, Alexander

maintainer

2012-10-15 12:55 UTC #3 lore raw

RE: [drm:drm-next 186/301] ERROR: "radeon_legacy_get_backlight_level" [drivers/gpu/drm/radeon/radeon

In reply to Fengguang Wu

Quoted 10 lines

-----Original Message-----
From: Fengguang Wu [mailto:[email protected]]
Sent: Monday, October 15, 2012 7:41 AM
To: Deucher, Alexander
Cc: [email protected]; Peter Hüwe
Subject: Re: [drm:drm-next 186/301] ERROR:
"radeon_legacy_get_backlight_level" [drivers/gpu/drm/radeon/radeon.ko] undefined!
ping

The fix is in my patch queue, but I was out of town last week. I'll send the pull request to Dave this week.

Alex

Quoted 16 lines · Fengguang Wu

Quoted 7 lines
Hi Alex,
FYI, kernel build failed on
tree:   git://people.freedesktop.org/~airlied/linux.git drm-next
head:   268d28371cd326be4dfcd7eba5917bf4b9d30c8f
commit: 6d92f81dcf2d40b8ebb947bba5435642b830f649 [186/301]
drm/radeon: add get_backlight_level callback
Quoted 5 lines
config: ia64-defconfig
All error/warnings:
ERROR: "radeon_legacy_get_backlight_level"
[drivers/gpu/drm/radeon/radeon.ko] undefined!

Quoted 12 lines

Quoted 1 line
ERROR: "atombios_set_backlight_level"
[drivers/gpu/drm/radeon/radeon.ko] undefined!
Quoted 1 line
ERROR: "atombios_get_backlight_level"
[drivers/gpu/drm/radeon/radeon.ko] undefined!
Quoted 1 line
ERROR: "radeon_legacy_set_backlight_level"
[drivers/gpu/drm/radeon/radeon.ko] undefined!
Quoted 1 line
ERROR: "backlight_force_update" [drivers/gpu/drm/radeon/radeon.ko]
undefined!
Quoted 4 lines
---
0-DAY kernel build testing backend Open Source Technology Center
Fengguang Wu, Yuanhan Liu Intel Corporation

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Fengguang Wu

author

2012-10-15 13:00 UTC #4 lore raw

Re: [drm:drm-next 186/301] ERROR: "radeon_legacy_get_backlight_level" [drivers/gpu/drm/radeon/radeon

In reply to Fengguang Wu

Quoted 9 lines · Alexander

Quoted 9 lines
-----Original Message-----
From: Fengguang Wu [mailto:[email protected]]
Sent: Monday, October 15, 2012 7:41 AM
To: Deucher, Alexander
Cc: [email protected]; Peter HÃ¼we
Subject: Re: [drm:drm-next 186/301] ERROR:
"radeon_legacy_get_backlight_level" [drivers/gpu/drm/radeon/radeon.ko] undefined!

Quoted 3 lines

Quoted 1 line
ping
The fix is in my patch queue, but I was out of town last week. I'll send the pull request to Dave this week.

OK, thank you!

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html