Skip to contentSkip to conversation

Remove noisy printks from llcp_sock_connect

PATCH Applied Dave Jones 2 participants 2 messages Oct 4, 2012

Subsystems (3)
lore
Share & tools
lore

Dave Jones

author
#0 lore raw

Validation of userspace input shouldn't trigger dmesg spamming.

net/nfc/llcp/sock.c +2 -6
index 40f056d..63e4cdc 100644
@@ -497,15 +497,11 @@ static int llcp_sock_connect(struct socket *sock, struct sockaddr *_addr,
 	pr_debug("sock %p sk %p flags 0x%x\n", sock, sk, flags);
 
 	if (!addr || len < sizeof(struct sockaddr_nfc) ||
-	    addr->sa_family != AF_NFC) {
-		pr_err("Invalid socket\n");
+	    addr->sa_family != AF_NFC)
 		return -EINVAL;
-	}
 
-	if (addr->service_name_len == 0 && addr->dsap == 0) {
-		pr_err("Missing service name or dsap\n");
+	if (addr->service_name_len == 0 && addr->dsap == 0)
 		return -EINVAL;
-	}
 
 	pr_debug("addr dev_idx=%u target_idx=%u protocol=%u\n", addr->dev_idx,
 		 addr->target_idx, addr->nfc_protocol);