return proper value in function dracut_install
PATCH 1/1 return proper value in function dracut_install
dracut_install should return the real return value, so module install function can detect the install failure.
Such as below in 99base:dracut_install switch_root || dfatal "Failed to install switch_root"
Signed-off-by Dave Young <[email protected]>
--- dracut-functions.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
dracut-functions.sh +4 -1
@@ -563,9 +563,12 @@ if [[ $DRACUT_INSTALL ]]; then } dracut_install() { + local ret #dinfo "initdir=$initdir $DRACUT_INSTALL -l $@" $DRACUT_INSTALL ${initdir+-D "$initdir"} -a ${DRACUT_RESOLVE_DEPS+-l} ${DRACUT_FIPS_MODE+-H} "$@" - (($? != 0)) && derror $DRACUT_INSTALL ${initdir+-D "$initdir"} -a ${DRACUT_RESOLVE_DEPS+-l} ${DRACUT_FIPS_MODE+-H} "$@" || : + ret=$? + (($ret != 0)) && derror $DRACUT_INSTALL ${initdir+-D "$initdir"} -a ${DRACUT_RESOLVE_DEPS+-l} ${DRACUT_FIPS_MODE+-H} "$@" || : + return $ret } inst_library() {
Am 08.10.2012 11:40, schrieb Dave Young:
Quoted 18 lines
dracut_installshould return the real return value, so module install function can detect the install failure.Such as below in 99base:
dracut_installswitch_root|| dfatal "Failed to installswitch_root"Signed-off-by Dave Young <[email protected]>--- dracut-functions.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)dracut-functions.sh +0
-0@@ -563,9 +563,12 @@ if [[ $DRACUT_INSTALL ]]; then } dracut_install() {
dracut-functions.sh if [[ $DRACUT_INSTALL ]]; then · line 574
Quoted 10 lines
dracut-functions.sh +4
-1+ local ret #dinfo "initdir=$initdir $DRACUT_INSTALL -l $@" $DRACUT_INSTALL ${initdir+-D "$initdir"} -a ${DRACUT_RESOLVE_DEPS+-l} ${DRACUT_FIPS_MODE+-H} "$@" - (($? != 0)) && derror $DRACUT_INSTALL ${initdir+-D "$initdir"} -a ${DRACUT_RESOLVE_DEPS+-l} ${DRACUT_FIPS_MODE+-H} "$@" || : + ret=$? + (($ret != 0)) && derror $DRACUT_INSTALL ${initdir+-D "$initdir"} -a ${DRACUT_RESOLVE_DEPS+-l} ${DRACUT_FIPS_MODE+-H} "$@" || : + return $ret } inst_library() {