Otavio Salvador : libav: Change the PACKAGES_DYNAMIC expression to be more restrict
Quoted 27 lines · On Wed, Oct 10, 2012 at 10:42:52AM +0000, [email protected] wrote:
Module: meta-openembedded.git Branch: master Commit: 97350f52280ea9b2f3d7b36ef248be5ba3e7c696 URL: http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=97350f52280ea9b2f3d7b36ef248be5ba3e7c696Author: Otavio Salvador <[email protected]> Date: Sat Oct 6 20:18:30 2012 +0000libav: Change the
PACKAGES_DYNAMICexpression to be more restrictUsing 'lib*' we end having problem with every other package that generate libraries dynamically thus we changed it to match the library prefixes.
Signed-off-by Otavio Salvador <[email protected]>Signed-off-by Koen Kooi <[email protected]>---
meta-oe/recipes-multimedia/libav/libav.inc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)meta-oe/recipes-multimedia/libav/libav.inc +0
-0
meta-oe/recipes-multimedia/libav/libav.inc python populate_packages_prepend() { · line 122
Quoted 5 lines
meta-oe/recipes-multimedia/libav/libav.inc +1
-1@@ -119,4 +119,4 @@ python populate_packages_prepend() { allow_links=True) } -PACKAGES_DYNAMIC = "lib*" +PACKAGES_DYNAMIC = "lib(av(codec|device|filter|format|util)|postproc)*"
Unfortunatelly this does not work, this regexp matches everything starting with 'lib', so it's only a bit more strict then old version which matched everything starting with 'li' :).
Please change it to:PACKAGES_DYNAMIC = "^lib(av(codec|device|filter|format|util)|postproc)" orPACKAGES_DYNAMIC = "^lib(av(codec|device|filter|format|util)|postproc).*"
^ isn't used in any PACKAGES_DYNAMIC in oe-core, but it could make matching faster
* is used wrong in all PACKAGES_DYNAMIC in oe-core (as in glob, but not regexp), so all those last '-' are optional
Cheers,
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]
Quoted 19 lines · On Thursday 11 October 2012 11:01:33 Martin Jansa wrote:
Review
Quoted 13 lines · On Wed, Oct 10, 2012 at 10:42:52AM +0000, [email protected] wrote:
Module: meta-openembedded.git
Branch: master
Commit:97350f52280ea9b2f3d7b36ef248be5ba3e7c696
URL:
http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=97350f52280ea9b2f3d7b36ef248be5ba3e7c696Author: Otavio Salvador <[email protected]> Date: Sat Oct 6 20:18:30 2012 +0000...
(quoted diff) +1
-1-PACKAGES_DYNAMIC = "lib*" +PACKAGES_DYNAMIC = "lib(av(codec|device|filter|format|util)|postproc)*"Unfortunatelly this does not work, this regexp matches everything starting with 'lib', so it's only a bit more strict then old version which matched everything starting with 'li' :).
Quoted 8 lines
Please change it to:
PACKAGES_DYNAMIC= "^lib(av(codec|device|filter|format|util)|postproc)" orPACKAGES_DYNAMIC= "^lib(av(codec|device|filter|format|util)|postproc).*"^ isn't used in any
PACKAGES_DYNAMICin oe-core, but it could make matching faster * is used wrong in allPACKAGES_DYNAMICin oe-core (as in glob, but not regexp), so all those last '-' are optional
Are we going to fix this to actually be a glob or are we going to start treating it as a regex? Frankly I'd prefer to fix it to be a glob since that's what everyone has assumed it was since the beginning.
Cheers,
Paul
Signature · 2 lines
Paul Eggleton Intel Open Source Technology Centre
Quoted 25 lines · Paul Eggleton
Quoted 24 lines · On Thursday 11 October 2012 11:01:33 Martin Jansa wrote:
Review
Quoted 13 lines · On Wed, Oct 10, 2012 at 10:42:52AM +0000, [email protected] wrote:
Module: meta-openembedded.git
Branch: master
Commit:97350f52280ea9b2f3d7b36ef248be5ba3e7c696
URL:
http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=97350f52280ea9b2f3d7b36ef248be5ba3e7c696Author: Otavio Salvador <[email protected]> Date: Sat Oct 6 20:18:30 2012 +0000...
(quoted diff) +1
-1-PACKAGES_DYNAMIC = "lib*" +PACKAGES_DYNAMIC = "lib(av(codec|device|filter|format|util)|postproc)*"Unfortunatelly this does not work, this regexp matches everything starting with 'lib', so it's only a bit more strict then old version which matched everything starting with 'li' :).
Please change it to:
PACKAGES_DYNAMIC= "^lib(av(codec|device|filter|format|util)|postproc)" orPACKAGES_DYNAMIC= "^lib(av(codec|device|filter|format|util)|postproc).*"
Quoted 7 lines
Quoted 3 lines
^ isn't used in any
PACKAGES_DYNAMICin oe-core, but it could make matching faster * is used wrong in allPACKAGES_DYNAMICin oe-core (as in glob, but not regexp), so all those last '-' are optionalAre we going to fix this to actually be a glob or are we going to start treating it as a regex? Frankly I'd prefer to fix it to be a glob since that's what everyone has assumed it was since the beginning.
glob would make libav PACKAGES_DYNAMIC a bit longer (6 glob expressions) and would need another bitbake version bump + bump of required version in sanity test.
Or we can fix all PACKAGES_DYNAMIC expressions:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=3275
Cheers,
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]
Quoted 3 lines · Martin Jansa
glob would make libav
PACKAGES_DYNAMICa bit longer (6 glob expressions) and would need another bitbake version bump + bump of required version in sanity test.
Also, I don't think there's any precedent for globs in the metadata: all the other variables I can think of (COMPATIBLE_HOST etc) are regexps. The fact that people have been using it wrongly up to now doesn't seem like a particularly compelling reason to change bitbake's behaviour.
There aren't all that many PACKAGES_DYNAMICses in oe-core (and presumably not all that many more in meta-oe either) and it wouldn't be very hard to just fix them. I think we should do that.
p.
Quoted 37 lines · Martin Jansa
Quoted 27 lines · On Wed, Oct 10, 2012 at 10:42:52AM +0000, [email protected] wrote:
Module: meta-openembedded.git Branch: master Commit: 97350f52280ea9b2f3d7b36ef248be5ba3e7c696 URL: http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=97350f52280ea9b2f3d7b36ef248be5ba3e7c696Author: Otavio Salvador <[email protected]> Date: Sat Oct 6 20:18:30 2012 +0000libav: Change the
PACKAGES_DYNAMICexpression to be more restrictUsing 'lib*' we end having problem with every other package that generate libraries dynamically thus we changed it to match the library prefixes.
Signed-off-by Otavio Salvador <[email protected]>Signed-off-by Koen Kooi <[email protected]>---
meta-oe/recipes-multimedia/libav/libav.inc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)meta-oe/recipes-multimedia/libav/libav.inc +0
-0meta-oe/recipes-multimedia/libav/libav.inc python populate_packages_prepend() { · line 122
Quoted 5 lines
meta-oe/recipes-multimedia/libav/libav.inc +1
-1@@ -119,4 +119,4 @@ python populate_packages_prepend() { allow_links=True) } -PACKAGES_DYNAMIC = "lib*" +PACKAGES_DYNAMIC = "lib(av(codec|device|filter|format|util)|postproc)*"Unfortunatelly this does not work, this regexp matches everything starting with 'lib', so it's only a bit more strict then old version which matched everything starting with 'li' :).
Quoted 7 lines
Please change it to:
PACKAGES_DYNAMIC= "^lib(av(codec|device|filter|format|util)|postproc)" orPACKAGES_DYNAMIC= "^lib(av(codec|device|filter|format|util)|postproc).*"^ isn't used in any
PACKAGES_DYNAMICin oe-core, but it could make matching faster
* is used wrong in allPACKAGES_DYNAMICin oe-core (as in glob, but not regexp), so all those last '-' are optional
PACKAGES_DYNAMIC = "^lib(av(codec|device|filter|format|util)|postproc).*" is the right one.
Koen, I am traveling but people amend my patch commit it please ... or I send a new revision next week.
Signature · 3 lines
Otavio Salvador O.S. Systems E-mail: [email protected] http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br