Problem with first use of patman

U-Boot Albert ARIBAUD 3 participants 8 messages Oct 14, 2012 – Oct 15, 2012

lore

Share & tools

lore

Albert ARIBAUD

author

2012-10-14 18:52 UTC #0 lore raw

Hello Simon and the list,

I'm trying to start using patman, and -- probably out of sheer ignorance -- cannot make it work.

I've defined my .patman file with aliases for mvgbe, lacie_kw, arm, arm926ejs etc.

I am trying to generate patches from a local branch (which I have made available on the u-boot-arm repo as 'add-ws-support') which has two commits.

Top commit contains some matman tags, but the error is the without any tag.

The complete error is:

albert at lilith:~/src/u-boot-arm$ tools/patman/patman -n -c2 Traceback (most recent call last):
File "tools/patman/patman", line 125, in <module>
series = patchstream.GetMetaData(options.start, options.count)
File "/home/albert/src/u-boot-arm/tools/patman/patchstream.py", line
352, in GetMetaData ps.ProcessLine(line)
File "/home/albert/src/u-boot-arm/tools/patman/patchstream.py", line
190, in ProcessLine self.commit.subject = line
AttributeError: 'NoneType' object has no attribute 'subject' albert at lilith:~/src/u-boot-arm$

Can Simon (or someone who's already bumped into this error) tell me what I'm doing wrong?

Amicalement,

Signature · 1 line

Albert.

Daniel Schwierzeck

2012-10-14 21:13 UTC #1 lore raw

Hi Albert,

2012/10/14 Albert ARIBAUD <[email protected]>:

Quoted 28 lines

Hello Simon and the list,
I'm trying to start using patman, and -- probably out of sheer ignorance -- cannot make it work.
I've defined my .patman file with aliases for mvgbe, lacie_kw, arm, arm926ejs etc.
I am trying to generate patches from a local branch (which I have made available on the u-boot-arm repo as 'add-ws-support') which has two commits.
Top commit contains some matman tags, but the error is the without any tag.
The complete error is:
albert at lilith:~/src/u-boot-arm$ tools/patman/patman -n -c2 Traceback (most recent call last):
File "tools/patman/patman", line 125, in <module>
series = patchstream.GetMetaData(options.start, options.count)
File "/home/albert/src/u-boot-arm/tools/patman/patchstream.py", line
352, in GetMetaData ps.ProcessLine(line)
File "/home/albert/src/u-boot-arm/tools/patman/patchstream.py", line
190, in ProcessLine self.commit.subject = line
AttributeError: 'NoneType' object has no attribute 'subject' albert at lilith:~/src/u-boot-arm$

Quoted 3 lines

Can Simon (or someone who's already bumped into this error) tell me what I'm doing wrong?

I've had the same issue. Try the --no-tags option. Without that option all tags in the commit summary (e.g. 'arm: some-board: some commit summary') will be parsed which causes several errors.

Signature · 2 lines

Best regards,
Daniel

Albert ARIBAUD

author

2012-10-14 21:40 UTC #2 lore raw

Hi Daniel,

Quoted 31 lines · Daniel Schwierzeck

Hi Albert,
2012/10/14 Albert ARIBAUD <[email protected]>:
Quoted 28 lines
Hello Simon and the list,
I'm trying to start using patman, and -- probably out of sheer ignorance -- cannot make it work.
I've defined my .patman file with aliases for mvgbe, lacie_kw, arm, arm926ejs etc.
I am trying to generate patches from a local branch (which I have made available on the u-boot-arm repo as 'add-ws-support') which has two commits.
Top commit contains some matman tags, but the error is the without any tag.
The complete error is:
albert at lilith:~/src/u-boot-arm$ tools/patman/patman -n -c2 Traceback (most recent call last):
File "tools/patman/patman", line 125, in <module>
series = patchstream.GetMetaData(options.start, options.count)
File "/home/albert/src/u-boot-arm/tools/patman/patchstream.py", line
352, in GetMetaData ps.ProcessLine(line)
File "/home/albert/src/u-boot-arm/tools/patman/patchstream.py", line
190, in ProcessLine self.commit.subject = line
AttributeError: 'NoneType' object has no attribute 'subject' albert at lilith:~/src/u-boot-arm$

Quoted 7 lines

Quoted 3 lines
Can Simon (or someone who's already bumped into this error) tell me what I'm doing wrong?
I've had the same issue. Try the --no-tags option. Without that option all tags in the commit summary (e.g. 'arm: some-board: some commit summary') will be parsed which causes several errors.

Thanks for the suggestion.

However, /tools/patman/patman --no-tags -n -c2 gives the same error messages. :(

Amicalement,

Signature · 1 line

Albert.

Daniel Schwierzeck

2012-10-14 21:58 UTC #3 lore raw

2012/10/14 Albert ARIBAUD <[email protected]>:

Quoted 40 lines

Hi Daniel,
Quoted 35 lines · Daniel Schwierzeck
Hi Albert,
2012/10/14 Albert ARIBAUD <[email protected]>:
Quoted 31 lines
Hello Simon and the list,
I'm trying to start using patman, and -- probably out of sheer ignorance -- cannot make it work.
I've defined my .patman file with aliases for mvgbe, lacie_kw, arm, arm926ejs etc.
I am trying to generate patches from a local branch (which I have made available on the u-boot-arm repo as 'add-ws-support') which has two commits.
Top commit contains some matman tags, but the error is the without any tag.
The complete error is:
albert at lilith:~/src/u-boot-arm$ tools/patman/patman -n -c2 Traceback (most recent call last):
File "tools/patman/patman", line 125, in <module>
series = patchstream.GetMetaData(options.start, options.count)
File "/home/albert/src/u-boot-arm/tools/patman/patchstream.py", line
352, in GetMetaData ps.ProcessLine(line)
File "/home/albert/src/u-boot-arm/tools/patman/patchstream.py", line
190, in ProcessLine self.commit.subject = line
AttributeError: 'NoneType' object has no attribute 'subject' albert at lilith:~/src/u-boot-arm$
Can Simon (or someone who's already bumped into this error) tell me what I'm doing wrong?

Quoted 9 lines

Quoted 3 lines
I've had the same issue. Try the --no-tags option. Without that option all tags in the commit summary (e.g. 'arm: some-board: some commit summary') will be parsed which causes several errors.
Thanks for the suggestion.
However, /tools/patman/patman --no-tags -n -c2 gives the same error messages. :(

another workaround you could try is: export LANG=C patman does not work with a default locale other than english

Signature · 2 lines

Best regards,
Daniel

Albert ARIBAUD

author

2012-10-14 22:13 UTC #4 lore raw

Hi Daniel,

Quoted 45 lines · Daniel Schwierzeck

2012/10/14 Albert ARIBAUD <[email protected]>:
Quoted 44 lines
Hi Daniel,
Quoted 38 lines · Daniel Schwierzeck
Hi Albert,
2012/10/14 Albert ARIBAUD <[email protected]>:
Quoted 28 lines
Hello Simon and the list,
I'm trying to start using patman, and -- probably out of sheer ignorance -- cannot make it work.
I've defined my .patman file with aliases for mvgbe, lacie_kw, arm, arm926ejs etc.
I am trying to generate patches from a local branch (which I have made available on the u-boot-arm repo as 'add-ws-support') which has two commits.
Top commit contains some matman tags, but the error is the without any tag.
The complete error is:
albert at lilith:~/src/u-boot-arm$ tools/patman/patman -n -c2 Traceback (most recent call last):
File "tools/patman/patman", line 125, in <module>
series = patchstream.GetMetaData(options.start, options.count)
File "/home/albert/src/u-boot-arm/tools/patman/patchstream.py", line
352, in GetMetaData ps.ProcessLine(line)
File "/home/albert/src/u-boot-arm/tools/patman/patchstream.py", line
190, in ProcessLine self.commit.subject = line
AttributeError: 'NoneType' object has no attribute 'subject' albert at lilith:~/src/u-boot-arm$
Quoted 3 lines
Can Simon (or someone who's already bumped into this error) tell me what I'm doing wrong?
I've had the same issue. Try the --no-tags option. Without that option all tags in the commit summary (e.g. 'arm: some-board: some commit summary') will be parsed which causes several errors.

Quoted 8 lines

Quoted 5 lines
Thanks for the suggestion.
However, /tools/patman/patman --no-tags -n -c2 gives the same error messages. :(
another workaround you could try is: export LANG=C patman does not work with a default locale other than english

Tried LANG=C (and LC_ALL=C), no change. :(

Amicalement,

Signature · 1 line

Albert.

Simon Glass

2012-10-14 23:53 UTC #5 lore raw

In reply to Albert ARIBAUD

Hi Albert,

Quoted 4 lines · Albert ARIBAUD

Hello Simon and the list,
I'm trying to start using patman, and -- probably out of sheer ignorance -- cannot make it work.

Not a good first experience, sorry!

Quoted 24 lines

I've defined my .patman file with aliases for mvgbe, lacie_kw, arm, arm926ejs etc.
I am trying to generate patches from a local branch (which I have made available on the u-boot-arm repo as 'add-ws-support') which has two commits.
Top commit contains some matman tags, but the error is the without any tag.
The complete error is:
albert at lilith:~/src/u-boot-arm$ tools/patman/patman -n -c2 Traceback (most recent call last):
File "tools/patman/patman", line 125, in <module>
series = patchstream.GetMetaData(options.start, options.count)
File "/home/albert/src/u-boot-arm/tools/patman/patchstream.py", line
352, in GetMetaData ps.ProcessLine(line)
File "/home/albert/src/u-boot-arm/tools/patman/patchstream.py", line
190, in ProcessLine self.commit.subject = line
AttributeError: 'NoneType' object has no attribute 'subject' albert at lilith:~/src/u-boot-arm$

Quoted 2 lines

Can Simon (or someone who's already bumped into this error) tell me what I'm doing wrong?

I am really not sure about this. I can't seem to repeat the problem with your branch.

I am pretty sure from your backtrace that it is parsing the 'git log' output, and seeing a subject before it has seen a commit. It is possible that your 'git log' output is non-standard? Perhaps you could post that to the list?

It expects to see:

commit <hash>
Author: ...
Date: ...
<blank line>
commit subject
<commit lines if any>
commit <hash>
Author ...

You could put a 'print line, self.state' at the top of ProcessLine() in patchstream.py and that might help me debug it.

Regards,
SImon

Quoted 4 lines

Amicalement,
--
Albert.

Albert ARIBAUD

author

2012-10-15 05:45 UTC #6 lore raw

[U-Boot] Problem with first use of patman [FIXED]

Hi Simon,

Quoted 58 lines · Simon Glass

Hi Albert,
Quoted 4 lines · Albert ARIBAUD
Hello Simon and the list,
I'm trying to start using patman, and -- probably out of sheer ignorance -- cannot make it work.
Not a good first experience, sorry!
Quoted 24 lines
I've defined my .patman file with aliases for mvgbe, lacie_kw, arm, arm926ejs etc.
I am trying to generate patches from a local branch (which I have made available on the u-boot-arm repo as 'add-ws-support') which has two commits.
Top commit contains some matman tags, but the error is the without any tag.
The complete error is:
albert at lilith:~/src/u-boot-arm$ tools/patman/patman -n -c2 Traceback (most recent call last):
File "tools/patman/patman", line 125, in <module>
series = patchstream.GetMetaData(options.start, options.count)
File "/home/albert/src/u-boot-arm/tools/patman/patchstream.py", line
352, in GetMetaData ps.ProcessLine(line)
File "/home/albert/src/u-boot-arm/tools/patman/patchstream.py", line
190, in ProcessLine self.commit.subject = line
AttributeError: 'NoneType' object has no attribute 'subject' albert at lilith:~/src/u-boot-arm$
Quoted 2 lines
Can Simon (or someone who's already bumped into this error) tell me what I'm doing wrong?
I am really not sure about this. I can't seem to repeat the problem with your branch.
I am pretty sure from your backtrace that it is parsing the 'git log' output, and seeing a subject before it has seen a commit. It is possible that your 'git log' output is non-standard? Perhaps you could post that to the list?
It expects to see:
commit <hash>
Author: ...
Date: ...
<blank line>
commit subject
<commit lines if any>
commit <hash>
Author ...

Quoted 2 lines

You could put a 'print line, self.state' at the top of ProcessLine() in patchstream.py and that might help me debug it.

Thanks! Your hint about 'git log' made me find the cause of the problem.

My git log content is in no way special... except it has color ( 'ui = always' in my .gitconfig) ! This is what troubled patman: trying with the color spec in .git config commented out, it works ok.

I have located two places in patman where it calls git log, added option --no-color to them, verified that it worked with color.ui=auto in my .gitconfig... then used patman to send these very fixes to the list. :)

Quoted 2 lines

Regards,
SImon

Amicalement,

Signature · 1 line

Albert.

Simon Glass

2012-10-15 17:17 UTC #7 lore raw

[U-Boot] Problem with first use of patman [FIXED]

Hi Albert,

Quoted 68 lines · Albert ARIBAUD

Hi Simon,
Quoted 58 lines · Simon Glass
Hi Albert,
Quoted 4 lines · Albert ARIBAUD
Hello Simon and the list,
I'm trying to start using patman, and -- probably out of sheer ignorance -- cannot make it work.
Not a good first experience, sorry!
Quoted 24 lines
I've defined my .patman file with aliases for mvgbe, lacie_kw, arm, arm926ejs etc.
I am trying to generate patches from a local branch (which I have made available on the u-boot-arm repo as 'add-ws-support') which has two commits.
Top commit contains some matman tags, but the error is the without any tag.
The complete error is:
albert at lilith:~/src/u-boot-arm$ tools/patman/patman -n -c2 Traceback (most recent call last):
File "tools/patman/patman", line 125, in <module>
series = patchstream.GetMetaData(options.start, options.count)
File "/home/albert/src/u-boot-arm/tools/patman/patchstream.py", line
352, in GetMetaData ps.ProcessLine(line)
File "/home/albert/src/u-boot-arm/tools/patman/patchstream.py", line
190, in ProcessLine self.commit.subject = line
AttributeError: 'NoneType' object has no attribute 'subject' albert at lilith:~/src/u-boot-arm$
Quoted 2 lines
Can Simon (or someone who's already bumped into this error) tell me what I'm doing wrong?
I am really not sure about this. I can't seem to repeat the problem with your branch.
I am pretty sure from your backtrace that it is parsing the 'git log' output, and seeing a subject before it has seen a commit. It is possible that your 'git log' output is non-standard? Perhaps you could post that to the list?
It expects to see:
commit <hash>
Author: ...
Date: ...
<blank line>
commit subject
<commit lines if any>
commit <hash>
Author ...
Quoted 2 lines
You could put a 'print line, self.state' at the top of ProcessLine() in patchstream.py and that might help me debug it.
Thanks! Your hint about 'git log' made me find the cause of the problem.

Quoted 8 lines

My git log content is in no way special... except it has color ( 'ui = always' in my .gitconfig) ! This is what troubled patman: trying with the color spec in .git config commented out, it works ok.
I have located two places in patman where it calls git log, added option --no-color to them, verified that it worked with color.ui=auto in my .gitconfig... then used patman to send these very fixes to the list. :)

That's great to hear, and thanks for the patch.

Quoted 3 lines

Amicalement,
--
Albert.

Regards,
Simon