Skip to contentSkip to conversation

packet: minor: remove unused err assignment

PATCH Applied Daniel Borkmann 2 participants 2 messages Oct 24, 2012 – Oct 26, 2012

Subsystems (3)
Networking Network drivers Packet sockets
lore
Share & tools
lore

Daniel Borkmann

author
#0 lore raw

PATCH 1/1 packet: minor: remove unused err assignment

This tiny patch removes two unused err assignments. In those two cases the err variable is either overwritten with another value at a later point in time without having read the previous assigment, or it is assigned and the function returns without using/reading err after the assignment.

Signed-off-by Daniel Borkmann <[email protected]>
---
 net/packet/af_packet.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
net/packet/af_packet.c +0 -2
index 94060ed..9034f52 100644
@@ -1907,7 +1907,6 @@ static int tpacket_fill_skb(struct packet_sock *po, struct sk_buff *skb,
 		to_write -= dev->hard_header_len;
 	}
 
-	err = -EFAULT;
 	offset = offset_in_page(data);
 	len_max = PAGE_SIZE - offset;
 	len = ((to_write > len_max) ? len_max : to_write);

@@ -1957,7 +1956,6 @@ static int tpacket_snd(struct packet_sock *po, struct msghdr *msg)
 
 	mutex_lock(&po->pg_vec_lock);
 
-	err = -EBUSY;
 	if (saddr == NULL) {
 		dev = po->prot_hook.dev;
 		proto	= po->num;
maintainer Applied
#1 lore raw

From: Daniel Borkmann <[email protected]>
Date: Wed, 24 Oct 2012 15:27:24 +0200

Quoted 6 lines

This tiny patch removes two unused err assignments. In those two cases the err variable is either overwritten with another value at a later point in time without having read the previous assigment, or it is assigned and the function returns without using/reading err after the assignment.

Signed-off-by Daniel Borkmann <[email protected]>

Applied, thanks.