Skip to contentSkip to conversation

compat: VIDEO_SET_SPU_PALETTE missing error check

PATCH RESEND New Kees Cook 1 participant 1 message Oct 24, 2012 VFS

lore
Share & tools
lore

Kees Cook

author
#0 lore raw

PATCH RESEND 1/1 compat: VIDEO_SET_SPU_PALETTE missing error check

The compat ioctl for VIDEO_SET_SPU_PALETTE was missing an error check while converting ioctl arguments. This could lead to leaking kernel stack contents into userspace.

Patch extracted from existing fix in grsecurity.

Cc Andrew Morton <[email protected]>
Cc David Miller <[email protected]>
Cc Brad Spengler <[email protected]>
Cc PaX Team <[email protected]>
Cc [email protected]
Signed-off-by Kees Cook <[email protected]>
---
 fs/compat_ioctl.c |    2 ++
 1 file changed, 2 insertions(+)
fs/compat_ioctl.c +2 -0
index f505402..4c6285f 100644
@@ -210,6 +210,8 @@ static int do_video_set_spu_palette(unsigned int fd, unsigned int cmd,
 
 	err  = get_user(palp, &up->palette);
 	err |= get_user(length, &up->length);
+	if (err)
+		return -EFAULT;
 
 	up_native = compat_alloc_user_space(sizeof(struct video_spu_palette));
 	err  = put_user(compat_ptr(palp), &up_native->palette);
Signature · 6 lines
1.7.9.5


-- 
Kees Cook
Chrome OS Security