mei: copy_from_user() doesn't return an error code

PATCH New Dan Carpenter 1 participant 1 message Oct 26, 2012

Subsystems (3)

Kernel janitors Char and misc drivers Intel management engine (mei)

lore

Share & tools

lore

Dan Carpenter

author

2012-10-26 07:00 UTC #0 lore raw

PATCH 1/1 mei: copy_from_user() doesn't return an error code

copy_from_user() returns the number of bytes remaining but we should be returning -EFAULT here.

Signed-off-by Dan Carpenter <[email protected]>

---
Only needed in linux-next.

drivers/misc/mei/main.c +2 -2

index ed4943f..ce1014e 100644
@@ -607,8 +607,8 @@ static ssize_t mei_write(struct file *file, const char __user *ubuf,
 
 	dev_dbg(&dev->pdev->dev, "cb request size = %zd\n", length);
 
-	rets = copy_from_user(write_cb->request_buffer.data, ubuf, length);
-	if (rets)
+	rets = -EFAULT;
+	if (copy_from_user(write_cb->request_buffer.data, ubuf, length))
 		goto unlock_dev;
 
 	cl->sm_state = 0;