Skip to contentSkip to conversation

Input: wacom - fix a check for WACOM_24HDT

PATCH In review Dan Carpenter 2 participants 2 messages Oct 29, 2012 – Oct 31, 2012

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Input: wacom - fix a check for WACOM_24HDT

The current condition is always true. From the context, it looks like we should be checking if ->type = WACOM_24HDT.

drivers/input/tablet/wacom_sys.c +1 -1
index 2c1e12b..858ad44 100644
@@ -391,7 +391,7 @@ static int wacom_parse_hid(struct usb_interface *intf,
 							features->pktlen = WACOM_PKGLEN_TPC2FG;
 						}
 
-						if (features->type = MTSCREEN || WACOM_24HDT)
+						if (features->type = MTSCREEN || features->type = WACOM_24HDT)
 							features->pktlen = WACOM_PKGLEN_MTOUCH;
 
 						if (features->type = BAMBOO_PT) {
maintainer
#1 lore raw
Quoted 4 lines · Dan Carpenter

The current condition is always true. From the context, it looks like we should be checking if ->type = WACOM_24HDT.

Thank you Dan, however I already have a patch from Jason Gerecke addressing this issue.

Quoted 14 lines
drivers/input/tablet/wacom_sys.c +1 -1
index 2c1e12b..858ad44 100644
@@ -391,7 +391,7 @@ static int wacom_parse_hid(struct usb_interface *intf,
 							features->pktlen = WACOM_PKGLEN_TPC2FG;
 						}
 
-						if (features->type = MTSCREEN || WACOM_24HDT)
+						if (features->type = MTSCREEN || features->type = WACOM_24HDT)
 							features->pktlen = WACOM_PKGLEN_MTOUCH;
 
 						if (features->type = BAMBOO_PT) {
Signature · 1 line
Dmitry