Skip to contentSkip to conversation

fanotify: Fix missing break

PATCH New Alan Cox 1 participant 1 message Oct 29, 2012

Subsystems (2)
lore
Share & tools
lore

Alan Cox

author
#0 lore raw

PATCH 1/1 fanotify: Fix missing break

From: Eric Paris <[email protected]>

Anders Blondell noted in 2010 that Fanotify lost events and provided a test case. Eric Paris confirmed it was a bug and posted a fix to the list

https://groups.google.com/forum/?fromgroups=#!topic/linux.kernel/RrJfTfyW2BE

but never applied it. Repeated attempts over time to actually get him to apply it have never had a reply from anyone who has raised it

So apply it anyway

---

 fs/notify/fanotify/fanotify.c |    1 +
 1 file changed, 1 insertion(+)
fs/notify/fanotify/fanotify.c +1 -0
index aeb5b5a..0c2f912 100644
@@ -27,6 +27,7 @@ static bool should_merge(struct fsnotify_event *old, struct fsnotify_event *new)
 			if ((old->path.mnt == new->path.mnt) &&
 			    (old->path.dentry == new->path.dentry))
 				return true;
+			break;
 		case (FSNOTIFY_EVENT_NONE):
 			return true;
 		default: