Skip to contentSkip to conversation

ping -f is broken in iputils 20121011

DISCUSSION Applied Mohammad Alsaleh 3 participants 4 messages Oct 31, 2012 – Nov 5, 2012 1 message not in the archive

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 20121030205249.GA2817@mail

#2 lore raw
Quoted 4 lines · Mohammad Alsaleh
Quoted 3 lines · Mohammad Alsaleh

As explained in this bug report(1). ping -f seems to be broken in iputils 20121011.

Quoted 8 lines
Quoted 1 line

(1) https://bugs.archlinux.org/task/32306

Bisected to commit 8feb586c4c6df32badb159947ed233898891aecd --
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Can you please try the attached patch?

Signature · 2 lines
Jan Synacek
Software Engineer, BaseOS team Brno, Red Hat
ping_common.h +1 -1
@@ -141,7 +141,7 @@ static inline void write_stdout(const ch
 	do {
 		cc = write(STDOUT_FILENO, str + o, len - o);
 		o += cc;
-	} while (len >= o || cc < 0);
+	} while (len > o || cc < 0);
 }
 
 /*
ping_common.c +1 -1
@@ -776,7 +776,7 @@ restamp:
 		if (!csfailed)
 			write_stdout("\b \b", 3);
 		else
-			write_stdout("\bC", 1);
+			write_stdout("\bC", 2);
 	} else {
 		int i;
 		__u8 *cp, *dp;
author
#3 lore raw
Quoted 39 lines · Mohammad Alsaleh
Quoted 12 lines · Mohammad Alsaleh
Quoted 4 lines

As explained in this bug report(1). ping -f seems to be broken in iputils 20121011.

(1) https://bugs.archlinux.org/task/32306

Bisected to commit 8feb586c4c6df32badb159947ed233898891aecd --
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Can you please try the attached patch?

Signature · 7 lines
Jan Synacek
Software Engineer, BaseOS team Brno, Red Hat

--- iputils-s20121011/ping_common.h	2012-11-05 10:07:40.065281888
+0100
+++ iputils-s20121011-new/ping_common.h	2012-11-05 10:07:22.001268362
+0100
ping_common.h +4 -2
@@ -141,7 +141,7 @@ static inline void write_stdout(const ch
 	do {
 		cc = write(STDOUT_FILENO, str + o, len - o);
 		o += cc;
-	} while (len >= o || cc < 0);
+	} while (len > o || cc < 0);
 }
 
 /*
--- iputils-s20121011/ping_common.c	2012-11-05 10:07:40.066281889
+0100
+++ iputils-s20121011-new/ping_common.c	2012-11-05 10:07:22.007268368
+0100

ping_common.h restamp: · line 782

Quoted 8 lines
ping_common.h +1 -1
@@ -776,7 +776,7 @@ restamp:
 		if (!csfailed)
 			write_stdout("\b \b", 3);
 		else
-			write_stdout("\bC", 1);
+			write_stdout("\bC", 2);
 	} else {
 		int i;
 		__u8 *cp, *dp;

Sorry if this reply does not appear in the right thread. I'm not subscribed to the list.

I can confirm the patch fixes the bug.

Applied
#4 lore raw
In reply to Jan Synacek

Hi,

Quoted 7 lines · Jan Synacek
Quoted 6 lines · Mohammad Alsaleh
Quoted 4 lines · Mohammad Alsaleh

As explained in this bug report(1). ping -f seems to be broken in iputils 20121011.

(1) https://bugs.archlinux.org/task/32306

Quoted 9 lines
Quoted 6 lines

Bisected to commit 8feb586c4c6df32badb159947ed233898891aecd --
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Can you please try the attached patch?

I applied this patch. Thank you.
Mohammad, Thank you for spotting this.

--yoshfuji