Skip to contentSkip to conversation

diffutils: only needs gettext if locale is selected

PATCH New Arnout Vandecappelle (Essensium/Mind) 4 participants 16 messages Nov 1, 2012 – Aug 11, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/9 diffutils: only needs gettext if locale is selected

From: Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Also add missing select in Config.in.

---
 package/diffutils/Config.in    |    1 +
 package/diffutils/diffutils.mk |    3 +--
 2 files changed, 2 insertions(+), 2 deletions(-)
package/diffutils/Config.in +1 -0
index 86da5d3..4cc16e2 100644
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_DIFFUTILS
 	bool"diffutils"
 	depends on BR2_USE_WCHAR
+	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
 	help
 	  GNU diff. Compare files per line.
 
package/diffutils/diffutils.mk +1 -2
index 168d040..2530763 100644
@@ -6,8 +6,7 @@
 
 DIFFUTILS_VERSION = 3.2
 DIFFUTILS_SITE = $(BR2_GNU_MIRROR)/diffutils
-DIFFUTILS_DEPENDENCIES = \
-	$(if $(BR2_PACKAGE_GETTEXT),gettext)
+DIFFUTILS_DEPENDENCIES = $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext)
 
 ifeq ($(BR2_PACKAGE_BUSYBOX),y)
 DIFFUTILS_DEPENDENCIES += busybox
#1 lore raw

PATCH 2/9 flex: only needs gettext if locale is selected

From: Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Also add missing select in Config.in.

---
 package/flex/Config.in |    1 +
 package/flex/flex.mk   |    3 +--
 2 files changed, 2 insertions(+), 2 deletions(-)
package/flex/Config.in +1 -0
index b10eb00..8ce4ccd 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_FLEX
 	bool "flex"
+	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
 	help
 	  A fast lexical analyser generator.  A tool for generating
 	  programs that perform pattern-matching on text.
package/flex/flex.mk +1 -2
index 2599cdc..fe21432 100644
@@ -11,8 +11,7 @@ FLEX_PATCH = flex_$(FLEX_VERSION)-$(FLEX_PATCH_VERSION).diff.gz
 FLEX_SITE = $(BR2_DEBIAN_MIRROR)/debian/pool/main/f/flex
 FLEX_DIR = $(BUILD_DIR)/flex-$(FLEX_VERSION)
 FLEX_INSTALL_STAGING = YES
-FLEX_DEPENDENCIES = \
-	$(if $(BR2_PACKAGE_GETTEXT),gettext)
+FLEX_DEPENDENCIES = $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext)
 # we don't have a host-gettext/libintl
 HOST_FLEX_DEPENDENCIES =
 
#4 lore raw

PATCH 3/9 ndisc6: only needs gettext if locale is selected

In reply to Arnout Vandecappelle (Essensium/Mind)

From: Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Also add missing select in Config.in.

---
 package/ndisc6/Config.in |    1 +
 package/ndisc6/ndisc6.mk |    2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
package/ndisc6/Config.in +1 -0
index 126bfa2..6abe4ce 100644
@@ -4,6 +4,7 @@ comment "ndisc6 requires a toolchain with IPv6 support"
 config BR2_PACKAGE_NDISC6
 	bool "ndisc6 tools"
 	depends on BR2_INET_IPV6
+	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
 	help
 	  NDisc6 is a small collection of useful tools for IPv6 networking
 
package/ndisc6/ndisc6.mk +1 -1
index f58cc13..1d3c0e7 100644
@@ -10,7 +10,7 @@ NDISC6_SITE = http://www.remlab.net/files/ndisc6/
 NDISC6_CONF_ENV = CC="$(TARGET_CC) -std=gnu99"
 NDISC6_CONF_OPT = --localstatedir=/var --disable-rpath --disable-suid-install
 
-ifeq ($(BR2_PACKAGE_GETTEXT),y)
+ifeq ($(BR2_NEEDS_GETTEXT_IF_LOCALE),y)
 NDISC6_DEPENDENCIES += gettext
 NDISC6_CONF_ENV += LDFLAGS="$(TARGET_LDFLAGS) -lintl"
 endif
#7 lore raw

PATCH 4/9 util-linux: only needs gettext if locale is selected

In reply to Arnout Vandecappelle (Essensium/Mind)

From: Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Also add missing select in Config.in.

---
 package/util-linux/Config.in     |    1 +
 package/util-linux/util-linux.mk |    2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
package/util-linux/Config.in +1 -0
index 43a8444..88d08e7 100644
@@ -2,6 +2,7 @@ config BR2_PACKAGE_UTIL_LINUX
 	bool "util-linux"
 	depends on BR2_LARGEFILE
 	depends on BR2_USE_WCHAR
+	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
 	help
 	  Various useful/essential Linux utilities.
 
package/util-linux/util-linux.mk +1 -1
index f6028f4..f15baa7 100644
@@ -29,7 +29,7 @@ else
 UTIL_LINUX_CONF_OPT += --without-ncurses
 endif
 
-ifeq ($(BR2_PACKAGE_GETTEXT),y)
+ifeq ($(BR2_NEEDS_GETTEXT_IF_LOCALE),y)
 UTIL_LINUX_DEPENDENCIES += gettext
 UTIL_LINUX_MAKE_OPT += LIBS=-lintl
 endif
#8 lore raw

PATCH 5/9 lshw: fix build with no LOCALE support

In reply to Arnout Vandecappelle (Essensium/Mind)

From: Arnout Vandecappelle (Essensium/Mind) <[email protected]>

lshw doesn't need libintl if -DNONLS is defined.

---
 package/lshw/Config.in |    2 +-
 package/lshw/lshw.mk   |   12 +++++++++---
 2 files changed, 10 insertions(+), 4 deletions(-)
package/lshw/Config.in +1 -1
index 98beacd..afefa6c 100644
@@ -3,7 +3,7 @@ config BR2_PACKAGE_LSHW
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_LARGEFILE
 	depends on BR2_USE_WCHAR
-	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT
+	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
 	help
 	  lshw (Hardware Lister) is a small tool to provide
 	  detailed information on the hardware configuration of the machine.
package/lshw/lshw.mk +9 -3
index 68daa0d..b3c2214 100644
@@ -6,10 +6,16 @@
 
 LSHW_VERSION = B.02.16
 LSHW_SITE = http://ezix.org/software/files
+
+LSHW_CFLAGS = $(TARGET_CFLAGS)
+ifeq ($(BR2_ENABLE_LOCALE),)
+LSHW_CFLAGS += -DNONLS
+endif
+
 LSHW_MAKE_OPT = CC="$(TARGET_CC)" CXX="$(TARGET_CXX)" AR="$(TARGET_AR)" \
-	RPM_OPT_FLAGS="$(TARGET_CFLAGS)" all
-LSHW_MAKE_ENV = LIBS="$(if $(BR2_NEEDS_GETTEXT),-lintl)"
-LSHW_DEPENDENCIES = $(if $(BR2_NEEDS_GETTEXT),gettext)
+	RPM_OPT_FLAGS="$(LSHW_CFLAGS)" all
+LSHW_MAKE_ENV = LIBS="$(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),-lintl)"
+LSHW_DEPENDENCIES = $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext)
 
 define LSHW_BUILD_CMDS
 	$(LSHW_MAKE_ENV) $(MAKE) -C $(@D)/src $(LSHW_MAKE_OPT)
#11 lore raw

PATCH 6/9 avahi: remove double dependency on gettext

In reply to Arnout Vandecappelle (Essensium/Mind)

From: Arnout Vandecappelle (Essensium/Mind) <[email protected]>

---
 package/avahi/avahi.mk |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
package/avahi/avahi.mk +1 -4
index 5f07a2f..d96f24b 100644
@@ -133,10 +133,7 @@ else
 AVAHI_CONF_OPT += --disable-python
 endif
 
-ifeq ($(BR2_PACKAGE_GETTEXT),y)
-AVAHI_DEPENDENCIES += gettext
-AVAHI_MAKE_OPT = LIBS=-lintl
-endif
+AVAHI_MAKE_OPT += $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),LIBS=-lintl)
 
 define AVAHI_REMOVE_INITSCRIPT
 	rm -rf $(TARGET_DIR)/etc/init.d/avahi-*
#12 lore raw

PATCH 7/9 pulseaudio: remove dependency on gettext

In reply to Arnout Vandecappelle (Essensium/Mind)

From: Arnout Vandecappelle (Essensium/Mind) <[email protected]>

The dependency on gettext is only due to libglib2, not due to pulseaudio itself. It works fine without gettext if libglib2 is not selected.

---
v2: actually remove the gettext dependency this time; thanks Thomas

---
 package/multimedia/pulseaudio/Config.in     |    1 -
 package/multimedia/pulseaudio/pulseaudio.mk |    1 -
 2 files changed, 2 deletions(-)
package/multimedia/pulseaudio/Config.in +0 -1
index 6c767bb..0844192 100644
@@ -5,7 +5,6 @@ config BR2_PACKAGE_PULSEAUDIO
 	select BR2_PACKAGE_JSON_C
 	select BR2_PACKAGE_LIBSNDFILE
 	select BR2_PACKAGE_SPEEX
-	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT
 	help
 	  PulseAudio is a sound system for POSIX OSes, meaning that it
 	  is a proxy for your sound applications. It allows you to do
package/multimedia/pulseaudio/pulseaudio.mk +0 -1
index e78eb42..a842180 100644
@@ -16,7 +16,6 @@ PULSEAUDIO_CONF_OPT = \
 
 PULSEAUDIO_DEPENDENCIES = \
 	host-pkgconf libtool json-c libsndfile speex host-intltool \
-	$(if $(BR2_NEEDS_GETTEXT),gettext) \
 	$(if $(BR2_PACKAGE_LIBATOMIC_OPS),libatomic_ops) \
 	$(if $(BR2_PACKAGE_LIBSAMPLERATE),libsamplerate) \
 	$(if $(BR2_PACKAGE_ALSA_LIB),alsa-lib) \
#13 lore raw

PATCH 8/9 gdk-pixbuf: remove dependency on gettext

In reply to Arnout Vandecappelle (Essensium/Mind)

From: Arnout Vandecappelle (Essensium/Mind) <[email protected]>

The dependency on gettext comes from libglib2, not from gdk-pixbuf itself.

---
 package/gdk-pixbuf/Config.in     |    1 -
 package/gdk-pixbuf/gdk-pixbuf.mk |    1 -
 2 files changed, 2 deletions(-)
package/gdk-pixbuf/Config.in +0 -1
index 33b5f7c..f205793 100644
@@ -2,7 +2,6 @@ config BR2_PACKAGE_GDK_PIXBUF
 	bool "gdk-pixbuf"
 	depends on BR2_USE_WCHAR # glib2
 	select BR2_PACKAGE_LIBGLIB2
-	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT
 	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
 	help
 	  Gdk-Pixbuf is an image loader and scaler. It uses GObject
package/gdk-pixbuf/gdk-pixbuf.mk +0 -1
index 4e00c40..8c785cd 100644
@@ -40,7 +40,6 @@ GDK_PIXBUF_DEPENDENCIES += xlib_libX11
 endif
 
 GDK_PIXBUF_DEPENDENCIES += \
-	$(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext) \
 	$(if $(BR2_ENABLE_LOCALE),,libiconv) \
 	host-pkgconf libglib2
 
#14 lore raw

PATCH 9/9 libsoup: Remove redundant dependency on gettext

In reply to Arnout Vandecappelle (Essensium/Mind)

From: Arnout Vandecappelle (Essensium/Mind) <[email protected]>

libsoup doesn't use intl stuff directly, but uses gi18n. libglib2 already has all required dependencies on gettext.

---
 package/libsoup/Config.in  |    1 -
 package/libsoup/libsoup.mk |    2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)
package/libsoup/Config.in +0 -1
index 57b425f..b79108e 100644
@@ -3,7 +3,6 @@ config BR2_PACKAGE_LIBSOUP
 	depends on BR2_USE_WCHAR # glib2 and gnutls
 	select BR2_PACKAGE_LIBXML2
 	select BR2_PACKAGE_LIBGLIB2
-	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT
 	help
 	  libsoup is an HTTP client/server library. It uses GObject
 	  and the GLib main loop, to integrate well with GNOME
package/libsoup/libsoup.mk +1 -1
index 2f173df..2a2d8bf 100644
@@ -19,7 +19,7 @@ endif
 
 LIBSOUP_CONF_OPT = --disable-glibtest --without-gnome
 
-LIBSOUP_DEPENDENCIES = $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext) host-pkgconf host-libglib2 libglib2 libxml2
+LIBSOUP_DEPENDENCIES = host-pkgconf host-libglib2 libglib2 libxml2
 
 ifeq ($(BR2_PACKAGE_LIBSOUP_SSL),y)
 LIBSOUP_DEPENDENCIES += glib-networking
#9 lore raw

PATCH 5/9 lshw: fix build with no LOCALE support

In reply to Arnout Vandecappelle (Essensium/Mind)

Dear Arnout Vandecappelle \(Essensium/Mind\),

Quoted 9 lines · Arnout Vandecappelle \(Essensium/Mind\)

From: Arnout Vandecappelle (Essensium/Mind) <[email protected]>

lshw doesn't need libintl if -DNONLS is defined.

---
 package/lshw/Config.in |    2 +-
 package/lshw/lshw.mk   |   12 +++++++++---
 2 files changed, 10 insertions(+), 4 deletions(-)

I've applied the following patches of this series:

09704e7ee8a6e49d68359df7b4ebffb4d7819965 libsoup: Remove redundant dependency on gettext de1932aaff2d0662b268a4ad71905f987155f0bf gdk-pixbuf: remove dependency on gettext 3cb28e173ca15a7ae9e7b741464f6e3e6936165f pulseaudio: remove dependency on gettext 0c2de8da28b859d0ace26743095fb73ae1a94940 avahi: remove double dependency on gettext cdc2420b4c332a0d69b8198c756bb054386c912a lshw: fix build with no LOCALE support da8860e4da533bbe3d684354b37174adb0e23b98 util-linux: only needs gettext if locale is selected

I think those ones were the remaining non-applied patches for this series.

Thanks!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#10 lore raw

PATCH 5/9 lshw: fix build with no LOCALE support

Quoted 16 lines · Thomas Petazzoni

Dear Arnout Vandecappelle \(Essensium/Mind\),

Quoted 9 lines · Arnout Vandecappelle \(Essensium/Mind\)

From: Arnout Vandecappelle (Essensium/Mind) <[email protected]>

lshw doesn't need libintl if -DNONLS is defined.

---
  package/lshw/Config.in |    2 +-
  package/lshw/lshw.mk   |   12 +++++++++---
  2 files changed, 10 insertions(+), 4 deletions(-)

I've applied the following patches of this series:

Quoted 8 lines

09704e7ee8a6e49d68359df7b4ebffb4d7819965 libsoup: Remove redundant dependency on gettext de1932aaff2d0662b268a4ad71905f987155f0bf gdk-pixbuf: remove dependency on gettext 3cb28e173ca15a7ae9e7b741464f6e3e6936165f pulseaudio: remove dependency on gettext 0c2de8da28b859d0ace26743095fb73ae1a94940 avahi: remove double dependency on gettext cdc2420b4c332a0d69b8198c756bb054386c912a lshw: fix build with no LOCALE support da8860e4da533bbe3d684354b37174adb0e23b98 util-linux: only needs gettext if locale is selected

I think those ones were the remaining non-applied patches for this series.

Yep, looks complete to me.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F