Skip to contentSkip to conversation

mmc: add no simultaenous power and vdd

PATCH New RgC 2 participants 4 messages Nov 4, 2012 MMC, SD and SDIO

lore
Share & tools
lore

RgC

author
#0 lore raw

PATCH 1/1 mmc: add no simultaenous power and vdd

Bring in the code from Linux kernel.

Signed-off-by RgC <[email protected]>
CC Andy Fleming <[email protected]>

modified: drivers/mmc/sdhci.c
modified: include/sdhci.h

---
 drivers/mmc/sdhci.c | 3 +++
 include/sdhci.h     | 1 +
 2 files changed, 4 insertions(+)
drivers/mmc/sdhci.c +3 -0
index 7845f87..b9cbe34 100644
@@ -340,6 +340,9 @@ static void sdhci_set_power(struct sdhci_host *host, unsigned short power)
 		return;
 	}
 
+	if (host->quirks & SDHCI_QUIRK_NO_SIMULT_VDD_AND_POWER)
+		sdhci_writeb(host, pwr, SDHCI_POWER_CONTROL);
+
 	pwr |= SDHCI_POWER_ON;
 
 	sdhci_writeb(host, pwr, SDHCI_POWER_CONTROL);
include/sdhci.h +1 -0
index c44793d..cffbe53 100644
@@ -225,6 +225,7 @@
 #define SDHCI_QUIRK_BROKEN_VOLTAGE	(1 << 4)
 #define SDHCI_QUIRK_NO_CD		(1 << 5)
 #define SDHCI_QUIRK_WAIT_SEND_CMD	(1 << 6)
+#define SDHCI_QUIRK_NO_SIMULT_VDD_AND_POWER (1 << 7)
 
 /* to make gcc happy */
 struct sdhci_host;
Signature · 9 lines
1.8.0

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 487 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121104/c96b4a44/attachment.pgp>
#1 lore raw

PATCH 1/1 mmc: add no simultaenous power and vdd

Dear RgC,

Quoted 2 lines · In message <20121104001018.GA57283@crg> you wrote:

Bring in the code from Linux kernel.

PLease provide exact reference; see
http://www.denx.de/wiki/view/U-Boot/Patches#Attributing_Code_Copyrights_Sign

Quoted 1 line
Signed-off-by RgC <[email protected]>

Sorry, but we need a real name here.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
He is truly wise who gains wisdom from another's mishap.
author
#2 lore raw

PATCH 1/1 mmc: add no simultaenous power and vdd

Dear Wolfgang,

Quoted 9 lines · Wolfgang Denk

Dear RgC,

Quoted 2 lines · In message <20121104001018.GA57283@crg> you wrote:

Bring in the code from Linux kernel.

PLease provide exact reference; see
http://www.denx.de/wiki/view/U-Boot/Patches#Attributing_Code_Copyrights_Sign

Sorry wasn't reading the documents, my bad.

The orignal code was brought in by commit e08c1694d9e2138204f2b79b73f0f159074ce2f5 last 2008 to the Linux kernel but has since evolved.

Quoted 3 lines
Quoted 1 line
Signed-off-by RgC <[email protected]>

Sorry, but we need a real name here.

Sorry. The real name is Rommel G Custodio.
I will prepare a V2 of the patch later.

Quoted 4 lines

Best regards,

Wolfgang Denk

All the best,
Rommel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 487 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121104/f4b00121/attachment.pgp>

author
#3 lore raw

PATCH v2 1/1 mmc: add no simultaenous power and vdd

In reply to RgC

Bring in the code from Linux kernel.

Added to Linux kernel by:
commit e08c1694d9e2138204f2b79b73f0f159074ce2f5

Author: Andres Salomon <[email protected]>
Date:   Fri Jul 4 10:00:03 2008 -0700

Some HW balks when writing both voltage setting and power up at the same time to SDHCI_POWER_CONTROL register.

Signed-off-by Rommel G Custodio <[email protected]>
CC Andy Fleming <[email protected]>

v2: fix attribution and SOB

---
 drivers/mmc/sdhci.c | 3 +++
 include/sdhci.h     | 1 +
 2 files changed, 4 insertions(+)
drivers/mmc/sdhci.c +3 -0
index 7845f87..b9cbe34 100644
@@ -340,6 +340,9 @@ static void sdhci_set_power(struct sdhci_host *host, unsigned short power)
 		return;
 	}
 
+	if (host->quirks & SDHCI_QUIRK_NO_SIMULT_VDD_AND_POWER)
+		sdhci_writeb(host, pwr, SDHCI_POWER_CONTROL);
+
 	pwr |= SDHCI_POWER_ON;
 
 	sdhci_writeb(host, pwr, SDHCI_POWER_CONTROL);
include/sdhci.h +1 -0
index c44793d..cffbe53 100644
@@ -225,6 +225,7 @@
 #define SDHCI_QUIRK_BROKEN_VOLTAGE	(1 << 4)
 #define SDHCI_QUIRK_NO_CD		(1 << 5)
 #define SDHCI_QUIRK_WAIT_SEND_CMD	(1 << 6)
+#define SDHCI_QUIRK_NO_SIMULT_VDD_AND_POWER (1 << 7)
 
 /* to make gcc happy */
 struct sdhci_host;
Signature · 9 lines
1.8.0

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 487 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121104/ba48fdbf/attachment.pgp>