Skip to contentSkip to conversation

wfcqueue: Fix lock and unlock functions

PATCH Mathieu Desnoyers 1 participant 1 message Nov 16, 2012 1 message not in the archive

lore
Share & tools
lore

Mathieu Desnoyers

author Applied
#1 lore raw
In reply to a message not in the archive
Quoted 6 lines · * Paul E. McKenney ([email protected]) wrote:

The current implementation of cds_wfcq_dequeue_lock() and cds_wfcq_dequeue_unlock() entails mutually assured recursion. Redirect to _cds_wfcq_dequeue_lock() and _cds_wfcq_dequeue_unlock(), respectively.

Good catch !!

Merged, thanks!

Mathieu

Quoted 22 lines
wfcqueue.c +2 -2
index 3474ee0..90b810e 100644
@@ -57,13 +57,13 @@ void cds_wfcq_enqueue(struct cds_wfcq_head *head,
 void cds_wfcq_dequeue_lock(struct cds_wfcq_head *head,
 		struct cds_wfcq_tail *tail)
 {
-	cds_wfcq_dequeue_lock(head, tail);
+	_cds_wfcq_dequeue_lock(head, tail);
 }
 
 void cds_wfcq_dequeue_unlock(struct cds_wfcq_head *head,
 		struct cds_wfcq_tail *tail)
 {
-	cds_wfcq_dequeue_unlock(head, tail);
+	_cds_wfcq_dequeue_unlock(head, tail);
 }
 
 struct cds_wfcq_node *cds_wfcq_dequeue_blocking(
Signature · 4 lines
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com